Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-08-23 13:46:45 +02:00
Code Issues Projects Releases Wiki Activity

feat: rename type

Browse Source
This commit is contained in:
Thomas Heartman 2023-11-21 13:18:22 +01:00
parent 7162d82234
commit ed6b496b23
No known key found for this signature in database
GPG Key ID: BD1F880DAED1EE78
3 changed files with 13 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/lib/segments/segment-service-interface.ts
View File

@ -2,7 +2,7 @@ import { ChangeRequestStrategy } from 'lib/features/change-request-segment-usage
import { UpsertSegmentSchema } from 'lib/openapi'; import { UpsertSegmentSchema } from 'lib/openapi';
import { IClientSegment, IFeatureStrategy, ISegment, IUser } from 'lib/types'; import { IClientSegment, IFeatureStrategy, ISegment, IUser } from 'lib/types';
export type UsedStrategies = { export type StrategiesUsingSegment = {
strategies: IFeatureStrategy[]; strategies: IFeatureStrategy[];
changeRequestStrategies: ChangeRequestStrategy[]; changeRequestStrategies: ChangeRequestStrategy[];
}; };
@ -24,9 +24,12 @@ export interface ISegmentService {
* This is NOT considering the private projects * This is NOT considering the private projects
* For most use cases, use `getVisibleStrategies` * For most use cases, use `getVisibleStrategies`
*/ */
getAllStrategies(id: number): Promise<UsedStrategies>; getAllStrategies(id: number): Promise<StrategiesUsingSegment>;
getVisibleStrategies(id: number, userId: number): Promise<UsedStrategies>; getVisibleStrategies(
id: number,
userId: number,
): Promise<StrategiesUsingSegment>;
validateName(name: string): Promise<void>; validateName(name: string): Promise<void>;

6
src/lib/services/segment-service.ts
View File

@ -20,7 +20,7 @@ import { IFeatureStrategiesStore } from '../features/feature-toggle/types/featur
import BadDataError from '../error/bad-data-error'; import BadDataError from '../error/bad-data-error';
import { import {
ISegmentService, ISegmentService,
UsedStrategies, StrategiesUsingSegment,
} from '../segments/segment-service-interface'; } from '../segments/segment-service-interface';
import { PermissionError } from '../error'; import { PermissionError } from '../error';
import { IChangeRequestAccessReadModel } from '../features/change-request-access-service/change-request-access-read-model'; import { IChangeRequestAccessReadModel } from '../features/change-request-access-service/change-request-access-read-model';
@ -93,7 +93,7 @@ export class SegmentService implements ISegmentService {
async getVisibleStrategies( async getVisibleStrategies(
id: number, id: number,
userId: number, userId: number,
): Promise<UsedStrategies> { ): Promise<StrategiesUsingSegment> {
const allStrategies = await this.getAllStrategies(id); const allStrategies = await this.getAllStrategies(id);
if (this.flagResolver.isEnabled('privateProjects')) { if (this.flagResolver.isEnabled('privateProjects')) {
const accessibleProjects = const accessibleProjects =
@ -115,7 +115,7 @@ export class SegmentService implements ISegmentService {
return allStrategies; return allStrategies;
} }
async getAllStrategies(id: number): Promise<UsedStrategies> { async getAllStrategies(id: number): Promise<StrategiesUsingSegment> {
const strategies = const strategies =
await this.featureStrategiesStore.getStrategiesBySegment(id); await this.featureStrategiesStore.getStrategiesBySegment(id);

6
src/test/e2e/api/admin/segment.e2e.test.ts
View File

@ -15,7 +15,7 @@ import {
IUnleashTest, IUnleashTest,
setupAppWithCustomConfig, setupAppWithCustomConfig,
} from '../../helpers/test-helper'; } from '../../helpers/test-helper';
import { UsedStrategies } from 'lib/segments/segment-service-interface'; import { StrategiesUsingSegment } from 'lib/segments/segment-service-interface';
let app: IUnleashTest; let app: IUnleashTest;
let db: ITestDb; let db: ITestDb;
@ -48,7 +48,9 @@ const fetchFeatures = (): Promise<IFeatureToggleClient[]> =>
.expect(200) .expect(200)
.then((res) => res.body.features); .then((res) => res.body.features);
const fetchSegmentStrategies = (segmentId: number): Promise<UsedStrategies> => const fetchSegmentStrategies = (
segmentId: number,
): Promise<StrategiesUsingSegment> =>
app.request app.request
.get(`${SEGMENTS_BASE_PATH}/${segmentId}/strategies`) .get(`${SEGMENTS_BASE_PATH}/${segmentId}/strategies`)
.expect(200) .expect(200)