From ee0a453cc9f5522fc88a299a6cd11e941cc30ddb Mon Sep 17 00:00:00 2001 From: Thomas Heartman Date: Wed, 7 May 2025 08:39:51 +0200 Subject: [PATCH] remove some unused things --- .../EditableConstraintWrapper.tsx | 52 +------------------ 1 file changed, 1 insertion(+), 51 deletions(-) diff --git a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/EditableConstraintWrapper.tsx b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/EditableConstraintWrapper.tsx index da3abe52e2..44f2b6a483 100644 --- a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/EditableConstraintWrapper.tsx +++ b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/EditableConstraintWrapper.tsx @@ -9,9 +9,7 @@ import { EditableConstraint } from 'component/feature/FeatureStrategy/FeatureStr interface IConstraintAccordionEditProps { constraint: IConstraint; onCancel?: () => void; - onSave: (constraint: IConstraint) => void; onDelete?: () => void; - onAutoSave?: (constraint: IConstraint) => void; } export const CANCEL = 'cancel'; @@ -38,16 +36,11 @@ const resolveContextDefinition = ( export const EditableConstraintWrapper = ({ constraint, - onSave, onDelete, - onAutoSave, }: IConstraintAccordionEditProps) => { const [localConstraint, setLocalConstraint] = useState( cleanConstraint(constraint), ); - const [constraintChanges, setConstraintChanges] = useState([ - cleanConstraint(constraint), - ]); const { context } = useUnleashContext(); const [contextDefinition, setContextDefinition] = useState( @@ -60,26 +53,6 @@ export const EditableConstraintWrapper = ({ ); }, [localConstraint.contextName, context]); - const onUndo = () => { - if (constraintChanges.length < 2) return; - const previousChange = constraintChanges[constraintChanges.length - 2]; - - setLocalConstraint(previousChange); - setConstraintChanges((prev) => prev.slice(0, prev.length - 1)); - autoSave(previousChange); - }; - - const autoSave = (localConstraint: IConstraint) => { - if (onAutoSave) { - onAutoSave(localConstraint); - } - }; - - const recordChange = (localConstraint: IConstraint) => { - setConstraintChanges((prev) => [...prev, localConstraint]); - autoSave(localConstraint); - }; - const setContextName = useCallback((contextName: string) => { setLocalConstraint((prev) => { const localConstraint = cleanConstraint({ @@ -89,8 +62,6 @@ export const EditableConstraintWrapper = ({ value: '', }); - recordChange(localConstraint); - return localConstraint; }); }, []); @@ -104,18 +75,6 @@ export const EditableConstraintWrapper = ({ value: '', }); - recordChange(localConstraint); - - return localConstraint; - }); - }, []); - - const setValuesWithRecord = useCallback((values: string[]) => { - setLocalConstraint((prev) => { - const localConstraint = { ...prev, values }; - - recordChange(localConstraint); - return localConstraint; }); }, []); @@ -132,8 +91,6 @@ export const EditableConstraintWrapper = ({ setLocalConstraint((prev) => { const localConstraint = { ...prev, value }; - recordChange(localConstraint); - return localConstraint; }); }, []); @@ -142,8 +99,6 @@ export const EditableConstraintWrapper = ({ setLocalConstraint((prev) => { const localConstraint = { ...prev, inverted: !prev.inverted }; - recordChange(localConstraint); - return localConstraint; }); }; @@ -155,8 +110,6 @@ export const EditableConstraintWrapper = ({ caseInsensitive: !prev.caseInsensitive, }; - recordChange(localConstraint); - return localConstraint; }); }, []); @@ -165,10 +118,8 @@ export const EditableConstraintWrapper = ({ (index: number) => { const valueCopy = [...localConstraint.values!]; valueCopy.splice(index, 1); - - setValuesWithRecord(valueCopy); }, - [localConstraint, setValuesWithRecord], + [localConstraint], ); return ( @@ -180,7 +131,6 @@ export const EditableConstraintWrapper = ({ toggleInvertedOperator={setInvertedOperator} toggleCaseSensitivity={setCaseInsensitive} onDelete={onDelete} - onUndo={onUndo} constraintChanges={constraintChanges} setValues={setValues} setValuesWithRecord={setValuesWithRecord}