diff --git a/scripts/check-release.js b/scripts/check-release.js index ad6fdcd7a6..8690962268 100644 --- a/scripts/check-release.js +++ b/scripts/check-release.js @@ -1,5 +1,5 @@ const semver = require('semver'); -//@ts-ignore +// @ts-expect-error const pck = require('../package.json'); const newUnleashVersion = process.argv[2]; diff --git a/src/lib/db/event-store.ts b/src/lib/db/event-store.ts index 6bd13fde56..6bf9e2ef76 100644 --- a/src/lib/db/event-store.ts +++ b/src/lib/db/event-store.ts @@ -185,7 +185,7 @@ class EventStore extends EventEmitter implements IEventStore { created_by: e.createdBy, data: e.data, pre_data: e.preData, - //@ts-ignore workaround for json-array + // @ts-expect-error workaround for json-array tags: JSON.stringify(e.tags), feature_name: e.featureName, project: e.project, diff --git a/src/lib/db/feature-strategy-store.ts b/src/lib/db/feature-strategy-store.ts index 20f8af41ab..b230aac436 100644 --- a/src/lib/db/feature-strategy-store.ts +++ b/src/lib/db/feature-strategy-store.ts @@ -292,7 +292,7 @@ class FeatureStrategiesStore implements IFeatureStrategiesStore { featureToggle.environments = Object.values( featureToggle.environments, ).sort((a, b) => { - // @ts-ignore + // @ts-expect-error return a.sortOrder - b.sortOrder; }); featureToggle.environments = featureToggle.environments.map((e) => { diff --git a/src/lib/db/project-store.ts b/src/lib/db/project-store.ts index 79ca27f2ae..c37121221d 100644 --- a/src/lib/db/project-store.ts +++ b/src/lib/db/project-store.ts @@ -84,7 +84,6 @@ class ProjectStore implements IProjectStore { } const projectAndFeatureCount = await projects; - // @ts-ignore const projectsWithFeatureCount = projectAndFeatureCount.map( this.mapProjectWithCountRow, ); diff --git a/src/lib/metrics.ts b/src/lib/metrics.ts index 28889592c1..72d0a790e6 100644 --- a/src/lib/metrics.ts +++ b/src/lib/metrics.ts @@ -149,11 +149,11 @@ export default class MetricsMonitor { for (const entry of Object.entries(m.bucket.toggles)) { featureToggleUsageTotal .labels(entry[0], 'true', m.appName) - // @ts-ignore + // @ts-expect-error .inc(entry[1].yes); featureToggleUsageTotal .labels(entry[0], 'false', m.appName) - // @ts-ignore + // @ts-expect-error .inc(entry[1].no); } }); diff --git a/src/lib/middleware/demo-authentication.ts b/src/lib/middleware/demo-authentication.ts index 160d676f28..2151fcd549 100644 --- a/src/lib/middleware/demo-authentication.ts +++ b/src/lib/middleware/demo-authentication.ts @@ -18,7 +18,7 @@ function demoAuthentication( email, true, ); - //@ts-ignore + // @ts-expect-error req.session.user = user; return res.status(200).json(user); } catch (e) { @@ -29,18 +29,18 @@ function demoAuthentication( }); app.use(`${basePath}/api/admin/`, (req, res, next) => { - // @ts-ignore + // @ts-expect-error if (req.session.user && req.session.user.email) { - // @ts-ignore + // @ts-expect-error req.user = req.session.user; } next(); }); app.use(`${basePath}/api/client`, (req, res, next) => { - // @ts-ignore + // @ts-expect-error if (!authentication.enableApiToken && !req.user) { - // @ts-ignore + // @ts-expect-error req.user = new ApiUser({ username: 'unauthed-default-client', permissions: [], @@ -53,7 +53,7 @@ function demoAuthentication( }); app.use(`${basePath}/api`, (req, res, next) => { - // @ts-ignore + // @ts-expect-error if (req.user) { return next(); } diff --git a/src/lib/middleware/no-authentication.ts b/src/lib/middleware/no-authentication.ts index eb2a6c19e1..b6eefde151 100644 --- a/src/lib/middleware/no-authentication.ts +++ b/src/lib/middleware/no-authentication.ts @@ -4,7 +4,7 @@ import NoAuthUser from '../types/no-auth-user'; // eslint-disable-next-line function noneAuthentication(basePath = '', app: Application): void { app.use(`${basePath}/api/admin/`, (req, res, next) => { - // @ts-ignore + // @ts-expect-error if (!req.user) { // @ts-expect-error req.user = new NoAuthUser(); diff --git a/src/lib/middleware/session-db.ts b/src/lib/middleware/session-db.ts index 91eb6aca54..1b9eabe36d 100644 --- a/src/lib/middleware/session-db.ts +++ b/src/lib/middleware/session-db.ts @@ -18,7 +18,7 @@ function sessionDb( store = new KnexSessionStore({ tablename: 'unleash_session', createtable: false, - // @ts-ignore + // @ts-expect-error knex, }); } else { diff --git a/src/lib/routes/admin-api/state.ts b/src/lib/routes/admin-api/state.ts index a36148b139..27dcd804f4 100644 --- a/src/lib/routes/admin-api/state.ts +++ b/src/lib/routes/admin-api/state.ts @@ -45,14 +45,14 @@ class StateController extends Controller { const { drop, keep } = req.query; // TODO: Should override request type so file is a type on request let data; - // @ts-ignore + // @ts-expect-error if (req.file) { - // @ts-ignore + // @ts-expect-error if (mime.getType(req.file.originalname) === 'text/yaml') { - // @ts-ignore + // @ts-expect-error data = YAML.load(req.file.buffer); } else { - // @ts-ignore + // @ts-expect-error data = JSON.parse(req.file.buffer); } } else { diff --git a/src/lib/routes/client-api/feature.ts b/src/lib/routes/client-api/feature.ts index 10bdd945cf..9c310d98dc 100644 --- a/src/lib/routes/client-api/feature.ts +++ b/src/lib/routes/client-api/feature.ts @@ -57,13 +57,12 @@ export default class FeatureController extends Controller { this.get('/:featureName', this.getFeatureToggle); if (experimental && experimental.clientFeatureMemoize) { - // @ts-ignore this.cache = experimental.clientFeatureMemoize.enabled; this.cachedFeatures = memoizee( (query) => this.resolveFeaturesAndSegments(query), { promise: true, - // @ts-ignore + // @ts-expect-error maxAge: experimental.clientFeatureMemoize.maxAge, normalizer(args) { // args is arguments object as accessible in memoized function diff --git a/src/lib/routes/util.ts b/src/lib/routes/util.ts index 0b994fa5fa..b37db9b1d4 100644 --- a/src/lib/routes/util.ts +++ b/src/lib/routes/util.ts @@ -27,7 +27,7 @@ export const handleErrors: ( error: Error, ) => void = (res, logger, error) => { logger.warn(error.message); - // @ts-ignore + // @ts-expect-error // eslint-disable-next-line no-param-reassign error.isJoi = true; diff --git a/src/lib/services/feature-toggle-service.ts b/src/lib/services/feature-toggle-service.ts index 68d5e079b4..eb0f023646 100644 --- a/src/lib/services/feature-toggle-service.ts +++ b/src/lib/services/feature-toggle-service.ts @@ -630,7 +630,6 @@ class FeatureToggleService { newToggle.environments.forEach((e: IEnvironmentDetail) => e.strategies.forEach((s: IStrategyConfig) => { if (replaceGroupId && s.parameters.hasOwnProperty('groupId')) { - //@ts-ignore s.parameters.groupId = newFeatureName; } delete s.id; diff --git a/src/test/e2e/helpers/database-init.ts b/src/test/e2e/helpers/database-init.ts index 4122c2ba5b..2947ff8869 100644 --- a/src/test/e2e/helpers/database-init.ts +++ b/src/test/e2e/helpers/database-init.ts @@ -97,7 +97,7 @@ export default async function init( await db.raw(`DROP SCHEMA IF EXISTS ${config.db.schema} CASCADE`); await db.raw(`CREATE SCHEMA IF NOT EXISTS ${config.db.schema}`); - // @ts-ignore + // @ts-expect-error await migrateDb({ ...config, databaseSchema: config.db.schema }); await db.destroy(); const testDb = createDb(config); diff --git a/src/test/fixtures/fake-client-applications-store.ts b/src/test/fixtures/fake-client-applications-store.ts index b6b6907d7e..f3bfd43142 100644 --- a/src/test/fixtures/fake-client-applications-store.ts +++ b/src/test/fixtures/fake-client-applications-store.ts @@ -11,7 +11,7 @@ export default class FakeClientApplicationsStore apps: IClientApplication[] = []; async bulkUpsert(details: Partial[]): Promise { - // @ts-ignore + // @ts-expect-error details.forEach((d) => this.apps.push(d)); } diff --git a/src/test/fixtures/fake-user-store.ts b/src/test/fixtures/fake-user-store.ts index 3a0a96dc86..554f5e8d59 100644 --- a/src/test/fixtures/fake-user-store.ts +++ b/src/test/fixtures/fake-user-store.ts @@ -82,14 +82,14 @@ class UserStoreMock implements IUserStore { async setPasswordHash(userId: number, passwordHash: string): Promise { const u = this.data.find((a) => a.id === userId); - // @ts-ignore + // @ts-expect-error u.passwordHash = passwordHash; return Promise.resolve(); } async getPasswordHash(id: number): Promise { const u = this.data.find((i) => i.id === id); - // @ts-ignore + // @ts-expect-error return Promise.resolve(u.passwordHash); }