chore!: remove deprecated put project groups roles endpoint (#10059)

https://linear.app/unleash/issue/2-3361/remove-put-apiadminprojectsprojectidgroupsgroupidrolesroleid

Removes PUT
`/api/admin/projects/{projectId}/groups/{groupId}/roles/{roleId}` which
was deprecated in v5.5.
Also cleans up related code.

src/lib/db/access-store.ts

@@ -571,23 +571,6 @@ export class AccessStore implements IAccessStore {
             .update('role_id', roleId);
     }
 
-    updateGroupProjectRole(
-        groupId: number,
-        roleId: number,
-        projectId: string,
-    ): Promise<void> {
-        return this.db(T.GROUP_ROLE)
-            .where({
-                group_id: groupId,
-                project: projectId,
-            })
-            .whereNotIn(
-                'role_id',
-                this.db(T.ROLES).select('id as role_id').where('type', 'root'),
-            )
-            .update('role_id', roleId);
-    }
-
     async addAccessToProject(
         roles: number[],
         groups: number[],

src/lib/events/index.ts

@@ -79,7 +79,6 @@ export const PROJECT_USER_ADDED = 'project-user-added' as const;
 export const PROJECT_USER_REMOVED = 'project-user-removed' as const;
 export const PROJECT_USER_ROLE_CHANGED = 'project-user-role-changed' as const;
 export const PROJECT_GROUP_ADDED = 'project-group-added' as const;
-export const PROJECT_GROUP_ROLE_CHANGED = 'project-group-role-changed' as const;
 export const DROP_PROJECTS = 'drop-projects' as const;
 export const TAG_CREATED = 'tag-created' as const;
 export const TAG_DELETED = 'tag-deleted' as const;
@@ -270,7 +269,6 @@ export const IEventTypes = [
     PROJECT_USER_ADDED,
     PROJECT_USER_REMOVED,
     PROJECT_USER_ROLE_CHANGED,
-    PROJECT_GROUP_ROLE_CHANGED,
     PROJECT_GROUP_ADDED,
     ROLE_CREATED,
     ROLE_UPDATED,

src/lib/features/project/project-service.ts

@@ -45,7 +45,6 @@ import {
     ProjectCreatedEvent,
     ProjectDeletedEvent,
     ProjectGroupAddedEvent,
-    ProjectGroupUpdateRoleEvent,
     ProjectRevivedEvent,
     ProjectUpdatedEvent,
     ProjectUserRemovedEvent,
@@ -63,7 +62,6 @@ import type { FeatureToggleService } from '../feature-toggle/feature-toggle-serv
 import IncompatibleProjectError from '../../error/incompatible-project-error.js';
 import { arraysHaveSameItems } from '../../util/index.js';
 import type { GroupService } from '../../services/group-service.js';
-import type { IGroupRole } from '../../types/group.js';
 import type { FavoritesService } from '../../services/favorites-service.js';
 import { calculateAverageTimeToProd } from '../feature-toggle/time-to-production/time-to-production.js';
 import type { IProjectStatsStore } from '../../types/stores/project-stats-store-type.js';
@@ -111,17 +109,6 @@ interface ICalculateStatus {
     updates: IProjectStats;
 }
 
-function includes(
-    list: number[],
-    {
-        id,
-    }: {
-        id: number;
-    },
-): boolean {
-    return list.some((l) => l === id);
-}
-
 export default class ProjectService {
     private projectStore: IProjectStore;
 
@@ -993,20 +980,6 @@ export default class ProjectService {
         }
     }
 
-    async findProjectGroupRole(
-        projectId: string,
-        roleId: number,
-    ): Promise<IGroupRole> {
-        const roles = await this.groupService.getRolesForProject(projectId);
-        const role = roles.find((r) => r.roleId === roleId);
-        if (!role) {
-            throw new NotFoundError(
-                `Couldn't find roleId=${roleId} on project=${projectId}`,
-            );
-        }
-        return role;
-    }
-
     async findProjectRole(
         projectId: string,
         roleId: number,
@@ -1122,56 +1095,6 @@ export default class ProjectService {
         );
     }
 
-    async changeGroupRole(
-        projectId: string,
-        roleId: number,
-        userId: number,
-        auditUser: IAuditUser,
-    ): Promise<void> {
-        const usersWithRoles = await this.getAccessToProject(projectId);
-        const userGroup = usersWithRoles.groups.find((u) => u.id === userId);
-        if (!userGroup)
-            throw new ValidationError('Unexpected empty user', [], undefined);
-        const currentRole = usersWithRoles.roles.find((r) =>
-            userGroup.roles?.includes(r.id),
-        );
-        if (!currentRole)
-            throw new ValidationError(
-                'Unexpected empty current role',
-                [],
-                undefined,
-            );
-
-        if (currentRole.id === roleId) {
-            // Nothing to do....
-            return;
-        }
-
-        await this.accessService.updateGroupProjectRole(
-            userId,
-            roleId,
-            projectId,
-        );
-        const role = await this.findProjectGroupRole(projectId, roleId);
-
-        await this.eventService.storeEvent(
-            new ProjectGroupUpdateRoleEvent({
-                project: projectId,
-                auditUser,
-                preData: {
-                    userId,
-                    roleId: currentRole.id,
-                    roleName: currentRole.name,
-                },
-                data: {
-                    userId,
-                    roleId,
-                    roleName: role.name,
-                },
-            }),
-        );
-    }
-
     async getMembers(projectId: string): Promise<number> {
         return this.projectStore.getMembersCountByProject(projectId);
     }

src/lib/services/access-service.ts

@@ -463,14 +463,6 @@ export class AccessService {
         return this.store.updateUserProjectRole(userId, roleId, projectId);
     }
 
-    async updateGroupProjectRole(
-        userId: number,
-        roleId: number,
-        projectId: string,
-    ): Promise<void> {
-        return this.store.updateGroupProjectRole(userId, roleId, projectId);
-    }
-
     //This actually only exists for testing purposes
     async addPermissionToRole(
         roleId: number,

src/lib/types/events.ts

@@ -77,7 +77,6 @@ import {
     PROJECT_ENVIRONMENT_REMOVED,
     PROJECT_FAVORITED,
     PROJECT_GROUP_ADDED,
-    PROJECT_GROUP_ROLE_CHANGED,
     PROJECT_IMPORT,
     PROJECT_REVIVED,
     PROJECT_UNFAVORITED,
@@ -1037,29 +1036,6 @@ export class ProjectGroupAddedEvent extends BaseEvent {
     }
 }
 
-export class ProjectGroupUpdateRoleEvent extends BaseEvent {
-    readonly project: string;
-
-    readonly data: any;
-
-    readonly preData: any;
-
-    /**
-     */
-    constructor(eventData: {
-        project: string;
-        data: any;
-        preData: any;
-        auditUser: IAuditUser;
-    }) {
-        super(PROJECT_GROUP_ROLE_CHANGED, eventData.auditUser);
-        const { project, data, preData } = eventData;
-        this.project = project;
-        this.data = data;
-        this.preData = preData;
-    }
-}
-
 export class ProjectAccessAddedEvent extends BaseEvent {
     readonly project: string;
 

src/lib/types/stores/access-store.ts

@@ -137,12 +137,6 @@ export interface IAccessStore extends Store<IRole, number> {
         projectId: string,
     ): Promise<void>;
 
-    updateGroupProjectRole(
-        userId: number,
-        roleId: number,
-        projectId: string,
-    ): Promise<void>;
-
     removeRolesOfTypeForUser(
         userId: number,
         roleTypes: string[],

src/test/fixtures/fake-access-store.ts

@@ -52,14 +52,6 @@ export class FakeAccessStore implements IAccessStore {
         throw new Error('Method not implemented.');
     }
 
-    updateGroupProjectRole(
-        userId: number,
-        roleId: number,
-        projectId: string,
-    ): Promise<void> {
-        throw new Error('Method not implemented.');
-    }
-
     addGroupToRole(
         groupId: number,
         roleId: number,