Merge pull request #223 from Unleash/pass-along-hooks

pass along hooks, add test to server impl

.eslintrc

@@ -3,6 +3,9 @@
         "finn",
         "finn/node"
     ],
+    "parserOptions": {
+        "ecmaVersion": "2017"
+    },
     "rules": {
         "max-nested-callbacks": "off"
     }

lib/server-impl.js

@@ -15,15 +15,10 @@ function createApp (options) {
     const stores = createStores(options);
     const eventBus = new EventEmitter();
 
-    const config = {
+    const config = Object.assign({
-        baseUriPath: options.baseUriPath,
-        serverMetrics: options.serverMetrics,
-        enableRequestLogger: options.enableRequestLogger,
-        port: options.port,
-        publicFolder: options.publicFolder,
         stores,
         eventBus,
-    };
+    }, options);
 
     const app = getApp(config);
     const server = app.listen(app.get('port'), () => {

lib/server-impl.test.js

@@ -0,0 +1,51 @@
+'use strict';
+
+const test = require('ava');
+const proxyquire = require('proxyquire');
+
+const getApp = proxyquire('./app', {
+    './routes': {
+        createAPI: () => {},
+        createLegacy: () => {},
+    },
+});
+
+const serverImpl = proxyquire('./server-impl', {
+    './app': getApp,
+    './metrics': {
+        startMonitoring (o) {
+            return o;
+        },
+    },
+    './db': {
+        createStores (o) {
+            return o;
+        },
+    },
+    './options': {
+        createOptions (o) {
+            return o;
+        },
+    },
+    '../migrator' () {
+        return Promise.resolve();
+    },
+});
+
+test('should call preHook', async t => {
+    let called = 0;
+    await serverImpl.start({
+        preHook: () => {
+            called++;
+        },
+    });
+    t.true(called === 1);
+});
+
+test('should call preRouterHook', async t => {
+    let called = 0;
+    await serverImpl.start({ preRouterHook: () => {
+        called++;
+    } });
+    t.true(called === 1);
+});