Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-03-09 00:18:26 +01:00
Code Issues Projects Releases Wiki Activity

fix: trim sso URL fields (#7301) (#7303)

Browse Source 
What the title says. There are input values that are whitespace
sensitive, so this will trim clientId and entity field, preventing the
form from sending leading or trailing whitespace. Will make a PR on
enterprise as well to trim on the backend as well.
This commit is contained in:
Christopher Kolstad 2024-06-06 11:29:53 +02:00 committed by GitHub
parent e23c28a8f6
commit f245e55391
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
frontend/src/component/admin/auth/OidcAuth/OidcAuth.tsx
View File

@ -59,6 +59,10 @@ export const OidcAuth = () => {
setValue(event.target.name, event.target.value); setValue(event.target.name, event.target.value);
}; };
const trimAndUpdateField = (event: React.ChangeEvent<HTMLInputElement>) => {
setValue(event.target.name, event.target.value.trim());
};
const updateEnabled = () => { const updateEnabled = () => {
setData({ ...data, enabled: !data.enabled }); setData({ ...data, enabled: !data.enabled });
}; };
@ -146,7 +150,7 @@ export const OidcAuth = () => {
</Grid> </Grid>
<Grid item md={6}> <Grid item md={6}>
<TextField <TextField
onChange={updateField} onChange={trimAndUpdateField}
label='Discover URL' label='Discover URL'
name='discoverUrl' name='discoverUrl'
value={data.discoverUrl} value={data.discoverUrl}
@ -164,7 +168,7 @@ export const OidcAuth = () => {
</Grid> </Grid>
<Grid item md={6}> <Grid item md={6}>
<TextField <TextField
onChange={updateField} onChange={trimAndUpdateField}
label='Client ID' label='Client ID'
name='clientId' name='clientId'
value={data.clientId} value={data.clientId}
@ -185,7 +189,7 @@ export const OidcAuth = () => {
</Grid> </Grid>
<Grid item md={6}> <Grid item md={6}>
<TextField <TextField
onChange={updateField} onChange={trimAndUpdateField}
label='Client Secret' label='Client Secret'
name='secret' name='secret'
value={data.secret} value={data.secret}

10
frontend/src/component/admin/auth/SamlAuth/SamlAuth.tsx
View File

@ -54,6 +54,10 @@ export const SamlAuth = () => {
setValue(event.target.name, event.target.value); setValue(event.target.name, event.target.value);
}; };
const trimAndUpdateField = (event: React.ChangeEvent<HTMLInputElement>) => {
setValue(event.target.name, event.target.value.trim());
};
const updateEnabled = () => { const updateEnabled = () => {
setData({ ...data, enabled: !data.enabled }); setData({ ...data, enabled: !data.enabled });
}; };
@ -137,7 +141,7 @@ export const SamlAuth = () => {
</Grid> </Grid>
<Grid item md={6}> <Grid item md={6}>
<TextField <TextField
onChange={updateField} onChange={trimAndUpdateField}
label='Entity ID' label='Entity ID'
name='entityId' name='entityId'
value={data.entityId} value={data.entityId}
@ -159,7 +163,7 @@ export const SamlAuth = () => {
</Grid> </Grid>
<Grid item md={6}> <Grid item md={6}>
<TextField <TextField
onChange={updateField} onChange={trimAndUpdateField}
label='Single Sign-On URL' label='Single Sign-On URL'
name='signOnUrl' name='signOnUrl'
value={data.signOnUrl} value={data.signOnUrl}
@ -213,7 +217,7 @@ export const SamlAuth = () => {
</Grid> </Grid>
<Grid item md={6}> <Grid item md={6}>
<TextField <TextField
onChange={updateField} onChange={trimAndUpdateField}
label='Single Sign-out URL' label='Single Sign-out URL'
name='signOutUrl' name='signOutUrl'
value={data.signOutUrl} value={data.signOutUrl}