From f29ecaf3c067a8e282cf6c1f5cc65142f9ce0014 Mon Sep 17 00:00:00 2001 From: David Leek Date: Thu, 4 Apr 2024 11:48:51 +0200 Subject: [PATCH] fix: strategy targeting numeric also check value field (#6774) API returns both value and values fields. Empty values array causes ui to think constraint doesnt have a value This PR checks if value field exists and is empty before returning check on values and length --- .../FeatureStrategyConstraints.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/FeatureStrategyConstraints.tsx b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/FeatureStrategyConstraints.tsx index 95e5d47191..9b06a315ad 100644 --- a/frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/FeatureStrategyConstraints.tsx +++ b/frontend/src/component/feature/FeatureStrategy/FeatureStrategyConstraints/FeatureStrategyConstraints.tsx @@ -18,7 +18,10 @@ interface IFeatureStrategyConstraintsProps { } const filterConstraints = (constraint: any) => { - if (constraint.hasOwnProperty('values')) { + if ( + constraint.hasOwnProperty('values') && + (!constraint.hasOwnProperty('value') || constraint.value === '') + ) { return constraint.values && constraint.values.length > 0; }