1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-02-09 00:18:00 +01:00

fix: segment delete confirmation double dialog flash (#2819)

This commit is contained in:
Tymoteusz Czech 2023-01-04 15:58:30 +01:00 committed by GitHub
parent 4005bb8a8b
commit f2eb96000e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -1,7 +1,7 @@
import React from 'react';
import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender'; import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
import { useStrategiesBySegment } from 'hooks/api/getters/useStrategiesBySegment/useStrategiesBySegment'; import { useStrategiesBySegment } from 'hooks/api/getters/useStrategiesBySegment/useStrategiesBySegment';
import { ISegment } from 'interfaces/segment'; import { ISegment } from 'interfaces/segment';
import React from 'react';
import { SegmentDeleteConfirm } from './SegmentDeleteConfirm/SegmentDeleteConfirm'; import { SegmentDeleteConfirm } from './SegmentDeleteConfirm/SegmentDeleteConfirm';
import { SegmentDeleteUsedSegment } from './SegmentDeleteUsedSegment/SegmentDeleteUsedSegment'; import { SegmentDeleteUsedSegment } from './SegmentDeleteUsedSegment/SegmentDeleteUsedSegment';
@ -11,14 +11,20 @@ interface ISegmentDeleteProps {
onClose: () => void; onClose: () => void;
onRemove: () => void; onRemove: () => void;
} }
export const SegmentDelete = ({ export const SegmentDelete = ({
segment, segment,
open, open,
onClose, onClose,
onRemove, onRemove,
}: ISegmentDeleteProps) => { }: ISegmentDeleteProps) => {
const { strategies } = useStrategiesBySegment(segment.id); const { strategies, loading } = useStrategiesBySegment(segment.id);
const canDeleteSegment = strategies?.length === 0; const canDeleteSegment = strategies?.length === 0;
if (loading) {
return null;
}
return ( return (
<ConditionallyRender <ConditionallyRender
condition={canDeleteSegment} condition={canDeleteSegment}