From f6169540a5fefd308df39af48afebeb008dd23f3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ivar=20Conradi=20=C3=98sthus?= Date: Wed, 29 Sep 2021 09:47:49 +0200 Subject: [PATCH] fix: Store metrics only if not empty (#991) --- src/lib/services/client-metrics/index.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/lib/services/client-metrics/index.ts b/src/lib/services/client-metrics/index.ts index 493eaaf4fa..7fa99422e7 100644 --- a/src/lib/services/client-metrics/index.ts +++ b/src/lib/services/client-metrics/index.ts @@ -140,8 +140,12 @@ export default class ClientMetricsService { ): Promise { const value = await clientMetricsSchema.validateAsync(data); const toggleNames = Object.keys(value.bucket.toggles); - await this.featureToggleStore.setLastSeen(toggleNames); - await this.clientMetricsStore.insert(value); + + if (toggleNames.length > 0) { + await this.featureToggleStore.setLastSeen(toggleNames); + await this.clientMetricsStore.insert(value); + } + await this.clientInstanceStore.insert({ appName: value.appName, instanceId: value.instanceId,