Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-08-04 13:48:56 +02:00
Code Issues Projects Releases Wiki Activity

feat: enforce change request settings in create project dialog (#9637)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2025-03-27 16:15:09 +01:00 committed by GitHub
parent e53e2ca0c7
commit f97924eb36
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
frontend/src/component/project/Project/CreateProject/NewCreateProjectForm/ConfigButtons/ChangeRequestTable.tsx
View File

@ -37,8 +37,9 @@ type TableProps = {
environments: { environments: {
name: string; name: string;
type: string; type: string;
requiredApprovals: number;
changeRequestEnabled: boolean; changeRequestEnabled: boolean;
requiredApprovals: number;
configurable: boolean;
}[]; }[];
enableEnvironment: (name: string, requiredApprovals: number) => void; enableEnvironment: (name: string, requiredApprovals: number) => void;
disableEnvironment: (name: string) => void; disableEnvironment: (name: string) => void;
@ -111,6 +112,7 @@ export const ChangeRequestTable = (props: TableProps) => {
approvals, approvals,
); );
}} }}
disabled={!original.configurable}
IconComponent={ IconComponent={
KeyboardArrowDownOutlined KeyboardArrowDownOutlined
} }
@ -143,6 +145,7 @@ export const ChangeRequestTable = (props: TableProps) => {
original.environment original.environment
}`, }`,
}} }}
disabled={!original.configurable}
onClick={onToggleEnvironment( onClick={onToggleEnvironment(
original.environment, original.environment,
original.changeRequestEnabled, original.changeRequestEnabled,
@ -171,6 +174,7 @@ export const ChangeRequestTable = (props: TableProps) => {
type: env.type, type: env.type,
changeRequestEnabled: env.changeRequestEnabled, changeRequestEnabled: env.changeRequestEnabled,
requiredApprovals: env.requiredApprovals ?? 1, requiredApprovals: env.requiredApprovals ?? 1,
configurable: env.configurable,
}; };
}), }),

4
frontend/src/component/project/Project/CreateProject/NewCreateProjectForm/ConfigButtons/ChangeRequestTableConfigButton.tsx
View File

@ -26,6 +26,7 @@ type ChangeRequestTableConfigButtonProps = Pick<
activeEnvironments: { activeEnvironments: {
name: string; name: string;
type: string; type: string;
configurable: boolean;
}[]; }[];
projectChangeRequestConfiguration: Record< projectChangeRequestConfiguration: Record<
string, string,
@ -56,9 +57,10 @@ export const ChangeRequestTableConfigButton: FC<
const tableEnvs = useMemo( const tableEnvs = useMemo(
() => () =>
activeEnvironments.map(({ name, type }) => ({ activeEnvironments.map(({ name, type, configurable }) => ({
name, name,
type, type,
configurable,
...(configured[name] ?? { changeRequestEnabled: false }), ...(configured[name] ?? { changeRequestEnabled: false }),
})), })),
[configured, activeEnvironments], [configured, activeEnvironments],

3
frontend/src/component/project/Project/CreateProject/NewCreateProjectForm/CreateProjectDialog.tsx
View File

@ -234,6 +234,9 @@ export const CreateProjectDialog = ({
name, name,
type, type,
requiredApprovals, requiredApprovals,
configurable: globalChangeRequestConfigEnabled
? !Number.isInteger(requiredApprovals)
: true,
})); }));
useEffect(() => { useEffect(() => {