Mirrors/unleash.unleash
1
0
Fork 0
mirror of https://github.com/Unleash/unleash.git synced 2025-05-08 01:15:49 +02:00
Code Issues Projects Releases Wiki Activity

refactor: error param prop (#4247)

Browse Source
This commit is contained in:
Mateusz Kwasniewski 2023-07-17 11:02:54 +02:00 committed by GitHub
parent 11f77a21de
commit fb6e4906a7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
frontend/src/component/feature/FeatureView/FeatureVariants/FeatureEnvironmentVariants/EnvironmentVariantsModal/EnvironmentVariantsModal.tsx
View File

@ -390,7 +390,7 @@ export const EnvironmentVariantsModal = ({
) )
) )
} }
apiPayload={apiPayload} error={apiPayload.error}
/> />
))} ))}
</StyledVariantForms> </StyledVariantForms>

14
frontend/src/component/feature/FeatureView/FeatureVariants/FeatureEnvironmentVariants/EnvironmentVariantsModal/VariantForm/VariantForm.tsx
View File

@ -18,7 +18,6 @@ import { useOverrides } from 'component/feature/FeatureView/FeatureVariants/Feat
import useUnleashContext from 'hooks/api/getters/useUnleashContext/useUnleashContext'; import useUnleashContext from 'hooks/api/getters/useUnleashContext/useUnleashContext';
import { WeightType } from 'constants/variantTypes'; import { WeightType } from 'constants/variantTypes';
import { IFeatureVariantEdit } from '../EnvironmentVariantsModal'; import { IFeatureVariantEdit } from '../EnvironmentVariantsModal';
import { Operation } from 'fast-json-patch';
import { Delete } from '@mui/icons-material'; import { Delete } from '@mui/icons-material';
const StyledVariantForm = styled('div')(({ theme }) => ({ const StyledVariantForm = styled('div')(({ theme }) => ({
@ -150,10 +149,7 @@ interface IVariantFormProps {
variants: IFeatureVariantEdit[]; variants: IFeatureVariantEdit[];
updateVariant: (updatedVariant: IFeatureVariantEdit) => void; updateVariant: (updatedVariant: IFeatureVariantEdit) => void;
removeVariant: (variantId: string) => void; removeVariant: (variantId: string) => void;
apiPayload: { error?: string;
patch: Operation[];
error?: string;
};
} }
export const VariantForm = ({ export const VariantForm = ({
@ -161,7 +157,7 @@ export const VariantForm = ({
variants, variants,
updateVariant, updateVariant,
removeVariant, removeVariant,
apiPayload, error,
}: IVariantFormProps) => { }: IVariantFormProps) => {
const [name, setName] = useState(variant.name); const [name, setName] = useState(variant.name);
const [customPercentage, setCustomPercentage] = useState( const [customPercentage, setCustomPercentage] = useState(
@ -188,10 +184,10 @@ export const VariantForm = ({
useEffect(() => { useEffect(() => {
clearError(ErrorField.PERCENTAGE); clearError(ErrorField.PERCENTAGE);
if (apiPayload.error?.includes('%')) { if (error?.includes('%')) {
setError(ErrorField.PERCENTAGE, 'Total weight must equal 100%'); setError(ErrorField.PERCENTAGE, 'Total weight must equal 100%');
} }
}, [apiPayload.error]); }, [error]);
const editing = !variant.new; const editing = !variant.new;
const customPercentageVisible = const customPercentageVisible =
@ -292,7 +288,7 @@ export const VariantForm = ({
isNameUnique(name, variant.id) && isNameUnique(name, variant.id) &&
isValidPercentage(percentage) && isValidPercentage(percentage) &&
isValidPayload(payload) && isValidPayload(payload) &&
!apiPayload.error, !error,
}); });
}, [name, customPercentage, percentage, payload, overrides]); }, [name, customPercentage, percentage, payload, overrides]);

1
frontend/src/component/feature/StrategyTypes/StrategyVariants.tsx
View File

@ -107,7 +107,6 @@ export const StrategyVariants: FC<{
) )
) )
} }
apiPayload={{ patch: [] }}
/> />
))} ))}
</StyledVariantForms> </StyledVariantForms>