fix: Remove strictSchemaValidation feature flag

src/lib/features/client-feature-toggles/tests/client-feature-toggles.e2e.test.ts

@@ -155,7 +155,6 @@ beforeAll(async () => {
         {
             experimental: {
                 flags: {
-                    strictSchemaValidation: true,
                     deltaApi: true,
                 },
             },
@@ -168,9 +167,7 @@ beforeAll(async () => {
         enterpriseDb.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
             ui: {
                 environment: 'Enterprise',
@@ -184,9 +181,7 @@ beforeAll(async () => {
         proDb.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
             ui: {
                 environment: 'Pro',

src/lib/features/dependent-features/dependent.features.e2e.test.ts

@@ -27,7 +27,6 @@ beforeAll(async () => {
         {
             experimental: {
                 flags: {
-                    strictSchemaValidation: true,
                     enableLegacyVariants: true,
                 },
             },

src/lib/features/environments/environment-oss.e2e.test.ts

@@ -18,9 +18,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
             isOss: true,
         },

src/lib/features/environments/environment.test.ts

@@ -17,9 +17,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/lib/features/feature-search/feature.search.e2e.test.ts

@@ -27,7 +27,6 @@ beforeAll(async () => {
         {
             experimental: {
                 flags: {
-                    strictSchemaValidation: true,
                     anonymiseEventLog: true,
                 },
             },

src/lib/features/feature-toggle/tests/archive-feature-toggles.e2e.test.ts

@@ -16,9 +16,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/lib/features/feature-toggle/tests/feature-toggle-last-seen-at.e2e.test.ts

@@ -22,9 +22,7 @@ const setupLastSeenAtTest = async (featureName: string) => {
 beforeAll(async () => {
     const config: Partial<IUnleashOptions> = {
         experimental: {
-            flags: {
+            flags: {},
-                strictSchemaValidation: true,
-            },
         },
     };
 

src/lib/features/feature-toggle/tests/feature-toggles.auth.e2e.test.ts

@@ -23,7 +23,6 @@ beforeAll(async () => {
         {
             experimental: {
                 flags: {
-                    strictSchemaValidation: true,
                     anonymiseEventLog: true,
                 },
             },

src/lib/features/feature-toggle/tests/feature-toggles.e2e.test.ts

@@ -93,7 +93,6 @@ beforeAll(async () => {
         {
             experimental: {
                 flags: {
-                    strictSchemaValidation: true,
                     featureCollaborators: true,
                 },
             },
@@ -3329,7 +3328,6 @@ test('Updating feature strategy sort-order should return strategies in correct o
         {
             experimental: {
                 flags: {
-                    strictSchemaValidation: true,
                     strategyVariant: true,
                 },
             },
@@ -3396,7 +3394,6 @@ test('Updating feature strategy sort-order should trigger a an event', async ()
         {
             experimental: {
                 flags: {
-                    strictSchemaValidation: false,
                     strategyVariant: true,
                 },
             },

src/lib/features/metrics/client-metrics/client-metrics.e2e.test.ts

@@ -30,7 +30,6 @@ beforeAll(async () => {
         {
             experimental: {
                 flags: {
-                    strictSchemaValidation: true,
                     extendedUsageMetrics: true,
                 },
             },

src/lib/features/metrics/last-seen/tests/last-seen-service.e2e.test.ts

@@ -18,9 +18,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/lib/features/onboarding/onboarding-read-model.test.ts

@@ -34,9 +34,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/lib/features/playground/advanced-playground.test.ts

@@ -20,7 +20,6 @@ beforeAll(async () => {
             experimental: {
                 flags: {
                     advancedPlayground: true,
-                    strictSchemaValidation: true,
                     strategyVariant: true,
                 },
             },

src/lib/features/playground/playground.test.ts

@@ -21,7 +21,7 @@ async function getSetup() {
     const stores = createStores();
     const config = createTestConfig({
         server: { baseUriPath: base },
-        experimental: { flags: { strictSchemaValidation: true } },
+        experimental: { flags: {} },
     });
     const services = createServices(stores, config);
     const app = await getApp(config, stores, services);

src/lib/features/project-environments/project-environments.e2e.test.ts

@@ -17,9 +17,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/lib/features/project-insights/projects-insights.e2e.test.ts

@@ -16,9 +16,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/lib/features/project-status/projects-status.e2e.test.ts

@@ -55,9 +55,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/lib/features/project/project-applications.e2e.test.ts

@@ -39,9 +39,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/lib/features/project/project-flag-creators.e2e.test.ts

@@ -16,9 +16,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/lib/features/project/projects.e2e.test.ts

@@ -21,9 +21,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/lib/features/tag-type/tag-types.e2e.test.ts

@@ -20,9 +20,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/lib/services/openapi-service.ts

@@ -107,9 +107,6 @@ export class OpenApiService {
                 `Invalid response for ${res.req?.originalUrl || ''}:`,
                 errors,
             );
-            if (this.flagResolver.isEnabled('strictSchemaValidation')) {
-                throw new Error(JSON.stringify(errors, null, 4));
-            }
         }
 
         Object.entries(headers).forEach(([header, value]) =>

src/lib/types/experimental.ts

@@ -12,7 +12,6 @@ export type IFlagKey =
     | 'responseTimeWithAppNameKillSwitch'
     | 'maintenanceMode'
     | 'messageBanner'
-    | 'strictSchemaValidation'
     | 'personalAccessTokensKillSwitch'
     | 'migrationLock'
     | 'demo'
@@ -89,10 +88,6 @@ const flags: IFlags = {
                 process.env.UNLEASH_EXPERIMENTAL_MESSAGE_BANNER_PAYLOAD ?? '',
         },
     },
-    strictSchemaValidation: parseEnvVarBoolean(
-        process.env.UNLEASH_STRICT_SCHEMA_VALIDTION,
-        false,
-    ),
     personalAccessTokensKillSwitch: parseEnvVarBoolean(
         process.env.UNLEASH_PAT_KILL_SWITCH,
         false,

src/server-dev.ts

@@ -50,7 +50,6 @@ process.nextTick(async () => {
                         showUserDeviceCount: true,
                         deltaApi: true,
                         uniqueSdkTracking: true,
-                        strictSchemaValidation: true,
                         reportUnknownFlags: true,
                         customMetrics: true,
                         impactMetrics: true,

src/test/e2e/api/admin/addon.e2e.test.ts

@@ -13,9 +13,7 @@ beforeAll(async () => {
     db = await dbInit('addon_api_serial', getLogger);
     app = await setupAppWithCustomConfig(db.stores, {
         experimental: {
-            flags: {
+            flags: {},
-                strictSchemaValidation: true,
-            },
         },
     });
 });

src/test/e2e/api/admin/api-token.e2e.test.ts

@@ -18,9 +18,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/admin/applications.e2e.test.ts

@@ -53,9 +53,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/admin/config.e2e.test.ts

@@ -17,9 +17,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,
@@ -80,7 +78,6 @@ describe('maxSessionsCount', () => {
             {
                 experimental: {
                     flags: {
-                        strictSchemaValidation: true,
                         showUserDeviceCount: true,
                     },
                 },

src/test/e2e/api/admin/constraints.e2e.test.ts

@@ -14,9 +14,7 @@ beforeAll(async () => {
     db = await dbInit('constraints', getLogger);
     app = await setupAppWithCustomConfig(db.stores, {
         experimental: {
-            flags: {
+            flags: {},
-                strictSchemaValidation: true,
-            },
         },
     });
 });

src/test/e2e/api/admin/context.e2e.test.ts

@@ -16,9 +16,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/admin/event-search.e2e.test.ts

@@ -36,9 +36,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/admin/event.e2e.test.ts

@@ -28,9 +28,7 @@ beforeAll(async () => {
     db = await dbInit('event_api_serial', getLogger);
     app = await setupAppWithCustomConfig(db.stores, {
         experimental: {
-            flags: {
+            flags: {},
-                strictSchemaValidation: true,
-            },
         },
     });
     eventService = createEventsService(db.rawDatabase, config);

src/test/e2e/api/admin/favorites.e2e.test.ts

@@ -89,9 +89,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/admin/feature-archive.e2e.test.ts

@@ -15,9 +15,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/admin/feature-type.test.ts

@@ -20,9 +20,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/admin/feedback.e2e.test.ts

@@ -39,9 +39,7 @@ beforeAll(async () => {
 
     app = await setupAppWithCustomAuth(stores, preHook, {
         experimental: {
-            flags: {
+            flags: {},
-                strictSchemaValidation: true,
-            },
         },
     });
 });

src/test/e2e/api/admin/instance-admin.e2e.test.ts

@@ -22,9 +22,7 @@ beforeAll(async () => {
         stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/admin/metrics.e2e.test.ts

@@ -16,9 +16,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/admin/project/api-token.e2e.test.ts

@@ -17,9 +17,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/admin/project/project.api.tokens.e2e.test.ts

@@ -16,9 +16,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/admin/project/project.health.e2e.test.ts

@@ -17,9 +17,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/admin/project/variants-sunset.e2e.test.ts

@@ -17,7 +17,6 @@ beforeAll(async () => {
         {
             experimental: {
                 flags: {
-                    strictSchemaValidation: true,
                     enableLegacyVariants: false,
                 },
             },

src/test/e2e/api/admin/project/variants.e2e.test.ts

@@ -18,7 +18,6 @@ beforeAll(async () => {
         {
             experimental: {
                 flags: {
-                    strictSchemaValidation: true,
                     enableLegacyVariants: true,
                 },
             },

src/test/e2e/api/admin/splash.e2e.test.ts

@@ -39,9 +39,7 @@ beforeAll(async () => {
 
     app = await setupAppWithCustomAuth(stores, preHook, {
         experimental: {
-            flags: {
+            flags: {},
-                strictSchemaValidation: true,
-            },
         },
     });
 });

src/test/e2e/api/admin/strategy.e2e.test.ts

@@ -12,9 +12,7 @@ beforeAll(async () => {
     db = await dbInit('strategy_api_serial', getLogger);
     app = await setupAppWithCustomConfig(db.stores, {
         experimental: {
-            flags: {
+            flags: {},
-                strictSchemaValidation: true,
-            },
         },
     });
     await db.stores.strategyStore.createStrategy({

src/test/e2e/api/admin/tags.e2e.test.ts

@@ -14,9 +14,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/admin/user-admin.e2e.test.ts

@@ -112,7 +112,6 @@ describe('User Admin API with email configuration', () => {
                 },
                 experimental: {
                     flags: {
-                        strictSchemaValidation: true,
                         showUserDeviceCount: true,
                     },
                 },
@@ -166,7 +165,6 @@ describe('User Admin API without email', () => {
             {
                 experimental: {
                     flags: {
-                        strictSchemaValidation: true,
                         showUserDeviceCount: true,
                     },
                 },

src/test/e2e/api/admin/user-admin.scim.e2e.test.ts

@@ -40,9 +40,7 @@ beforeAll(async () => {
     app = await setupAppWithCustomConfig(stores, {
         enterpriseVersion: 'enterprise',
         experimental: {
-            flags: {
+            flags: {},
-                strictSchemaValidation: true,
-            },
         },
     });
 

src/test/e2e/api/client/feature.auth-none.e2e.test.ts

@@ -24,9 +24,7 @@ beforeAll(async () => {
                 type: 'none',
             },
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/client/feature.e2e.test.ts

@@ -21,9 +21,7 @@ beforeAll(async () => {
         db.stores,
         {
             experimental: {
-                flags: {
+                flags: {},
-                    strictSchemaValidation: true,
-                },
             },
         },
         db.rawDatabase,

src/test/e2e/api/client/feature.optimal304.e2e.test.ts

@@ -57,7 +57,6 @@ async function setup({
             },
             experimental: {
                 flags: {
-                    strictSchemaValidation: true,
                     etagVariant: {
                         name: etagVariant,
                         enabled: etagVariant !== undefined,

src/test/e2e/helpers/test-helper.ts

@@ -387,7 +387,6 @@ async function createApp(
             experimental: {
                 ...(customOptions?.experimental ?? {}),
                 flags: {
-                    strictSchemaValidation: true,
                     ...(customOptions?.experimental?.flags ?? {}),
                 },
             },
@@ -443,7 +442,6 @@ export async function setupAppWithoutSupertest(
             experimental: {
                 ...(customOptions?.experimental ?? {}),
                 flags: {
-                    strictSchemaValidation: true,
                     ...(customOptions?.experimental?.flags ?? {}),
                 },
             },