Christopher Kolstad
53354224fc
chore: Bump biome and configure husky ( #6589 )
...
Upgrades biome to 1.6.1, and updates husky pre-commit hook.
Most changes here are making type imports explicit.
2024-03-18 13:58:05 +01:00
Fredrik Strand Oseberg
f381718fd6
fix: icon imports ( #6499 )
...
Based on this article:
https://mui.com/material-ui/guides/minimizing-bundle-size/ importing
from `'@mui/icons-material'` instead of specifying the actual path to
the icon like `import Delete from '@mui/icons-material/Delete';` can be
up to six time slower. This change changes all named imports in Unleash
referencing the `@mui/icons-material` to default imports.
This reduced the amount of modules we had to process when building the
frontend from 15206 to 4746
Before:
<img width="1016" alt="Skjermbilde 2024-03-11 kl 14 19 58"
src="https://github.com/Unleash/unleash/assets/16081982/f137d24a-6557-4183-a40f-f62a33524520 ">
After:
<img width="1237" alt="Skjermbilde 2024-03-11 kl 14 20 32"
src="https://github.com/Unleash/unleash/assets/16081982/05a27d6a-2c3f-4409-9862-7188ab4b9c72 ">
Build time locally decreased by around 50%
Before:
<img width="1504" alt="Skjermbilde 2024-03-11 kl 14 31 45"
src="https://github.com/Unleash/unleash/assets/16081982/bc931559-b022-47ed-9f8f-c87401578518 ">
After:
<img width="1219" alt="Skjermbilde 2024-03-11 kl 14 27 00"
src="https://github.com/Unleash/unleash/assets/16081982/3c3a8d6b-576d-45c3-aa40-cc5f95d9df2b ">
2024-03-12 10:56:10 +01:00
Thomas Heartman
aecc0b54a1
feat: show suspended states in change request badge ( #5871 )
...
This updates the CR badge to show suspended states correctly.
<img width="370" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/f678059b-f72a-46ef-9111-0fc90f228fc8 ">
2024-01-12 16:48:34 +05:30
Thomas Heartman
39145e2617
refactor: use union types for change request types ( #5870 )
...
This changes the two interfaces IChangeRequest and
IChangeRequestSchedule to be union types instead of interfaces. It also
extracts the constituents of those union types into proper types
themselves (so that they can be used in function type signatures etc).
It also updates the type names.
This turned out to be more work than I had imagined, but I think the end
result pays off, giving us more type safety and control.
I wanted to use just `ChangeRequest` for the IChangeRequest type, but
that caused issues due to naming collisions with the `ChangeRequest`
component that we have, causing tests to fail. I've named it
`ChangeRequestType` as a potential solution, but suggestions are
welcome.
The relevant changes are in
`frontend/src/component/changeRequest/changeRequest.types.ts`.
Everything else is updated references and some necessary refactoring to
respect the new types.
2024-01-12 13:15:43 +05:30
andreas-unleash
fbeb5425af
feat: add tooltip to Scheduled badge ( #5726 )
...
Closes #
[1-1831](https://linear.app/unleash/issue/1-1831/enhancement-tooltips-for-change-request-overview-page-to-add-hover )
<img width="1332" alt="Screenshot 2023-12-22 at 12 59 15"
src="https://github.com/Unleash/unleash/assets/104830839/1a851b47-4756-4f3f-a9e6-14067e395738 ">
<img width="1263" alt="Screenshot 2023-12-22 at 12 59 07"
src="https://github.com/Unleash/unleash/assets/104830839/cdce0e81-3e04-4414-8965-13072b282dea ">
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2024-01-09 10:32:52 +02:00
Thomas Heartman
795aa18bca
fix: use the correct icon for failed scheduled CRs ( #5760 )
...
This PR switches the notification icon to an exclamation mark (the Error
icon). It updates three components:
1. The badge
2. The timeline
3. The review status
Screenshot with all the replaced icons
2024-01-04 15:44:53 +05:30
andreas-unleash
cbd50ac0f5
Feat: show status of scheduled change request ( #5630 )
...
Modifies the ChangeRequestStatusBadge to display the failed execution
Closes #
[1-1767](https://linear.app/unleash/issue/1-1767/add-status-to-scheduled-badge )
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-12-14 11:49:03 +02:00
andreas-unleash
6b637d5fa9
feat: scheduled change request state ( #5261 )
...
Adds the scheduled state to ChangeRequestOverview.tsx
<img width="1523" alt="Screenshot 2023-11-03 at 12 52 07"
src="https://github.com/Unleash/unleash/assets/104830839/710b5f26-04a0-4ee9-b646-8ff3090ad86a ">
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-03 15:02:51 +02:00
Nuno Góis
4167a60588
feat: biome lint frontend ( #4903 )
...
Follows up on https://github.com/Unleash/unleash/pull/4853 to add Biome
to the frontend as well.
Added a few `biome-ignore` to speed up the process but we may want to
check and fix them in the future.
2023-10-02 13:25:46 +01:00
Mateusz Kwasniewski
3227e30f12
feat: Change request reject UI ( #4489 )
2023-08-15 09:08:26 +02:00
Mateusz Kwasniewski
aa9aa6fb4a
styling change request sidebar ( #2350 )
2022-11-08 16:16:30 +01:00
Fredrik Strand Oseberg
d8db33ac7f
Feat/change request overview applied state ( #2322 )
...
* feat: review button
* feat: add review button
* fix: add to box
* fix: separate function calls
* fix: comment out reviewers
* fix: type
2022-11-03 12:43:03 +01:00
Tymoteusz Czech
0a855604af
feat: review your draft sidebar ( #2305 )
...
* refactor playground status chip component
* fix: update change request sidebar
* refactor: status badge cleanup
* fix: prettier formatting
2022-11-02 16:05:27 +01:00
