1
0
mirror of https://github.com/Unleash/unleash.git synced 2024-12-28 00:06:53 +01:00
Commit Graph

3 Commits

Author SHA1 Message Date
Thomas Heartman
312b5d42e8
meta: add external PRs to project board
The `pull_request` hook runs in the context of the proposed changes. That means that for forks, this action won't have access to the required secrets for it to complete. As such, PRs from outside contributors won't work correctly.

The `pull_request_target` hook, however, runs in the context of the target branch, and thus has all the permissions it needs. The [github docs for this hook](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target) also indicate that this is the way to go:

> This event allows your workflow to do things like label or comment on pull requests from forks. Avoid using this event if you need to build or run code from the pull request.

## Interesting note for PRs

It seems that when this change is proposed as a PR, the expected action (_add new item to project board_) does not run. However, this does not affect other new PRs. Also, after merging it works as expected, for both external and internal contributors.
2022-05-20 15:21:54 +02:00
Thomas Heartman
119d958e7c fix: add version information for reusable workflow
without this, the workflow won't run
2022-05-11 11:38:39 +02:00
Thomas Heartman
c260f90094
chore: Add workflow file to auto-add items to project board (#1588)
This change adds a workflow file that references the reusable workflow
in the unleash/.github repo. It should (if all goes well),
automatically add new issues and prs to the project board.
2022-05-11 11:10:16 +02:00