Tymoteusz Czech
fd3a7f12cb
chore: remove featureSwitchRefactor flag ( #5329 )
...
Cleanup. This change has been rolled out to significant number of
customers already, and we have another parallel version behind a flag.
2023-11-14 13:03:23 +01:00
Nuno Góis
4d1f76e61b
fix: take into account project segments permission ( #5304 )
...
https://linear.app/unleash/issue/SR-164/ticket-1106-user-with-createedit-project-segment-is-not-able-to-edit-a
Fixes a bug where the `UPDATE_PROJECT_SEGMENT` permission is not
respected, both on the UI and on the API. The original intention was
stated
[here](https://github.com/Unleash/unleash/pull/3346#discussion_r1140434517 ).
This was easy to fix on the UI, since we were simply missing the extra
permission on the button permission checks.
Unfortunately the API can be tricky. Our auth middleware tries to grab
the `project` information from either the params or body object, but our
`DELETE` method does not contain this information. There is no body and
the endpoint looks like `/admin/segments/:id`, only including the
segment id.
This means that, in the rbac middleware when we check the permissions,
we need to figure out if we're in such a scenario and fetch the project
information from the DB, which feels a bit hacky, but it's something
we're seemingly already doing for features, so at least it's somewhat
consistent.
Ideally what we could do is leave this API alone and create a separate
one for project segments, with endpoints where we would have project as
a param, like so:
`http://localhost:4242/api/admin/projects/:projectId/segments/1 `.
This PR opts to go with the quick and hacky solution for now since this
is an issue we want to fix quickly, but this is something that we should
be aware of. I'm also unsure if we want to create a new API for project
segments. If we decide that we want a different solution I don't mind
either adapting this PR or creating a follow up.
2023-11-09 09:37:47 +00:00
Fredrik Strand Oseberg
92e2b1890c
Refactor/project overview api calls ( #5279 )
...
This PR reduces the overhead of making API calls on pages with heavy
renders. We forego loading states and default error handling in favor of
more speed by avoiding triggering multiple re-renders from the API call.
2023-11-07 09:19:55 +01:00
Nuno Góis
6c21ed5f74
feat: make maintenance-related 503s more intuitive ( #5018 )
...
This makes maintenance-related 503s more intuitive on our UI by
mentioning that maintenance banner is currently enabled.
2023-10-16 09:27:29 +01:00
Nuno Góis
4167a60588
feat: biome lint frontend ( #4903 )
...
Follows up on https://github.com/Unleash/unleash/pull/4853 to add Biome
to the frontend as well.
Added a few `biome-ignore` to speed up the process but we may want to
check and fix them in the future.
2023-10-02 13:25:46 +01:00
Mateusz Kwasniewski
65e62c64b8
fix: import duplicate features ( #4550 )
2023-08-23 11:11:16 +02:00
Tymoteusz Czech
a11cb72d99
Persistent table query ( #999 )
...
* feat: persistent table query
* project overview sort query
* refactor: api methods as hook callbacks
* persitent columns in project overview
* enable new project overview
* fix: refactor feature state change in overview
* add type to sort
* update e2e tests
now takes 10% less time with use of cypress session
* prevent sort reset on features list
* fix feature toggle list loading
* fix: update column state saving
* update local storage hook test
2022-05-25 08:14:22 +00:00
olav
2e5e25bfe5
refactor: improve icon labels and tooltips ( #884 )
2022-04-21 08:26:49 +02:00
Youssef Khedher
85950f104a
chore: update paths 🧼 ( #820 )
2022-03-28 09:49:59 +01:00
olav
cfc2338e78
refactor: use camel case for files and dirs ( #817 )
2022-03-25 12:34:20 +01:00
olav
3959e846e8
refactor: fix misc TS errors ( #729 )
...
* refactor: update test deps
* refactor: remove unused ts-expect-error annotations
* refactor: add missing arg and return types
* refactor: the loading prop is optional
* refactor: add missing arg and return types
* reafactor: fix value arg type
* refactor: fix missing array type
* refactor: the parameters field is an array
* refactor: use undefined instead of null in state
* refactor: add missing params type
* refactor: add missing children prop
* refactor: add missing array type
* refactor: add missing React imports
* refactor: use correct IProjectEnvironment type
* refactor: type errors as unknown
* refactor: the index prop is required
* refactor: fix date prop type
* refactor: fix tooltip placement prop type
* refactor: fix environments state type
* refactor: add missing arg types
* refactor: add guard for undefined field
* refactor: fix ChangePassword prop types
* refactor: fix MUI import paths
* refactor: add missing arg type
* refactor: fix showDialog prop type
* refactor: remove unused openUpdateDialog prop
* refactor: add missing non-null assertion
* refactor: remove unused types prop
* refactor: stricten API error handler types
* refactor: add missing undefined check
* refactor: add missing IProject id field
* refactor: fix ConditionallyRender condition prop types
* refactor: remove unused args
* refactor: add AddVariant prop types
* refactor: add types to UIContext
* refactor: fix event arg type
* refactor: add missing default impressionData field
* refactor: fix handleDeleteEnvironment prop args
* refactor: fix IFeatureMetrics field requirements
* refactor: add missing element types to ConditionallyRender
* refactor: remove unused ProjectAccess projectId prop
* refactor: add missing undefined check
* refactor: fix getCreateTogglePath arg type
* refactor: add missing IStrategyPayload import
* refactor: remove unused user arg
* refactor: add missing event arg type
* refactor: add missing style object types
* refactor: improve userApiErrors prop type
* refactor: the Dialogue onClose prop is optional
* refactor: fix the AddonEvents setEventValue prop type
2022-02-25 10:55:39 +01:00
Fredrik Strand Oseberg
c99decf5e0
remove: redux ( #696 )
...
* remove: redux
* fix: add sass back
* fix: update lock
* fix: remove fake access store import
'
2022-02-11 11:19:55 +01:00
Youssef Khedher
08c4b60cef
fix: project access ( #621 )
...
* feat: update useProjectApi hook
* fix: refactor to hooks
* fix: remove some ts errors
* fix: set message if error exists directly on response
* fix: remove console logs
* fix: typo
* delete: context2
* feat: filter added user from user add list
* fix: cleanup PR based on feedback
* fix: handle undefined roles in ProjectRoleSelect
* fix: use target value
* fix: type event
* fix: conflict
* fix: add appropriate types
* fix conflicts
* fix: explicit query
* fix: refactor list
* refactor: permission icon button
* fix: conflict
* fix: ts errors
* refactor: break list into its own component
* fix: use stringifed deps
* fix: explicit export
* fix: update pr according to comments
Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
2022-02-09 12:25:02 +01:00
olav
f4d5ed03aa
refactor: port auth admin to TS/SWR ( #675 )
...
* refactor: format files
* refactor: add missing RE UI config flag
* refactor: port admin auth index to TS/SWR
* refactor: port GoogleAuth to TS/SWR
* refactor: port OidcAuth to TS/SWR
* refactor: port SamlAuth to TS/SWR
* refactor: remove unused e-admin-auth store
* refactor: make AutoCreateForm an explicit export
* refactor: improve auth settings dir structure
* refactor: destructure authenticationType from uiConfig
* refactor: use setToastApiError to show errors
* refactor: format files
* refactor: remove invalid string fields from requests
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2022-02-08 11:44:41 +01:00
Youssef Khedher
182d566895
feat/rbac roles ( #562 )
...
* feat: create screen
* fix: import accordion summary
* feat: add accordions
* fix: add codebox
* feat: select permissions
* fix: permission checker
* fix: update permission checker
* feat: wire up role list
* fix: change icon color in project roles list
* fix: add color to icon in project roles
* add confirm dialog on role deletion
* feat: add created screen
* fix: cleanup
* fix: update access permissions
* fix: update admin panel
* feat: add edit screen
* fix: use color from palette and show toast when fails
* fix: refactor
* feat: validation
* feat: implement checked all
* fix: experimental toast
* fix: error handling
* fix: toast
* feat: unique name validation
* fix: update toasts
* fix: remove toast
* fix: reset flag
* fix: remove unused vars
* fix: update tests
* feat: add error icon for toast
* fix: replace wrong import for setToastData
* feat: Patch keying on ui to handle uniqueness for permissions across multiple envs
* fix: hasAccess handles *
* fix: update permission switch
* fix: use flag for environments rbac
* fix: do not include check all keys in payload
* fix: filter roles
* fix: account for new permissions in variants list
* fix: use effect on length property
* fix: set polling interval on user
* 4.5.0-beta.0
* fix: set initial permissions correctly to avoid race condition
* fix: handle activeEnvironment when it is null
* fix: remove unused imports
* fix: unused imports
* fix: Include missing project in hasAccess for deleteinng a tag
* fix: Move add/delete tag to use update feature permissions
* fix: use rest parameter
* fix: remove sandbox from scripts
* 4.6.0-beta.1
* fix: remove loading deduping
* fix: disable editing on builtin roles
* fix: check all
* fix: feature overview environment
* fix: refetch user on project create
* fix: update snaphots
* fix: frontend permissions
* fix: delete create confirm
* fix: remove unused permission
* 4.6.0-beta.4
* fix: update permissions
* fix: permissions
* fix: set error to string
* 4.6.0-beta.5
* fix: add permissions for project view
* fix: add permissions to useEffect deps
* fix: update permission for move feature toggle
* fix: add permissions data to useEffect
* fix: move settings
* fix: key on confetti
* fix: refetch project permissions on environment create/delete
* fix: optional coalescing error object
* fix: remove logging error
* fix: reorder disable importance in permissionbutton
* fix: add project roles to menu
* fix: add disabled check to revive
* fix: update snapshots
* fix: change text to select all
* fix: change text to select
* 4.6.0-beta.6
Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
Co-authored-by: sighphyre <liquidwicked64@gmail.com>
2022-01-14 15:50:02 +01:00
Youssef Khedher
ed6efff643
Fix/variants: Fix delete one variant + remove switch when add first variant ( #466 )
...
Co-authored-by: Ivar Conradi Østhus <ivarconr@gmail.com>
Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
2021-10-28 13:32:29 +02:00
Ivar Conradi Østhus
1058b4049c
fix: envrionments should give understandable error if not possible to… ( #433 )
2021-10-14 19:58:57 +02:00
Fredrik Strand Oseberg
92f3f8af08
Feat/environment crud ( #335 )
...
* feat: add env
* fix: create environment form
* feat: create environment
* feat: add deletion protection
* fix: lift up state
* feat: add ability to update environment
* fix: remove env reset
* fix: remove link
* feat: add drag and drop sorting
* fix: remove unused imports
* feat: add methods to toggle env on/off
* feat: only make api call on drop
* fix: disabled text
* fix: add disabled indicator
* fix: add edit env payload
* fix: add E flag
* fix: cleanup
* fix: update snapshots
* fix: remove useFeature
* fix: change property to errorText
* fix: update tests
* fix: change menu
* fix: update snapshots
* feat: toggle view v2
* fix: handle error on sort order api call
* fix: remove unused import
* fix: useFeature
* fix: update tests
* fix: console logs
* fix: use try catch
* fix: update snapshots
2021-09-14 14:20:23 +02:00
Fredrik Strand Oseberg
1a63d91f95
Feat/new navigation ( #314 )
...
* feat: change color scheme
* feat: add navigation menu
* fix: add bg image
* fix: add archive and strategies to navigation
* fix: round corners
* feat: mobile view project details
* feat: mobile view navigation
* fix: only show menu if user is admin
* fix: rename navigation
* fix: only render relevant routes for oss context
* feat: add project actions
* feat: add icons
* feat: add breadcrumbs
* fix: place breadcrumbs absolutely
* fix: adjust breadcrumbs
* fix: toast
* fix: cleanup
* fix login
* fix: breadcrumbs
* fix: add billing link
* fix: links
* fix: feature view
* fix: path to go back
* fix: remove default value
* fix: remove unused imports
* refactor: delete outdated test
* fix: add item to filter in breadcrumb
* fix: remove console log
2021-07-16 15:41:54 +02:00
Fredrik Strand Oseberg
85a7c55fdf
Feat/group by projects ( #308 )
...
This PR adds support for projects as a first class citizen, and toggling features on in different environments.
2021-07-07 11:04:36 +02:00
