1
0
mirror of https://github.com/Unleash/unleash.git synced 2024-10-18 20:09:08 +02:00
Commit Graph

79 Commits

Author SHA1 Message Date
Youssef
14154b605a fix: update PR based on feedback 2022-03-01 09:50:29 +01:00
Youssef
55de43ad07 feat: add search in projects 2022-02-28 17:00:12 +01:00
Youssef
b58cccc7d0 fix: merge conflicts 2022-02-25 15:28:38 +01:00
Youssef Khedher
a3f439ea17 Merge branch 'main' into fix/ui-consistency 2022-02-25 13:54:11 +01:00
olav
3959e846e8 refactor: fix misc TS errors (#729)
* refactor: update test deps

* refactor: remove unused ts-expect-error annotations

* refactor: add missing arg and return types

* refactor: the loading prop is optional

* refactor: add missing arg and return types

* reafactor: fix value arg type

* refactor: fix missing array type

* refactor: the parameters field is an array

* refactor: use undefined instead of null in state

* refactor: add missing params type

* refactor: add missing children prop

* refactor: add missing array type

* refactor: add missing React imports

* refactor: use correct IProjectEnvironment type

* refactor: type errors as unknown

* refactor: the index prop is required

* refactor: fix date prop type

* refactor: fix tooltip placement prop type

* refactor: fix environments state type

* refactor: add missing arg types

* refactor: add guard for undefined field

* refactor: fix ChangePassword prop types

* refactor: fix MUI import paths

* refactor: add missing arg type

* refactor: fix showDialog prop type

* refactor: remove unused openUpdateDialog prop

* refactor: add missing non-null assertion

* refactor: remove unused types prop

* refactor: stricten API error handler types

* refactor: add missing undefined check

* refactor: add missing IProject id field

* refactor: fix ConditionallyRender condition prop types

* refactor: remove unused args

* refactor: add AddVariant prop types

* refactor: add types to UIContext

* refactor: fix event arg type

* refactor: add missing default impressionData field

* refactor: fix handleDeleteEnvironment prop args

* refactor: fix IFeatureMetrics field requirements

* refactor: add missing element types to ConditionallyRender

* refactor: remove unused ProjectAccess projectId prop

* refactor: add missing undefined check

* refactor: fix getCreateTogglePath arg type

* refactor: add missing IStrategyPayload import

* refactor: remove unused user arg

* refactor: add missing event arg type

* refactor: add missing style object types

* refactor: improve userApiErrors prop type

* refactor: the Dialogue onClose prop is optional

* refactor: fix the AddonEvents setEventValue prop type
2022-02-25 10:55:39 +01:00
Youssef
5371e15333 refactor: change resourceCreateButton and SaveChangesButton name 2022-02-24 09:23:07 +01:00
Youssef
af6542a291 feat: create ressources buttons and update all forms 2022-02-24 00:57:35 +01:00
Youssef
b0ba4f3a9d fix: remove tooltips 2022-02-23 13:45:37 +01:00
Youssef
aae8c4d9d9 refactor: update text in ui consistent 2022-02-23 00:10:48 +01:00
olav
016633dae9 refactor: format files (#719)
* refactor: fix deprecated prettier config name

* refactor: add fmt scripts

* refactor: check fmt during CI

* refactor: format files
2022-02-18 09:51:10 +01:00
olav
46bf92124d refactor: remove unused code (#721) 2022-02-18 08:26:26 +01:00
olav
878f892c50 refactor: fix misc test feedback (#709)
* refactor: keep feature toggle name when changing project

* refactor: add missing permission button tooltip

* refactor: add success toast on toggle revival

* refactor: add success toast on stale toggle

* refactor: fix initial user role checkbox value

* refactor: remove duplicated error message

* refactor: fix change-password error parsing

* refactor: remove inaccurate edit toggle toast text

* refactor: truncate long names in project cards

* refactor: truncate long project name in title

* refactor: add ellipses to truncated strings

* refactor: swap truncateString with StringTruncator

* refactor: remove unnecessary truncation

* refactor: mark context fields as optional

* refactor: show all errors from tag type creation

* refactor: show all errors from strategy create/update

* refactor: filter out empty strategies on create/update

* refactor: add an edit button to the addons list

* refactor: add missing labels

* refactor: catch errors from toggling stale features
2022-02-15 10:57:57 +01:00
Fredrik Strand Oseberg
de8b3352e7 Fix/project select (#693)
* fix: remove container for ProjectSelect

* refactor: remove project store

* fix: update path
2022-02-10 23:45:30 +01:00
olav
213e8950d3 refactor: port login auth to TS/SWR (#680)
* refactor: allow existing tsc errors

* refactor: add missing component key

* refactor: port login auth to TS/SWR

* refactor: replace incorrect CREATE_TAG_TYPE with UPDATE_TAG_TYPE

* refactor: fix AccessProvider permission mocks

* refactor: add types to AccessContext

* refactor: fix file extension

* refactor: remove default export

* refactor: remove unused IAddedUser interface

* refactor: comment on the permissions prop

* refactor: split auth hooks

* feat: auth tests

* fix: setup separate e2e tests

* fix: naming

* fix: lint

* fix: spec path

* fix: missing store

* feat: add more tests

Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
2022-02-10 17:04:10 +01:00
olav
010f766de9 refactor: replace ts-ignore with ts-expect-error (#681)
* refactor: replace ts-ignore with ts-expect-error

* refactor: remove unused ts-expect-errors
2022-02-09 13:39:18 +01:00
Youssef Khedher
08c4b60cef fix: project access (#621)
* feat: update useProjectApi hook

* fix: refactor to hooks

* fix: remove some ts errors

* fix: set message if error exists directly on response

* fix: remove console logs

* fix: typo

* delete: context2

* feat: filter added user from user add list

* fix: cleanup PR based on feedback

* fix: handle undefined roles in ProjectRoleSelect

* fix: use target value

* fix: type event

* fix: conflict

* fix: add appropriate types

* fix conflicts

* fix: explicit query

* fix: refactor list

* refactor: permission icon button

* fix: conflict

* fix: ts errors

* refactor: break list into its own component

* fix: use stringifed deps

* fix: explicit export

* fix: update pr according to comments

Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
2022-02-09 12:25:02 +01:00
olav
234bab6cb4 refactor: port ReportCard to TS/SWR (#674)
* refactor: remove unused reporting code

* refactor: port ReportCard to TS/SWR
2022-02-07 15:30:33 +01:00
Fredrik Strand Oseberg
c5c0f066de fix: add tsx and nullish coalescence (#667) 2022-02-03 14:29:15 +01:00
olav
23c6c0cd8f fix: remove stray debugger statement (#657) 2022-02-02 09:43:58 +01:00
Ivar Conradi Østhus
c54ea3a9d4 fix: race condition when adding users 2022-02-01 22:43:35 +01:00
Youssef
8cbfefc47a fix: add autofocus to all new create-screens 2022-01-28 15:14:12 +01:00
Youssef Khedher
3488bb5fd6 fix: handle existing feature name (#641)
* fix: handle existing feature name

* refactor: change feature input order
2022-01-28 15:03:42 +01:00
Youssef Khedher
27700007c0 fix: align projectId in project overview (#632) 2022-01-26 13:56:15 +01:00
Youssef
52fddb2069 fix: update validateProjectId 2022-01-25 12:30:55 +01:00
Youssef
b59c68c59b fix: update buttons order in new screens 2022-01-25 00:47:49 +01:00
Youssef Khedher
c06f22bd8a feat: add toast for project access operations (#616) 2022-01-20 13:07:54 +01:00
Youssef Khedher
90231cc230 fix: add pagination to project access list (#615)
* fix: add pagination to project access list

* fix: typo

Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
2022-01-20 10:12:27 +01:00
Youssef Khedher
39b5adb950 feat: add create and edit project screen (NEW) (#602)
* feat: add create and edit project screen

* feat: fix correct permission and validate projectId

* feat: remove unused variable and logs

* feat: remove unused import

* fix: delete unused project components

* fix: add unique validation

* fix: add unused import

* fix: project header

Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
2022-01-19 14:28:55 +01:00
Youssef Khedher
3a41de2246 feat/update project access (#571)
* feat: add user guidance in project access tab

* feat: add role description to the menu list

* feat: add tooltip to delete button

* feat: add role description to add user menu

* feat: auto select user when there is only one option

* fix: refactor role select

* fix: remove minwidth from form control

Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
2022-01-17 11:41:44 +01:00
Youssef Khedher
182d566895 feat/rbac roles (#562)
* feat: create screen

* fix: import accordion summary

* feat: add accordions

* fix: add codebox

* feat: select permissions

* fix: permission checker

* fix: update permission checker

* feat: wire up role list

* fix: change icon color in project roles list

* fix: add color to icon in project roles

* add confirm dialog on role deletion

* feat: add created screen

* fix: cleanup

* fix: update access permissions

* fix: update admin panel

* feat: add edit screen

* fix: use color from palette and show toast when fails

* fix: refactor

* feat: validation

* feat: implement checked all

* fix: experimental toast

* fix: error handling

* fix: toast

* feat: unique name validation

* fix: update toasts

* fix: remove toast

* fix: reset flag

* fix: remove unused vars

* fix: update tests

* feat: add error icon for toast

* fix: replace wrong import for setToastData

* feat: Patch keying on ui to handle uniqueness for permissions across multiple envs

* fix: hasAccess handles *

* fix: update permission switch

* fix: use flag for environments rbac

* fix: do not include check all keys in payload

* fix: filter roles

* fix: account for new permissions in variants list

* fix: use effect on length property

* fix: set polling interval on user

* 4.5.0-beta.0

* fix: set initial permissions correctly to avoid race condition

* fix: handle activeEnvironment when it is null

* fix: remove unused imports

* fix: unused imports

* fix: Include missing project in hasAccess for deleteinng a tag

* fix: Move add/delete tag to use update feature permissions

* fix: use rest parameter

* fix: remove sandbox from scripts

* 4.6.0-beta.1

* fix: remove loading deduping

* fix: disable editing on builtin roles

* fix: check all

* fix: feature overview environment

* fix: refetch user on project create

* fix: update snaphots

* fix: frontend permissions

* fix: delete create confirm

* fix: remove unused permission

* 4.6.0-beta.4

* fix: update permissions

* fix: permissions

* fix: set error to string

* 4.6.0-beta.5

* fix: add permissions for project view

* fix: add permissions to useEffect deps

* fix: update permission for move feature toggle

* fix: add permissions data to useEffect

* fix: move settings

* fix: key on confetti

* fix: refetch project permissions on environment create/delete

* fix: optional coalescing error object

* fix: remove logging error

* fix: reorder disable importance in permissionbutton

* fix: add project roles to menu

* fix: add disabled check to revive

* fix: update snapshots

* fix: change text to select all

* fix: change text to select

* 4.6.0-beta.6

Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
Co-authored-by: sighphyre <liquidwicked64@gmail.com>
2022-01-14 15:50:02 +01:00
Youssef Khedher
31d88da08b feat: update health report (#541)
* fix: align styling with other pages

* feat: add last updat to heath report

* add feature status to last seen in health overview

* fix: add mobile style

* fix:add background color on table hover

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2021-12-07 13:17:32 +01:00
Thomas Heartman
dd1ab1ca72 Autofocus dialog form fields, allow form submissions via pressing enter inside the form (#524)
* chore: add prettier as a dev dependency

The project has a .prettierrc, so seems to depend on that for its
formatting, but there was no prettier installed with the node modules.

* chore: add autofocus to all clearly defined first inputs on dialogs.

* fix: wrap the disable env input in a form and give it autofocus.

* fix: submit form when pressing enter

* fix: only autofocus the submit button if there is no other content.

When multiple (enabled) elements have the autofocus attribute, the
browser picks the last element in the tree. This means that if there
is a form with a text input with autofocus and a submit button with
autofocus, the button will win, causing the user to have to tab back up.

Only doing this if there are no children will cause some changes,
however:

Dialogs with textual children will no longer focus the accept-button
when appearing.

However, dialogs such as the create new api token dialog will give the
focus to the first input field instead of to the create button.

* fix: add formId prop to dialog element; adapt behavior

If the component receives a form id, it will treat the primary button
as the submit button for that form. To stop a full page reload, we
call the `preventDefault` on the submit event before calling the handler.

* chore: remove redundant spacing in component.

* fix: hook environment disable form up with the new form id system.

* chore: Update existing modal forms to pass in formId

* fix: Type the dialog event wrapper

* fix: change 'allows' => 'allow' because the noun is pluralized.

* fix: add autofocus to js add-tag-dialog-component.

I've got a feeling this component isn't in use anymore, though, as the
exact same text appears in a TS-version of this component.

* fix: add autofocus to add user form.

This seems to only be used as the main piece of a modal, so adding
autofocus seems pretty safe here, but I could be wrong.

* fix: Update snapshot test after changing wording.

* fix: add autofocus to update user form

* fix: add autofocus to the create toggle form.

This is a little besides the task's actual point. However! This form
is only ever used on the page where it's the only bit of content. I'd
argue that when the user navigates to this form, it's because they
want to create a feature. Thus, adding autofocus to the first field
makes a lot of sense to me.

* refactor: set button type to 'undefined' when it isn't 'submit'

This allows Material to use their default type based on whatever
heuristics they use. It's most likely going to be 'button' for the
foreseeable future, but in the event that they change it, passing
undefined instead should future-proof this a bit.

* fix: set type to button when formId is not present

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2021-11-29 15:18:12 +01:00
Fredrik Strand Oseberg
36fcac7178 Fix/project view desc (#515)
* fix: rollout icon and disabled state

* fix: mobile position

* refactor: move into style file

* fix: description box for projects

* fix: icon placement

* fix: icon

* fix: mobile project view

* fix: add style file to disabled indicator

* fix: hide icon on mobile

* fix: description

* fix: remove project logo
2021-11-24 14:36:21 +01:00
Youssef
e5ff80a9d5 fix: add correct path for create first toggle button 2021-11-05 09:22:01 +01:00
Fredrik Oseberg
b6b97e3c0f fix: toast text 2021-11-04 15:36:29 +01:00
Fredrik Strand Oseberg
d5c0ec2628 fix: guard for disabling envs (#492)
* fix: guard for disabling envs

* fix: remove local function

* fix: remove local type
2021-11-04 14:24:36 +01:00
Christopher Kolstad
83ad4041bf fix: Adds PermissionSwitch (#456)
- This adds a generic way to control permission to mutations in the same
  way as our PermissionButton and PermissionIconButton already does the
  same.

- This also switches the StrategiesList to use PermissionIconButton so
  users without ADMIN role do not believe they can deprecate/reactivate
  strategies.
2021-10-21 13:25:39 +02:00
Youssef Khedher
2bce93a51b Fix: improve create new feature v2 (#441) 2021-10-20 13:12:48 +02:00
Fredrik Strand Oseberg
57928d50c6 Fix/environment list sorting (#447)
* fix: wait for api call before refetching

* fix: set active environment from feature instead of cache

* fix: remove console logs

* fix: add permission icon button to project card

* fix: remove project button

* fix: empty tooltip if it is not passed

* fix: add refresh interval

* fix: permission buttons

* fix: project permission buttons

* fix: remove unused imports

* fix: add projectId
2021-10-20 12:05:44 +02:00
Youssef Khedher
3dc7f22aaa fix switch toggle for envs after update + update link for health overview (#446)
* fix switch toggle for envs after update

* fix: React hook missing dependency error
2021-10-19 15:38:20 +02:00
Fredrik Strand Oseberg
005daa3740 Fix/login redirect (#442)
* fix: use swr with login

* fix: remove metrics poller

* fix: do not allow retry on 401

* fix: create swr provider

* fix: move accessprovider

* fix: remove metrics poller test

* fix: hide password auth if disableDefault is set

* Update src/component/project/ProjectList/ProjectList.tsx

Co-authored-by: Christopher Kolstad <chriswk@getunleash.ai>

* fix: console log

Co-authored-by: Christopher Kolstad <chriswk@getunleash.ai>
2021-10-19 13:08:25 +02:00
Ivar Conradi Østhus
edd6706ffe fix: new create toggle page 2021-10-15 14:16:17 +02:00
Ivar Conradi Østhus
d42d412bc8 fix: make toggle list sortable inside a project (#436)
* fix: make toggle list sortable inside a project

* fix: minor cleanup
2021-10-15 11:20:14 +02:00
Ivar Conradi Østhus
1058b4049c fix: envrionments should give understandable error if not possible to… (#433) 2021-10-14 19:58:57 +02:00
Ivar Conradi Østhus
012cfc1806 fix: hide project CRUD actions for oss (#416) 2021-10-12 13:21:45 +02:00
Youssef Khedher
ff6affdae5 Merge branch 'master' into fix/reload-tabs 2021-10-12 09:09:25 +01:00
Youssef
a139cd4034 fix reload env and setting tabs 2021-10-12 08:39:31 +01:00
Youssef Khedher
b4fb4b6143 fix: add loading state to tab elements (#415) 2021-10-11 22:50:04 +02:00
Ivar Conradi Østhus
a6f2c332f8 fix: show feature toggle type in list (#418)
We should show the feature toggle type in all list of toggles.

Also cleaned up mobile view.
2021-10-11 22:45:59 +02:00
Youssef Khedher
338c74e955 Merge branch 'master' into feat/API-token-improvement 2021-10-08 14:51:22 +01:00