https://linear.app/unleash/issue/2-563/fix-issue-with-useconditionallyhiddencolumns-and-react-table
It seems like we should add `autoResetHiddenColumns: false` to
`useTable` whenever we use `useConditionallyHiddenColumns`.
Basically the thought is that, if we're controlling column visibility in
our own way, we should not want other things to change that state
unpredictably, otherwise this may make React go _brrrrrr_. And it can be
very hard to pinpoint what exactly may be causing React to go _brrrrrr_.
First detected this issue apparently randomly while developing the new
SA table. Around 10-20 page refreshes would eventually trigger it. Was
not easy to find, but hopefully this fixes it permanently. At least I
haven't been able to reproduce it since. Maybe someone has a better idea
of where the issue could be or if this is a pretty good guess. Doesn't
seem like this change hurts us anyways.
I love React, `useEffect` and these very to-the-point error messages.
Very fun and productive.
Reference: https://react-table-v7.tanstack.com/docs/api/useTable
<!-- Thanks for creating a PR! To make it easier for reviewers and
everyone else to understand what your changes relate to, please add some
relevant content to the headings below. Feel free to ignore or delete
sections that you don't think are relevant. Thank you! ❤️ -->
Virtualise the Users' table
## About the changes
<!-- Describe the changes introduced. What are they and why are they
being introduced? Feel free to also add screenshots or steps to view the
changes if they're visual. -->
<!-- Does it close an issue? Multiple? -->
Closes #
<!-- (For internal contributors): Does it relate to an issue on public
roadmap? -->
<!--
Relates to [roadmap](https://github.com/orgs/Unleash/projects/10) item:
#
-->
### Important files
<!-- PRs can contain a lot of changes, but not all changes are equally
important. Where should a reviewer start looking to get an overview of
the changes? Are any files particularly important? -->
## Discussion points
<!-- Anything about the PR you'd like to discuss before it gets merged?
Got any questions or doubts? -->
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
* feat: new user dropdown and profile page
* fix: add popup boxShadow to dark-theme
* fix: update routes snap
* refactor: move some tab specific logic into tabs component
* add useProfile hook example
* fix profile tab header (no name)
* fix: hide user popup when clicking profile link
* - add PATs to profile;
- add route logic to profile;
- refactor TimeAgoCell title;
- misc fixes and refactoring;
* add profile info to profile tab
* simplify req paths
* add PAT flag to the front-end
* fix: some UI adjustments
* change user popup buttons to links
* fix profile on front-end, add role description
* update delete PAT text
* address some PR comments
* address PR comments
* some more UI fixes and refactoring
* move password request to API hook
* refactor: user creation screen cleanup
* feat: deprecation notice for google sso
* fix: docs openid typo
* invite link bar
* invite link page
* fix prettier docs
* regenerated openapi
* hooks for invite page api
* update openapi
* feat: invite link update
* feat: add public signup token soft-delete
* public signup frontend feature flag
* fix: new user api issues
* feat: allow for creating new user from invite link
* Feat/invite user public controller (#2106)
* added PublicInviteController for public urls
* added PublicInviteController for public urls
* added PublicInviteController for public urls
* added PublicInviteController for public urls
* fix test
* fix test
* update openapi
* refactor: password reset props
* fix: public invite schema and validation
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
* user invite frontend
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
* invite link delete confirmation dialog
* refactor: password reset action
* fix: new user invite loading state
* fix: run ts check with ci
* revert openapi changes
* fix: invite token api interface
* fix: openapi schema index
* fix: update test snapshots
* update frontend snapshot
* fix: prettier ci
* fix: updates after review
Co-authored-by: andreas-unleash <104830839+andreas-unleash@users.noreply.github.com>
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
* feat: upgrade project list search to use the new search field
* cleanup unused imports
* feat: add upgraded search to projects and applications, polish search UX
* refactor: TableSearch to new Search common component
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
* feat: add last seen col to admin users list
* fix: header hover effect, duplicate title from TimeAgo
* fix: use YMD format, never logged
* fix: small tooltip change
* refactor: adapt to review suggestions
* add user sort and filter hooks, adapt table to match design
* refactor: abstract away TableActions and TableCellSortable into components, small fixes and improvements
* feat: implement search
* feat: add search word highlighter to match design
* refactor: small UI/UX improvements
* fix: rounded corners for th on responsive breakpoints
* refactor: small UI/UX improvements
* Update src/hooks/useUsersSort.ts
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
* refactor: clearer arg name in users filter
* refactor: specify transition properties
* refactor: add theme v2 properties and cleanup styles
* refactor: create lightweight highlighter component
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
* refactor: remove unused securityLogger
* refactor: port commonStyles to TS
* refactor: port testIds to TS
* refactor: move app.css into themes
* refactor: use absolute import paths
* refactor: port LayoutPicker to TS
* refactor: port routes to TS
* refactor: port ScrollTop to TS
* refactor: update unused/missing ScrollTop exceptions
* refactor: remove unused route flags field
* refactor: change constants ext to TS
* refactor: remove unused testData file
* refactor: port styles to TS
* refactor: wait before typing in auth spec
* refactor: keep feature toggle name when changing project
* refactor: add missing permission button tooltip
* refactor: add success toast on toggle revival
* refactor: add success toast on stale toggle
* refactor: fix initial user role checkbox value
* refactor: remove duplicated error message
* refactor: fix change-password error parsing
* refactor: remove inaccurate edit toggle toast text
* refactor: truncate long names in project cards
* refactor: truncate long project name in title
* refactor: add ellipses to truncated strings
* refactor: swap truncateString with StringTruncator
* refactor: remove unnecessary truncation
* refactor: mark context fields as optional
* refactor: show all errors from tag type creation
* refactor: show all errors from strategy create/update
* refactor: filter out empty strategies on create/update
* refactor: add an edit button to the addons list
* refactor: add missing labels
* refactor: catch errors from toggling stale features
* refactor: add ref support to PermissionSwitch
* refactor: port global settings to TS/hooks
* refactor: fix file extension
* refactor: format file
* refactor: fix inconsistent locationSettings prop
* refactor: use correct locationSettings hook
* refactor: use objects for settings hooks
* feat: add edit and create user screen
* refactor: rename create user component
* fix: add missing documentation link
* fix: remove unused dependencies
* feat: add confirm screen
* refactor: change UserForm and delete unused components
* refactor: remove toast when create new user
* fix: add margin top to form elements
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
