Thomas Heartman
90915cfdd7
Chore: add strategy sorting algorithm ( #5406 )
...
This PR adds a strategy sorting algorithm to be used for the segment
deletion dialog. It assumes that you have a list of existing strategies
and a list of change request strategies. Based on the content of these
two lists, it will create one unified list sorted after a number of
criteria (as listed in the test).
# Discussion point:
This impl does the sorting on the front end, but could we do it on the
back end? Instead of adding a new property to the segment data, could we
simply fold the change request strategies in with the existing segment
strategies and return it using the old property? If the only place we do
that is in this view, then that might be a good suggestion.
Response:
I'll leave this in the front end for now. The reason is that we can't add change request strategies to the existing `strategies` property of the API payload without it being a breaking change. The OpenAPI schema says that `id` is a required field on a strategy, and that field doesn't exist on strategies that have only been added in change requests, but not yet applied.
2023-11-27 11:23:10 +01:00
Nuno Góis
4167a60588
feat: biome lint frontend ( #4903 )
...
Follows up on https://github.com/Unleash/unleash/pull/4853 to add Biome
to the frontend as well.
Added a few `biome-ignore` to speed up the process but we may want to
check and fix them in the future.
2023-10-02 13:25:46 +01:00
Fredrik Strand Oseberg
94c90b7731
Refactor/make styles batch 6 part 3 ( #2823 )
...
Last set of components refactoring for batch 6
2023-01-05 09:45:17 +01:00
Tymoteusz Czech
f2eb96000e
fix: segment delete confirmation double dialog flash ( #2819 )
2023-01-04 15:58:30 +01:00
Nuno Góis
fe2f2f5705
Update dialogue design ( #2342 )
...
https://linear.app/unleash/issue/2-509/update-dialogues-to-match-new-designs
Update dialogues to match the look on the new designs:
2022-12-14 15:16:58 +00:00
olav
504a4af274
refactor: port segments list to react-table ( #1024 )
...
* refactor: extract SegmentEmpty component
* refactor: extract CreateSegmentButton component
* refactor: extract EditSegmentButton component
* refactor: extract RemoveSegmentButton component
* refactor: normalize Created table header text
* refactor: port segments list to react-table
* fix: improve row text height in table row
* fix: update test snapshots
* refactor table cell with search highlight
* fix: update after review
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
Co-authored-by: Tymoteusz Czech <tymek+gpg@getunleash.ai>
2022-05-27 08:57:30 +02:00
olav
24c11332b5
chore: update MUI to v5 ( #923 )
...
* refactor: update mui packages
* refactor: run mui codemods
* refactor: format files after codemods
* refactor: fix broken types
* refactor: clean up theme
* refactor: fix broken tests
* refactor: replace @mui/styles with tss-react
* refactor: move breakpoints into classes for tss
* refactor: fix crash on missing feature description
* refactor: remove void classNames
* refactor: adjust styles to new defaults
* refactor: remove broken rollout slider e2e test
* refactor: fix duplicate e2e testid
* refactor: update makeStyles after rebase
* refactor: add missing snapshot after rebase
* refactor: fix TableCellSortable focus styles
* refactor: use 1.4 as the default line-height
* refactor: hide webkit search field icons
* refactor: fix select box label
* refactor: make AutocompleteBox smaller
* refactor: make heading smaller
* refactor: fix toast close icon color
* refactor: update snapshots
* refactor: add missing test event awaits
* refactor: fix default button line-height
2022-05-02 15:52:41 +02:00
Tymoteusz Czech
23a874d051
Refactor: convert jsx files to typescript ( #881 )
...
* refactor: convert remaining js files to typescript
* refactor: conditionally render remove index
* refactor: dialog component to tsx
* refactor: migrate some files from jsx to tsx
* refactor: convert dropdown element to tsx
* refactor: feature toggle list to tsx
* refactor: update context name in use overrides
* refactor: variant overrides to tsx
refactor: remove unused strategy constraint file
* fix: tsx imports
* fix: update refectored components after rebase
* refactor: rename report list files to tsx
* fix: project health list types
* refactor: addon form - add types
* refactor: copy feature component types
* fix: projects toggle style after tsx refactor
* refactor: update ts types from openapi
* fix: ts refactor changes after review
* fix: header title prop
* fix: update after PR comments
* add test to useoverrides hook
* fix conditionally render time ago
* fix: toggle list empty tooltip
* fix: remove unused variable
* remove unused variable
* fix: remove faulty snapshot
2022-05-02 12:52:33 +02:00
olav
49b8e7329e
refactor: convert auth tests from Cypress to Jest ( #864 )
...
* refactor: replace data-test with data-testid
* refactor: add Jest tests for auth pages
* refactor: remove Cypress tests for auth pages
* refactor: remove questionable snapshots
* refactor: share test server setup/teardown
* refactor: restore auth page flex layout
* refactor: use toBeInTheDocument
* refactor: change recent data-test attrs to data-testid
2022-04-08 13:13:45 +02:00
Nuno Góis
1132a79f6d
fix: reject duplicate segment names ( #855 )
...
* fix: reject duplicate segment names
* fix: useSegmentValidation now takes into account initial value
* refactor: add segments e2e test
* refactor: add github action from segments e2e test
* refactor: use enterprise edition for all e2e tests
* refactor: use enterprise edition for all e2e tests
2022-04-08 11:34:59 +01:00
olav
43834be065
refactor: use onClose instead of hideSecondaryButton ( #842 )
2022-04-05 11:47:17 +02:00
Youssef Khedher
eeda7ab5e4
feat: add segments ( #780 )
...
* feat: create segmentation structure and list
* feat: remove unused deps and change route
* feat: change header style and add renderNoSegments
* fix: style table header
* feat: create useSegments hook
* feat: add segmentApi hook
* feat: create segment
* fix: errors
* feat: add contextfields list
* fix: remove user from create segment api
* feat: add form structure
* feat: add SegmentFormStepOne
* fix: tests and routes
* feat: add constraint view
* feat: UI to match the sketch
* feat: add constraint on context select
* fix: duplication
* fix adding constraints
Co-authored-by: olav <mail@olav.io>
* fix: input date not showing up in constraint view
Co-authored-by: olav <mail@olav.io>
* fix: minor bugs
Co-authored-by: olav <mail@olav.io>
* fix: create context modal in segment page
Co-authored-by: olav <mail@olav.io>
* fix: validate constraint before create segment
Co-authored-by: olav <mail@olav.io>
* feat: create useSegment hook
Co-authored-by: olav <mail@olav.io>
* feat: create edit component
Co-authored-by: olav <mail@olav.io>
* refactor: move constraint validation endpoint
* refactor: add missing route snapshot
* refactor: fix segment constraints unsaved/editing state
* refactor: remove create segment from mobile header menu
* refactor: update segments form description
* refactor: extract SegmentFormStepList component
* refactor: add an optional FormTemplate docs link label
* refactor: fix update segment payload
* feat: finish edit component
Co-authored-by: olav <mail@olav.io>
* refactor: move step list above segment form
* fix: update PR based on feedback
Co-authored-by: olav <mail@olav.io>
* refactor: fix constraint validation endpoint path
* refactor: improve constraint state field name
* refactor: extract AutocompleteBox component
* feat: add strategy segment selection
* refactor: add strategy segment previews
* refactor: fix double section separator line
* feat: disable deleting a usable segment
* refactor: warn about segments without constraints
* refactor: update text in delete segment dialogue
* refactur: improve arg names
* refactor: improve index var name
* refactor: clarify steps list logic
* refactor: use a required prop for the segment name
* refactor: use ConditionallyRender for segment deletion
* refactor: fix segments refetch
* refactor: improve CreateUnleashContext component names
* refactor: adjust segment form styles
* refactor: adjust text
* refactor: fix info icon tooltip hover target
* refactor: add missing aria attrs to preview button
* refactor: add strat name to delete segment modal
* refactor: fix segment chip text alighment
* refactor: use bulk endpoint for strategy segments
* refactor: fix imports after merge
Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
Co-authored-by: olav <mail@olav.io>
2022-03-29 09:30:57 +02:00
