4 Commits

Author	SHA1	Message	Date
Gastón Fournier	2e749a2b3e	docs: better comment in strictNullCheck action (#3198) ... ## About the changes This is a small improvement adding more context to the comment message when this action fails. --------- Co-authored-by: Thomas Heartman <thomas@getunleash.ai>	2023-02-27 12:06:09 +00:00
Gastón Fournier	4d26088603	chore: comment outcome of null check action (#3133) ... ## About the change Post a comment in the Pull Request rather than echo in the console in case of an error. Also, [reduced the null check errors by 26](https://github.com/Unleash/unleash/actions/runs/4196924954/jobs/7278564622#step:5:40)	2023-02-17 11:12:46 +01:00
Gastón Fournier	95d300379a	chore: moved GH action script to the yaml file (#3119) ... ## About the changes - Actions are not counting successfully: https://github.com/Unleash/unleash/actions/runs/4181713524/jobs/7243938807#step:5:17 - This should fix an issue with running yarn concurrently (which might be leading to the zero counts) - Move the code to a GH action so it's easier to debug - Added a diff of the reported errors to help the PR author identify the potential cause	2023-02-16 13:35:54 +01:00
Gastón Fournier	7aed1e0d13	chore: gradually reduce null-check errors (#3094) ... ## About the changes In order to move us towards enabling `strictNullChecks` we'd want to have a way of gradually enabling this without having to fix all errors at once, this will force us to start reducing the number of null check issues. This new workflow: 1. [Checks out the current branch and main into 2 different folders](https://github.com/Unleash/unleash/pull/3094/files#diff-068f2ace1d1d2e773fb5e4240c83ccab251556fd5524fe13847122878e40da3bR15-R23) 2. Uses the **same** script `gradual-strict-null-checks.sh` (from the current branch) [against each folder in parallel](https://github.com/Unleash/unleash/pull/3094/files#diff-068f2ace1d1d2e773fb5e4240c83ccab251556fd5524fe13847122878e40da3bR34-R38) to count the number of errors if `strictNullChecks` was enabled 3. If the number of potential errors in the current branch is higher than the number of potential errors in main [it fails](https://github.com/Unleash/unleash/pull/3094/files#diff-068f2ace1d1d2e773fb5e4240c83ccab251556fd5524fe13847122878e40da3bR41-R46) As an example, a [new issue was introduced in this PR](753f57223c) (and then [reverted](e4deb62965)), so we can test the build failure: https://github.com/Unleash/unleash/actions/runs/4163632636/jobs/7204268519#step:5:10 ## Discussion points This could be a non-mandatory check, just advising, or even adding a comment in the PR. It might be good to start with a non-strict check, but at the same time we can decide to make it non-strict if a problem appears In some situations, an additional null check error might require us to fix a bunch of them, increasing the time to deliver. In these cases we can suppress an individual line with `// @ts-ignore: Object is possibly 'null'.` although might defeat the purpose of this workflow	2023-02-14 15:52:21 +01:00