Christopher Kolstad
53354224fc
chore: Bump biome and configure husky ( #6589 )
...
Upgrades biome to 1.6.1, and updates husky pre-commit hook.
Most changes here are making type imports explicit.
2024-03-18 13:58:05 +01:00
Thomas Heartman
a8fa1ae347
fix: hide warnings that you'll overwrite changes on CRs that are already applied ( #6214 )
...
The current approach uses adds an extra parameter to the components and
passes it through from the parent components. It's never a lot of
levels, so it feels alright, but it's feels like a bit of a code smell.
I wonder if it would make sense to use a context for each change
request? 🤔
Supersedes: https://github.com/Unleash/unleash/pull/6181
2024-02-16 12:41:14 +08:00
Thomas Heartman
64a6af2858
feat: show info on what would be deleted ( #6235 )
...
This PR updates the way we show deleted strategies in the CR UI. Instead
of showing just the strategy name and a diff on hover, we show the same
strategy config as we do for new and updated strategies.
This makes it easier to see what you have deleted.
In doing so, it also fixes two issues:
1. inconsistent border radius for segment changes listed. Due to an
override in `frontend/src/themes/theme.ts`, these would get a border
radius of `theme.shape.borderRadiusLarge` instead of
`theme.shape.borderRadiusMedium`. It does this by adding a class and
making the selector more specific.
2. The background was unset for the strategy rollout box and constraint
item boxes.
It looks like this:
<img width="728" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/7cba28ac-0454-444d-8cfa-f46543ccf2dc ">
<img width="728" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/832be653-3def-4afc-b72f-36fcd76ad83d ">
Or with more kinds of strategies:
<img width="454" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/f18e5482-7d2e-4cbd-8177-9de6dfb10307 ">
Note: I'm happy to isolate the color changes to a separate PR if that's
preferable.
2024-02-16 04:13:40 +00:00
Thomas Heartman
b77f3129f2
feat: show segment conflicts in crs ( #6138 )
...
This PR updates the diff calculation to work with both strategy changes
and segment changes. It also adds the corresponding segment change
conflict overview to segment updates.
<img width="1225" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/688a57a5-5cd7-4b0a-bd1e-df63189594d8 ">
2024-02-09 16:25:01 +09:00
Thomas Heartman
0bb709a718
feat: show changes that would be overwritten in change request overview UI ( #5964 )
...
This PR adds a first, rough iteration of what it could look like to show
changes that would be overwritten by applying a PR.
The changes are listed in a table (semantically; looks more like a list
visually) and show the property, the current live value and the version
that you have in your changes. The changes are hidden by default, but
can be shown by expanding a details element.
@nicolaesocaciu Suggested that we merge this version for now and iterate
on the design later.
Here's what it looks like closed:
Here's what it looks like with a typical change load:
Here's what it looks like if you change more or less every property
changed:
2024-01-22 11:13:38 +04:00
andreas-unleash
e0f83347ab
fix: hide variant diff if no change in ChangeRequestOverview ( #5715 )
...
Closes #
[1-1813](https://linear.app/unleash/issue/1-1813/do-not-show-variants-table-in-change-request-when-no-variant-change )
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-12-21 10:39:18 +02:00
andreas-unleash
8ffc92af5b
fix: Only show strategy variant changes if there is a diff in the variants ( #5353 )
...
What it says on the box
Closes #
[1-1652](https://linear.app/unleash/issue/1-1652/remove-the-variants-from-change-request-page-when-not-modified )
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-22 09:50:03 +02:00
Nuno Góis
4167a60588
feat: biome lint frontend ( #4903 )
...
Follows up on https://github.com/Unleash/unleash/pull/4853 to add Biome
to the frontend as well.
Added a few `biome-ignore` to speed up the process but we may want to
check and fix them in the future.
2023-10-02 13:25:46 +01:00
Fredrik Strand Oseberg
d3e01d84d9
fix: account for array length ( #4849 )
...
Small fix to account for array length in conditional check
2023-09-27 15:12:01 +02:00
Fredrik Strand Oseberg
cefbf01934
feat: visualize feature variants on cr ( #4809 )
...
Adds a view over feature strategy variants on addStrategy or
editStrategy action
2023-09-22 16:17:41 +02:00
Jaanus Sellin
b2aa3ea049
feat: change request ui updates ( #4574 )
2023-08-27 20:35:27 +03:00
Jaanus Sellin
c1314a8ee8
feat: delete segment from CR ( #4469 )
2023-08-10 15:56:15 +03:00
Tymoteusz Czech
0cb6174f75
Fix/strategy UI improvements ( #3766 )
...
https://linear.app/unleash/issue/1-889/ui-adjustments
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: andreas-unleash <andreas@getunleash.ai>
2023-05-16 11:15:59 +00:00
Tymoteusz Czech
3bb09c5ce4
Disable and enable strategies - frontend ( #3582 )
...
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: andreas-unleash <andreas@getunleash.ai>
2023-04-26 11:41:24 +02:00
Fredrik Strand Oseberg
cef4181f11
Fix/cr UI fixes ( #2675 )
...
This PR contains multiple UI fixes for the change request. It changes
font sizes, icon colors, margins and paddings to be more consistent.
2022-12-12 16:32:38 +01:00
Mateusz Kwasniewski
2107834768
hide discard for nonauthors ( #2634 )
2022-12-08 13:24:15 +01:00
