Simon Hornby
f16f8594f5
chore: deprecate custom strategies ( #7186 )
2024-05-28 12:33:53 +02:00
Christopher Kolstad
53354224fc
chore: Bump biome and configure husky ( #6589 )
...
Upgrades biome to 1.6.1, and updates husky pre-commit hook.
Most changes here are making type imports explicit.
2024-03-18 13:58:05 +01:00
Fredrik Strand Oseberg
f381718fd6
fix: icon imports ( #6499 )
...
Based on this article:
https://mui.com/material-ui/guides/minimizing-bundle-size/ importing
from `'@mui/icons-material'` instead of specifying the actual path to
the icon like `import Delete from '@mui/icons-material/Delete';` can be
up to six time slower. This change changes all named imports in Unleash
referencing the `@mui/icons-material` to default imports.
This reduced the amount of modules we had to process when building the
frontend from 15206 to 4746
Before:
<img width="1016" alt="Skjermbilde 2024-03-11 kl 14 19 58"
src="https://github.com/Unleash/unleash/assets/16081982/f137d24a-6557-4183-a40f-f62a33524520 ">
After:
<img width="1237" alt="Skjermbilde 2024-03-11 kl 14 20 32"
src="https://github.com/Unleash/unleash/assets/16081982/05a27d6a-2c3f-4409-9862-7188ab4b9c72 ">
Build time locally decreased by around 50%
Before:
<img width="1504" alt="Skjermbilde 2024-03-11 kl 14 31 45"
src="https://github.com/Unleash/unleash/assets/16081982/bc931559-b022-47ed-9f8f-c87401578518 ">
After:
<img width="1219" alt="Skjermbilde 2024-03-11 kl 14 27 00"
src="https://github.com/Unleash/unleash/assets/16081982/3c3a8d6b-576d-45c3-aa40-cc5f95d9df2b ">
2024-03-12 10:56:10 +01:00
Mateusz Kwasniewski
156ba39b42
fix: strategy screen re-rendering table bug ( #6006 )
2024-01-23 15:49:13 +01:00
Christopher Kolstad
5a3bb1ffc3
Biome1.5.1 ( #5867 )
...
Lots of work here, mostly because I didn't want to turn off the
`noImplicitAnyLet` lint. This PR tries its best to type all the untyped
lets biome complained about (Don't ask me how many hours that took or
how many lints that was >200...), which in the future will force test
authors to actually type their global variables setup in `beforeAll`.
---------
Co-authored-by: Gastón Fournier <gaston@getunleash.io>
2024-01-12 09:25:59 +00:00
Nuno Góis
4167a60588
feat: biome lint frontend ( #4903 )
...
Follows up on https://github.com/Unleash/unleash/pull/4853 to add Biome
to the frontend as well.
Added a few `biome-ignore` to speed up the process but we may want to
check and fix them in the future.
2023-10-02 13:25:46 +01:00
Jaanus Sellin
b91b7276c5
feat: split strategies table into two with new design ( #3969 )
2023-06-14 09:10:04 +03:00
Jaanus Sellin
41370be591
feat: update predefined strategies tooltip ( #3964 )
2023-06-14 08:46:15 +03:00
Tymoteusz Czech
40185e9066
Update strategies table ( #3811 )
...
- split strategies table in two
- one for predefined strategies
- one for custom strategies
- move custom strategy button
- add guidance why custom strategies are not recommended
https://linear.app/unleash/issue/1-894/improve-the-list-of-strategies
2023-05-22 12:46:27 +02:00
Gastón Fournier
4dd4d43cce
chore: remove deprecated strategies and allow deprecate default ( #3575 )
...
## About the changes
Improvements around strategies to steer users toward using [strategy
constraints](https://docs.getunleash.io/reference/strategy-constraints )
instead of [custom
strategies](https://docs.getunleash.io/reference/custom-activation-strategies )
Related to #1265
Important changes:
1.[ Ability to deprecate default
strategy](https://github.com/Unleash/unleash/pull/3575/files#diff-3b49e566565b01580ff7a15f662d2cb824547fdfb3935d0a0baa7fae326d28d6L232-L235 )
2. [Remove strategies that were deprecated in v4 only if they're not
used](https://github.com/Unleash/unleash/pull/3575/files#diff-a04de7adf327c48d54b030bed70d9b1d62ff14df3efc668eb6897a210124ebe0R7-R10 )
3. [Fresh Unleash installations will not include deprecated strategies
from
v4](https://github.com/Unleash/unleash/pull/3575/files#diff-46265b0d51725a5acbf251589b98a8970e45d3a1c6f3d7ea77bdcc3714e672d8L31-L78 )
4. [Deprecate userWithId
strategy](https://github.com/Unleash/unleash/pull/3575/files#diff-a04de7adf327c48d54b030bed70d9b1d62ff14df3efc668eb6897a210124ebe0R13 )
(note: if in use it will continue to work, it'll be not listed when
selecting strategies for a feature toggle).
5. [Switch the order of strategies to make gradual rollout first and
change the comment to suggest using gradual rollout instead of other
existing
strategies](https://github.com/Unleash/unleash/pull/3575/files#diff-a04de7adf327c48d54b030bed70d9b1d62ff14df3efc668eb6897a210124ebe0R16-R18 )
2023-04-21 11:42:36 +02:00
Nuno Góis
e53d40c588
fix: strategy name sort ( #2130 )
2022-10-04 10:41:43 +01:00
Christopher Kolstad
5d8678618e
feat: add count for strategy types list ( #2021 )
2022-08-31 15:21:09 +02:00
olav
4d283f953d
refactor: rename Strategies to Strategy types on the frontend ( #1990 )
2022-08-30 09:21:31 +02:00
Nuno Góis
df6208e309
feat: add user groups ( #1130 )
...
* feat: add user groups table
* add groups and group view
* fix top level await on mock data
* add UG flag
* create group files, refactor group cards
* add generic badge component
* adapt hooks to use endpoints
* implement basic create group
* fix: update snap
* fix: type id as string for now
* implement create group, use api, refactoring
* add stars to group owners
* refactor GroupForm.tsx to use styled components
* feat: remove group
* add edit group
* add group card actions
* feat: edit and remove group users
* add users to groups
* Initial commit
* refine project access table
* add project access group view
* Take users and groups from backend
* Add onsubmit
* new project access, assign and edit
* fix EditGroup, Group
* Finish assigning roles in project
* List assigned projects in group card
* Run prettier
* Add added column to project access table
Co-authored-by: Jaanus Sellin <jaanus@getunleash.ai>
Co-authored-by: sighphyre <liquidwicked64@gmail.com>
2022-07-22 07:31:08 +00:00
Tymoteusz Czech
51e5939f68
feat: Align switches in table actions ( #1082 )
...
* feat: strateges state changing switch
* refactor: ActionCell for table
* fix: remove image clipping for webhook icons
* feat: align addons switch in table
* feat: align enviromnemnts table switch
* fix: disallow turning off protected environment
* refactor: move environment table sub-components
* feat: add predefined badge to default environment
* feat: environment reorder handle hightlight
* fix: environment table padding when searching
* Update src/hooks/api/actions/useStrategiesApi/useStrategiesApi.ts
Co-authored-by: olav <mail@olav.io>
* refactor: toggle addon promise
* remove dragging highlight
* fix: strategy switch tooltip
* fix: switch tooltips
Co-authored-by: olav <mail@olav.io>
2022-06-14 12:32:16 +00:00
Nuno Góis
4761847ce5
feat: upgrade search to use the new search component ( #1073 )
...
* feat: upgrade project list search to use the new search field
* cleanup unused imports
* feat: add upgraded search to projects and applications, polish search UX
* refactor: TableSearch to new Search common component
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2022-06-10 15:23:12 +02:00
Nuno Góis
570e9f88be
feat: upgrade users table ( #1040 )
...
* feat: upgrade users table
* fix misc ui/ux bugs
* refactor: address PR comments
* fix: searching by `undefined`
* fix: searching for undefined on invoices, table placeholder centering
* refactor: abstract users list actions into new component
* refactor: move styled components to top of files
2022-05-31 07:59:09 +01:00
olav
20d738f725
refactor: add eslint to merge check ( #1022 )
...
* refactor: fix eslint issues
* refactor: add eslint to merge check
2022-05-25 12:36:58 +02:00
olav
91a825792e
refactor: normalize status badge designs ( #1018 )
2022-05-25 08:30:47 +00:00
Fredrik Strand Oseberg
7ba9d2a577
Feat/new strategies table ( #1012 )
...
* fix: add flex to toolbarcontainer
* feat: add initial new table
* feat: add styled badge
* feat: remove dead code
* fix: remove useContext import
* fix: update context buttons to icon buttons
* feat: add loading
* fix: remove unused imports
* Update src/component/strategies/StrategiesList/PredefinedBadge/PredefinedBadge.tsx
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
* fix: update spacing to use theme
* fix: update loading
* fix: update type
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
2022-05-24 10:58:06 +02:00
Tymoteusz Czech
6d130f61f6
feat: new contexts table ( #998 )
...
* feat: new contexts table
* improve context list actions
* refactor: disabled icon colors
* fix: update snapshots
* fix: icons
* fix: context fields typo
2022-05-20 08:29:23 +00:00
olav
9902494f58
refactor: improve tooltip styles after MUI update ( #966 )
...
* refactor: add missing event arg type
* refactor: fix project card popup position
* refactor: add tooltip arrows
* refactor: update snapshot
* refactor: add missing tooltips
* refactor: use a custom Autocomplete size in AutocompleteBox
2022-05-09 15:17:20 +02:00
Tymoteusz Czech
44c579f7a8
Refactor: page container ( #967 )
...
* refactor: page container
* refactor: table page header
2022-05-09 14:38:12 +02:00
olav
d8143c6ff4
chore: update react-router to v6 ( #946 )
...
* refactor: fix child selector warnings
* refactor: update react-router-dom
* refactor: use BrowserRouter as in react-router docs
* refactor: replace Redirect with Navigate
* refactor: replace Switch with Routes
* refactor: replace useHistory with useNavigate
* refactor: replace useParams types with useRequiredPathParam
* refactor: replace NavLink activeStyle with callback
* refactor: fix matchPath arg order
* refactor: Remove unused link state
* refactor: delete broken snapshot test
* refactor: render 404 page without redirect
* refactor: normalize path parameter names
* refactor: fix Route component usage
2022-05-05 13:42:18 +02:00
olav
35262e404b
refactor: clean up strategy parameter types ( #944 )
...
* refactor: fix splash page button background color
* refactor: regenerate OpenAPI client
* refactor: clean up strategy parameter types
* refactor: remove index signature from IConstraint
* refactor: fix never-seen status in features list
2022-05-04 15:16:34 +02:00
olav
24c11332b5
chore: update MUI to v5 ( #923 )
...
* refactor: update mui packages
* refactor: run mui codemods
* refactor: format files after codemods
* refactor: fix broken types
* refactor: clean up theme
* refactor: fix broken tests
* refactor: replace @mui/styles with tss-react
* refactor: move breakpoints into classes for tss
* refactor: fix crash on missing feature description
* refactor: remove void classNames
* refactor: adjust styles to new defaults
* refactor: remove broken rollout slider e2e test
* refactor: fix duplicate e2e testid
* refactor: update makeStyles after rebase
* refactor: add missing snapshot after rebase
* refactor: fix TableCellSortable focus styles
* refactor: use 1.4 as the default line-height
* refactor: hide webkit search field icons
* refactor: fix select box label
* refactor: make AutocompleteBox smaller
* refactor: make heading smaller
* refactor: fix toast close icon color
* refactor: update snapshots
* refactor: add missing test event awaits
* refactor: fix default button line-height
2022-05-02 15:52:41 +02:00
Tymoteusz Czech
23a874d051
Refactor: convert jsx files to typescript ( #881 )
...
* refactor: convert remaining js files to typescript
* refactor: conditionally render remove index
* refactor: dialog component to tsx
* refactor: migrate some files from jsx to tsx
* refactor: convert dropdown element to tsx
* refactor: feature toggle list to tsx
* refactor: update context name in use overrides
* refactor: variant overrides to tsx
refactor: remove unused strategy constraint file
* fix: tsx imports
* fix: update refectored components after rebase
* refactor: rename report list files to tsx
* fix: project health list types
* refactor: addon form - add types
* refactor: copy feature component types
* fix: projects toggle style after tsx refactor
* refactor: update ts types from openapi
* fix: ts refactor changes after review
* fix: header title prop
* fix: update after PR comments
* add test to useoverrides hook
* fix conditionally render time ago
* fix: toggle list empty tooltip
* fix: remove unused variable
* remove unused variable
* fix: remove faulty snapshot
2022-05-02 12:52:33 +02:00
olav
2e5e25bfe5
refactor: improve icon labels and tooltips ( #884 )
2022-04-21 08:26:49 +02:00
olav
49b8e7329e
refactor: convert auth tests from Cypress to Jest ( #864 )
...
* refactor: replace data-test with data-testid
* refactor: add Jest tests for auth pages
* refactor: remove Cypress tests for auth pages
* refactor: remove questionable snapshots
* refactor: share test server setup/teardown
* refactor: restore auth page flex layout
* refactor: use toBeInTheDocument
* refactor: change recent data-test attrs to data-testid
2022-04-08 13:13:45 +02:00
olav
f309553a5f
refactor: port some things to TS ( #833 )
...
* refactor: remove unused securityLogger
* refactor: port commonStyles to TS
* refactor: port testIds to TS
* refactor: move app.css into themes
* refactor: use absolute import paths
* refactor: port LayoutPicker to TS
* refactor: port routes to TS
* refactor: port ScrollTop to TS
* refactor: update unused/missing ScrollTop exceptions
* refactor: remove unused route flags field
* refactor: change constants ext to TS
* refactor: remove unused testData file
* refactor: port styles to TS
* refactor: wait before typing in auth spec
2022-04-01 10:28:15 +02:00
Youssef Khedher
85950f104a
chore: update paths 🧼 ( #820 )
2022-03-28 09:49:59 +01:00
olav
cfc2338e78
refactor: use camel case for files and dirs ( #817 )
2022-03-25 12:34:20 +01:00
olav
a16520ddda
refactor: fix Tooltip ref warning ( #804 )
...
* refactor: fix Tooltip ref warning
* refactor: add missing button labels
2022-03-23 09:12:10 +01:00
olav
baae88c7a5
feat: add new feature strategy create/edit pages ( #739 )
...
* refactor: add param helper hooks
* refactor: remove first add strategy link
* refactor: add more types to useStrategies
* refactor: port strategy utils to TS
* refactor: replace rollout strategy icon
* refactor: use a named export for useFeature
* refactor: add more types to useFeature
* refactor: adjust code box styles
* refactor: add missing PermissionButton variant prop
* refactor: add missing button icon label
* refactor: move common feature components
* refactor: fix StrategyConstraints error prop types
* refactor: fix GeneralStrategy prop types
* feat: add new feature strategy create/edit pages
* refactor: remove feature strategies page
* refactor: fix types in GeneralStrategy
* refactor: use ConstraintAccordion on the new pages
* refactor: use ConditionallyRender for remove button
* refactor: rename FeatureStrategyForm component
* refactor: use the Edit icon for feature strategies
* refactor: fix initial edit mode for new constraints
* refactor: add FeatureStrategyMenu to closed accordions
* refactor: allow editing multiple constraints
* refactor: show single-valued constraint value
* refactor: increase feature overview strategy width
* refactor: add remove button to feature overview strategies
* refactor: move createEmptyConstraint to own file
* refactor: disable submit button for invalid constraints
* refactor: fix nested paragraphs on the metrics page
* refactor: move create/edit feature strategy to modal
* refactor: always open new constraints in edit mode
* refactor: use a PermissionButton for the save button
* refactor: remvoe unsaved constraints on cancel
* refactor: clarify useConstraintsValidation logic
* refactor: remove unused strategy descriptions
* refactor: restore Rollout icon
* refactor: remove sidebar modal slide animation
* refactor: avoid constraint accordion toggle on edit/delete
* refactor: truncate long strategy names
* refactor: find the correct remove button
2022-03-09 14:59:24 +01:00
olav
ab4efe0837
refactor: remove unused tooltip prop ( #769 )
...
* refactor: remove unused tooltip prop
* refactor: fix PermissionButton base props
* refactor: sync yarn.lock
* refactor: fix unused ts-expect-error
2022-03-09 10:13:50 +01:00
Youssef Khedher
ee730e0708
Feat/custom strategy screen ( #722 )
...
* feat: setup new screen structure
* refactor: strategyParameter
* feat: add strategy input errors for required fields
* feat: add create strategy to routes
* feat: add EditStrategy component
* feat: edit strategy view and EditStrategy component
* feat: update EditStrategy component
* test: update snapshots
* fix: styles
* test: update snapshots
* refactor: rename StrategyForm and fix ts errors
* test: update snapshots
* fix: remove test route
* fix: update PR based on feedback
* fix: update PR based on feedback
* refactor: restore feature settings (#712 )
* refactor: resotre feature settings
* fix: update PR based on feedback
* feat: add feature information in Metadata container
* fix: update PR based on feedback
* fix: update PR based on feedback
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
* chore(deps): update dependency @types/react-dom to v17.0.13
* refactor: expect existing TS errors (#767 )
* refactor: expect existing TS errors
* refactor: fail build on new TS errors
* fix: styles
* refactor: rename StrategyForm and fix ts errors
* fix: update PR based on feedback
* fix: cleaning up
* fix: remove errors and warnings
* fix: remove ts-expect-error and fix errors
* fix: ts errors
* Update src/component/strategies/StrategyView/StrategyView.tsx
* Update src/component/strategies/StrategyView/StrategyView.tsx
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: olav <mail@olav.io>
2022-03-04 23:39:41 +01:00
Youssef Khedher
a3f439ea17
Merge branch 'main' into fix/ui-consistency
2022-02-25 13:54:11 +01:00
olav
3959e846e8
refactor: fix misc TS errors ( #729 )
...
* refactor: update test deps
* refactor: remove unused ts-expect-error annotations
* refactor: add missing arg and return types
* refactor: the loading prop is optional
* refactor: add missing arg and return types
* reafactor: fix value arg type
* refactor: fix missing array type
* refactor: the parameters field is an array
* refactor: use undefined instead of null in state
* refactor: add missing params type
* refactor: add missing children prop
* refactor: add missing array type
* refactor: add missing React imports
* refactor: use correct IProjectEnvironment type
* refactor: type errors as unknown
* refactor: the index prop is required
* refactor: fix date prop type
* refactor: fix tooltip placement prop type
* refactor: fix environments state type
* refactor: add missing arg types
* refactor: add guard for undefined field
* refactor: fix ChangePassword prop types
* refactor: fix MUI import paths
* refactor: add missing arg type
* refactor: fix showDialog prop type
* refactor: remove unused openUpdateDialog prop
* refactor: add missing non-null assertion
* refactor: remove unused types prop
* refactor: stricten API error handler types
* refactor: add missing undefined check
* refactor: add missing IProject id field
* refactor: fix ConditionallyRender condition prop types
* refactor: remove unused args
* refactor: add AddVariant prop types
* refactor: add types to UIContext
* refactor: fix event arg type
* refactor: add missing default impressionData field
* refactor: fix handleDeleteEnvironment prop args
* refactor: fix IFeatureMetrics field requirements
* refactor: add missing element types to ConditionallyRender
* refactor: remove unused ProjectAccess projectId prop
* refactor: add missing undefined check
* refactor: fix getCreateTogglePath arg type
* refactor: add missing IStrategyPayload import
* refactor: remove unused user arg
* refactor: add missing event arg type
* refactor: add missing style object types
* refactor: improve userApiErrors prop type
* refactor: the Dialogue onClose prop is optional
* refactor: fix the AddonEvents setEventValue prop type
2022-02-25 10:55:39 +01:00
Youssef
b0ba4f3a9d
fix: remove tooltips
2022-02-23 13:45:37 +01:00
Youssef
aae8c4d9d9
refactor: update text in ui consistent
2022-02-23 00:10:48 +01:00
Youssef Khedher
c2842c81e6
Refactor/strategies ( #668 )
...
* feat: add useStrategiesApi hook
* refactor: remove redux from strategies component
* refactor: CreateStrategy Component
* fix: remove ts errors
* refactor: change strategy-detail to functional component
* refactor: get strategy name from params
* refactor: use features hook and refactor toggle list link
* refactor: StrategiesList
* refactor: fix delete strategy function
* fix: ts errors
* refactor: CreateStrategy to StrategyForm
* feat: add toast for StrategyForm
* refactor: add StrategyView and delete old component
* refactor: StrategyDetails and clean unused files
* fix: cleanup unused code
* fix: add await
* fix: remove unused stores
Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
2022-02-11 00:08:55 +01:00
