Thomas Heartman
b2c58102dd
chore(unl-204): remove uses of toast text and confetti ( #8941 )
...
As of PR #8935 , we no longer support both text and title, and confetti
has been removed.
This PR:
- removes `confetti` from the toast interface
- merges `text` and `title` into `text` and updates its uses across the
codebase.
- readjusts the text where necessary.
2024-12-10 13:38:04 +00:00
Thomas Heartman
fe09ae214f
chore: fix "key" prop issues in front end tests ( #8459 )
...
Fixes all warnings about the "key" prop. The majority of the fixes fall
into one of the following categories:
- Extracting "key" props in tables (you're not allowed to just spread
them in)
- Adding "key" props to autocomplete options and chips
- fixing test data that didn't contain ids
2024-10-16 14:57:43 +02:00
gitar-bot[bot]
4615ff40ce
[Gitar] Cleaning up stale flag: resourceLimits with value true ( #7964 )
...
[](https://gitar.co )
---
This automated PR was generated by [Gitar](https://gitar.co ). View
[docs](https://gitar.co/docs ).
---------
Co-authored-by: Gitar <noreply@gitar.co>
Co-authored-by: Thomas Heartman <thomas@getunleash.io>
2024-08-22 13:20:53 +02:00
Mateusz Kwasniewski
cad8a3c2df
feat: limit component used in strategies ( #7542 )
2024-07-05 09:09:28 +02:00
Christopher Kolstad
f4e3388606
task: Yarn v4 ( #7457 )
...
Moves to Yarn v4
---------
Co-authored-by: Alvin Bryan <107407814+alvinometric@users.noreply.github.com>
2024-06-27 12:52:43 +02:00
Gastón Fournier
a0fce0ec12
Revert "fix: yarn v4 requires prepack instead of prepare script when building…" ( #7373 )
...
Reverts Unleash/unleash#7371
2024-06-12 13:25:51 +02:00
Christopher Kolstad
a971c770e9
task: Yarn v4 ( #7345 )
...
Trying again, this time with correct .gitignore already setup, and a
workflow configured to try what was failing prior to our revert.
2024-06-12 11:18:21 +02:00
Jaanus Sellin
3acb3ad2c2
feat: upgrade from react v17 to v18 ( #7265 )
...
**Upgrade to React v18 for Unleash v6. Here's why I think it's a good
time to do it:**
- Command Bar project: We've begun work on the command bar project, and
there's a fantastic library we want to use. However, it requires React
v18 support.
- Straightforward Upgrade: I took a look at the upgrade guide
https://react.dev/blog/2022/03/08/react-18-upgrade-guide and it seems
fairly straightforward. In fact, I was able to get React v18 running
with minimal changes in just 10 minutes!
- Dropping IE Support: React v18 no longer supports Internet Explorer
(IE), which is no longer supported by Microsoft as of June 15, 2022.
Upgrading to v18 in v6 would be a good way to align with this change.
TS updates:
* FC children has to be explicit:
https://stackoverflow.com/questions/71788254/react-18-typescript-children-fc
* forcing version 18 types in resolutions:
https://sentry.io/answers/type-is-not-assignable-to-type-reactnode/
Test updates:
* fixing SWR issue that we have always had but it manifests more in new
React (https://github.com/vercel/swr/issues/2373 )
---------
Co-authored-by: kwasniew <kwasniewski.mateusz@gmail.com>
2024-06-11 13:59:52 +03:00
Jaanus Sellin
f0f339ead3
fix: revert yarn4 ( #7334 )
...
Reverting yarn4, because we are stuck on broker build for couple of days
now.
2024-06-10 14:35:18 +03:00
Christopher Kolstad
57ddfc9255
fix: yarnv4 requires shebangs in shell scripts to allow execution ( #7323 )
2024-06-07 14:29:00 +00:00
Mateusz Kwasniewski
50ee7fa779
fix: new strategy using default strategy ( #7075 )
2024-05-20 09:50:44 +02:00
Christopher Kolstad
53354224fc
chore: Bump biome and configure husky ( #6589 )
...
Upgrades biome to 1.6.1, and updates husky pre-commit hook.
Most changes here are making type imports explicit.
2024-03-18 13:58:05 +01:00
Mateusz Kwasniewski
20a9e1d725
refactor: remove unused components and rename new ( #6357 )
2024-02-27 12:22:47 +01:00
Nuno Góis
b496990f79
chore: add no unused imports biome rule ( #5855 )
...
Adds a Biome rule for "no unused imports", which is something we
sometimes have trouble catching.
We're adding this as a warning for now. It is safely and easily fixable
with `yarn lint:fix`.
2024-01-11 12:44:05 +00:00
Mateusz Kwasniewski
f3ca4f0c54
chore: upgrading vite to newer version ( #5703 )
2023-12-20 14:48:18 +01:00
Nuno Góis
4167a60588
feat: biome lint frontend ( #4903 )
...
Follows up on https://github.com/Unleash/unleash/pull/4853 to add Biome
to the frontend as well.
Added a few `biome-ignore` to speed up the process but we may want to
check and fix them in the future.
2023-10-02 13:25:46 +01:00
Mateusz Kwasniewski
36bde1b24b
fix: default strategy stickiness ( #4340 )
2023-07-25 12:45:42 +02:00
Jaanus Sellin
b6f405d1af
fix: default strategy groupId failure ( #4120 )
2023-06-29 16:40:14 +03:00
andreas-unleash
c81de4a5bc
fix: add strategy bug when strategySplittedButton flag is on ( #4071 )
...
<!-- Thanks for creating a PR! To make it easier for reviewers and
everyone else to understand what your changes relate to, please add some
relevant content to the headings below. Feel free to ignore or delete
sections that you don't think are relevant. Thank you! ❤️ -->
Fixes 2 bugs after the recent strategy improvements v2 changes:
- When creating a strategy the `groupId` param of the Gradual Rollout
strategy now populates the groupId (when using default strategy, the
groupId will only be overwritten when it is an empty string ) with the
feature name (as it was before)
- When editing/setting a default strategy for an environment the
`groupId` param should be an empty string, but editable.
## About the changes
<!-- Describe the changes introduced. What are they and why are they
being introduced? Feel free to also add screenshots or steps to view the
changes if they're visual. -->
<!-- Does it close an issue? Multiple? -->
Closes #
<!-- (For internal contributors): Does it relate to an issue on public
roadmap? -->
<!--
Relates to [roadmap](https://github.com/orgs/Unleash/projects/10 ) item:
#
-->
### Important files
<!-- PRs can contain a lot of changes, but not all changes are equally
important. Where should a reviewer start looking to get an overview of
the changes? Are any files particularly important? -->
## Discussion points
<!-- Anything about the PR you'd like to discuss before it gets merged?
Got any questions or doubts? -->
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-06-23 07:31:29 +00:00
Jaanus Sellin
3763e1b24d
fix: default segments should only be selected when using default stra… ( #4040 )
2023-06-21 15:38:47 +03:00
Jaanus Sellin
60f4ce31f7
fix: usage of default strategy ( #3995 )
2023-06-19 11:31:08 +03:00
Jaanus Sellin
6e374be790
feat: strategy tooltip grouping and default ( #3986 )
2023-06-15 14:29:37 +03:00
Mateusz Kwasniewski
e538cb8a7f
fix: add segment to strategy payload ( #3611 )
2023-04-25 10:57:53 +02:00
Tymoteusz Czech
169b2bd0c5
Strategy title frontend ( #3556 )
...
Ability to add a title to a strategy
2023-04-19 17:27:23 +00:00
andreas-unleash
60a2c1a996
chore: Backport 4.22.3 ( #3508 )
...
<!-- Thanks for creating a PR! To make it easier for reviewers and
everyone else to understand what your changes relate to, please add some
relevant content to the headings below. Feel free to ignore or delete
sections that you don't think are relevant. Thank you! ❤️ -->
Backports stickiness fixes
## About the changes
<!-- Describe the changes introduced. What are they and why are they
being introduced? Feel free to also add screenshots or steps to view the
changes if they're visual. -->
<!-- Does it close an issue? Multiple? -->
Closes #
<!-- (For internal contributors): Does it relate to an issue on public
roadmap? -->
<!--
Relates to [roadmap](https://github.com/orgs/Unleash/projects/10 ) item:
#
-->
### Important files
<!-- PRs can contain a lot of changes, but not all changes are equally
important. Where should a reviewer start looking to get an overview of
the changes? Are any files particularly important? -->
## Discussion points
<!-- Anything about the PR you'd like to discuss before it gets merged?
Got any questions or doubts? -->
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: Gastón Fournier <gaston@getunleash.io>
Co-authored-by: GitHub Actions Bot <>
Co-authored-by: Mateusz Kwasniewski <kwasniewski.mateusz@gmail.com>
2023-04-12 16:22:13 +03:00
Mateusz Kwasniewski
cb0398ca63
loosen permissions for change requests ( #2682 )
2022-12-14 10:00:14 +01:00
Mateusz Kwasniewski
a87145b5ef
Fix strategy screen 404 ( #2638 )
2022-12-09 09:29:44 +01:00
Mateusz Kwasniewski
fab6fbb756
Change request event tracking ( #2570 )
2022-11-30 12:04:29 +01:00
Mateusz Kwasniewski
d1c565735a
linter fixes ( #2561 )
2022-11-30 10:52:13 +01:00
Fredrik Strand Oseberg
e439e46090
fix: change domain vocabulary ( #2503 )
...
* Changes the naming of useOpenRequests to usePendingChangeRequests
2022-11-23 13:45:19 +01:00
Fredrik Strand Oseberg
978674e33a
feat: update strategy segments with edit / create strategy ( #2420 )
...
* Refactors how we add / edit segments to make it more ergonomic to work with in regards to change requests
2022-11-16 15:35:39 +01:00
Fredrik Strand Oseberg
4689705f45
feat: update hook to use change request settings ( #2406 )
...
* Refactors the hook to use the change request settings from the API
2022-11-14 12:34:38 +01:00
Mateusz Kwasniewski
c6f906159b
feat: env check in change requests ( #2336 )
2022-11-07 09:16:29 +01:00
Tymoteusz Czech
4b281d9513
Change request - edit strategy ( #2334 )
...
* feat: request change - add strategy
* refactor: use change request is-enabled hook
* feat: edit strategy
* fix: prettier formatting
* fix: refetch change request draft after adding
2022-11-04 11:55:45 +01:00
Tymoteusz Czech
d2000f2848
feat: request change - add strategy ( #2330 )
...
* feat: request change - add strategy
* refactor: use change request is-enabled hook
2022-11-04 11:25:06 +01:00
Fredrik Strand Oseberg
3d90a3d070
fix: equality check on feature strategy ( #2145 )
...
fix: add ability to format objects to perform equality checks on
2022-10-06 14:39:56 +02:00
Fredrik Strand Oseberg
54633500fd
Feat/use collaborate data ( #2067 )
...
* feat: initial architecture
* feat: add generic types
* fix: refactor
* feat: style notification
* feat: remove useFeatureImmutable
* fix: remove casting
* fix: ensure data is present
* fix: revive useFeatureImmutable
* Update frontend/src/component/common/StaleDataNotification/StaleDataNotification.tsx
Co-authored-by: Nuno Góis <github@nunogois.com>
* Update frontend/src/component/common/StaleDataNotification/StaleDataNotification.tsx
Co-authored-by: Nuno Góis <github@nunogois.com>
* Update frontend/src/component/common/StaleDataNotification/StaleDataNotification.tsx
Co-authored-by: Nuno Góis <github@nunogois.com>
* Update frontend/src/component/common/StaleDataNotification/StaleDataNotification.tsx
Co-authored-by: Nuno Góis <github@nunogois.com>
* Update frontend/src/component/common/StaleDataNotification/StaleDataNotification.tsx
Co-authored-by: Nuno Góis <github@nunogois.com>
* fix: pr comments
* fix: change order
Co-authored-by: Nuno Góis <github@nunogois.com>
2022-09-16 15:23:08 +02:00
olav
523807359e
fix: sort strategy parameters payload ( #1218 )
...
* refactor: improve useStrategy fetch hook
* fix: sort strategy parameters payload
* refactor: move React import to the top
* refactor: fix refetchStrategy name
2022-08-12 14:49:26 +02:00
olav
59c8822cf2
fix: validate feature strategy parameters ( #1192 )
...
* refactor: extract InputCaption component
* refactor: split up GeneralStrategy component
* refactor: fill inn more default feature strategy parameter values
* fix: validate feature strategy parameters
* refactor: fix duplicate keys in strategy icon list
* refactor: expand variable names
* refactor: remove unnecessary useMemo
* refactor: use captions instead of tooltips for boolean parameter descriptions
* refactor: improve strategy definition form spacing
2022-08-04 13:34:30 +02:00
olav
68bfde58f7
fix: use correct docs API URL for feature strategy create/update ( #1116 )
...
* fix: use correct URL for update feature strategy
* fix: use correct URL for create feature strategy
2022-06-23 12:05:06 +02:00
olav
d8143c6ff4
chore: update react-router to v6 ( #946 )
...
* refactor: fix child selector warnings
* refactor: update react-router-dom
* refactor: use BrowserRouter as in react-router docs
* refactor: replace Redirect with Navigate
* refactor: replace Switch with Routes
* refactor: replace useHistory with useNavigate
* refactor: replace useParams types with useRequiredPathParam
* refactor: replace NavLink activeStyle with callback
* refactor: fix matchPath arg order
* refactor: Remove unused link state
* refactor: delete broken snapshot test
* refactor: render 404 page without redirect
* refactor: normalize path parameter names
* refactor: fix Route component usage
2022-05-05 13:42:18 +02:00
olav
49a63173f8
fix: avoid constraint accordion close on focus ( #907 )
...
* fix: avoid constraint accordion close on focus
* refactor: fix mutate cache key mismatch
2022-04-26 09:54:16 +02:00
olav
1fd6f2a60a
refactor: improve the text for docs links ( #904 )
...
* refactor: improve the text for docs links
* Update src/component/admin/apiToken/CreateApiToken/CreateApiToken.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/admin/projectRoles/CreateProjectRole/CreateProjectRole.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/admin/projectRoles/EditProjectRole/EditProjectRole.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/admin/users/CreateUser/CreateUser.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/admin/users/EditUser/EditUser.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/context/CreateUnleashContext/CreateUnleashContext.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/context/EditContext/EditContext.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/strategies/CreateStrategy/CreateStrategy.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* Update src/component/strategies/EditStrategy/EditStrategy.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
* refactor: improve docs link texts
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
2022-04-25 09:36:23 +02:00
olav
311915ba30
feat: show segments in feature overview ( #837 )
...
* feat: show segments in feature overview
* refactor: avoid segment updates without the UI flag
2022-04-01 11:11:53 +02:00
Youssef Khedher
eeda7ab5e4
feat: add segments ( #780 )
...
* feat: create segmentation structure and list
* feat: remove unused deps and change route
* feat: change header style and add renderNoSegments
* fix: style table header
* feat: create useSegments hook
* feat: add segmentApi hook
* feat: create segment
* fix: errors
* feat: add contextfields list
* fix: remove user from create segment api
* feat: add form structure
* feat: add SegmentFormStepOne
* fix: tests and routes
* feat: add constraint view
* feat: UI to match the sketch
* feat: add constraint on context select
* fix: duplication
* fix adding constraints
Co-authored-by: olav <mail@olav.io>
* fix: input date not showing up in constraint view
Co-authored-by: olav <mail@olav.io>
* fix: minor bugs
Co-authored-by: olav <mail@olav.io>
* fix: create context modal in segment page
Co-authored-by: olav <mail@olav.io>
* fix: validate constraint before create segment
Co-authored-by: olav <mail@olav.io>
* feat: create useSegment hook
Co-authored-by: olav <mail@olav.io>
* feat: create edit component
Co-authored-by: olav <mail@olav.io>
* refactor: move constraint validation endpoint
* refactor: add missing route snapshot
* refactor: fix segment constraints unsaved/editing state
* refactor: remove create segment from mobile header menu
* refactor: update segments form description
* refactor: extract SegmentFormStepList component
* refactor: add an optional FormTemplate docs link label
* refactor: fix update segment payload
* feat: finish edit component
Co-authored-by: olav <mail@olav.io>
* refactor: move step list above segment form
* fix: update PR based on feedback
Co-authored-by: olav <mail@olav.io>
* refactor: fix constraint validation endpoint path
* refactor: improve constraint state field name
* refactor: extract AutocompleteBox component
* feat: add strategy segment selection
* refactor: add strategy segment previews
* refactor: fix double section separator line
* feat: disable deleting a usable segment
* refactor: warn about segments without constraints
* refactor: update text in delete segment dialogue
* refactur: improve arg names
* refactor: improve index var name
* refactor: clarify steps list logic
* refactor: use a required prop for the segment name
* refactor: use ConditionallyRender for segment deletion
* refactor: fix segments refetch
* refactor: improve CreateUnleashContext component names
* refactor: adjust segment form styles
* refactor: adjust text
* refactor: fix info icon tooltip hover target
* refactor: add missing aria attrs to preview button
* refactor: add strat name to delete segment modal
* refactor: fix segment chip text alighment
* refactor: use bulk endpoint for strategy segments
* refactor: fix imports after merge
Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
Co-authored-by: olav <mail@olav.io>
2022-03-29 09:30:57 +02:00
Youssef Khedher
85950f104a
chore: update paths 🧼 ( #820 )
2022-03-28 09:49:59 +01:00
olav
cfc2338e78
refactor: use camel case for files and dirs ( #817 )
2022-03-25 12:34:20 +01:00
olav
baae88c7a5
feat: add new feature strategy create/edit pages ( #739 )
...
* refactor: add param helper hooks
* refactor: remove first add strategy link
* refactor: add more types to useStrategies
* refactor: port strategy utils to TS
* refactor: replace rollout strategy icon
* refactor: use a named export for useFeature
* refactor: add more types to useFeature
* refactor: adjust code box styles
* refactor: add missing PermissionButton variant prop
* refactor: add missing button icon label
* refactor: move common feature components
* refactor: fix StrategyConstraints error prop types
* refactor: fix GeneralStrategy prop types
* feat: add new feature strategy create/edit pages
* refactor: remove feature strategies page
* refactor: fix types in GeneralStrategy
* refactor: use ConstraintAccordion on the new pages
* refactor: use ConditionallyRender for remove button
* refactor: rename FeatureStrategyForm component
* refactor: use the Edit icon for feature strategies
* refactor: fix initial edit mode for new constraints
* refactor: add FeatureStrategyMenu to closed accordions
* refactor: allow editing multiple constraints
* refactor: show single-valued constraint value
* refactor: increase feature overview strategy width
* refactor: add remove button to feature overview strategies
* refactor: move createEmptyConstraint to own file
* refactor: disable submit button for invalid constraints
* refactor: fix nested paragraphs on the metrics page
* refactor: move create/edit feature strategy to modal
* refactor: always open new constraints in edit mode
* refactor: use a PermissionButton for the save button
* refactor: remvoe unsaved constraints on cancel
* refactor: clarify useConstraintsValidation logic
* refactor: remove unused strategy descriptions
* refactor: restore Rollout icon
* refactor: remove sidebar modal slide animation
* refactor: avoid constraint accordion toggle on edit/delete
* refactor: truncate long strategy names
* refactor: find the correct remove button
2022-03-09 14:59:24 +01:00
