1
0
mirror of https://github.com/Unleash/unleash.git synced 2024-10-18 20:09:08 +02:00
Commit Graph

84 Commits

Author SHA1 Message Date
Nuno Góis
233e06ec6a
fix: disable autoResetHiddenColumns when useConditionallyHiddenColumns (#2851)
https://linear.app/unleash/issue/2-563/fix-issue-with-useconditionallyhiddencolumns-and-react-table

It seems like we should add `autoResetHiddenColumns: false` to
`useTable` whenever we use `useConditionallyHiddenColumns`.

Basically the thought is that, if we're controlling column visibility in
our own way, we should not want other things to change that state
unpredictably, otherwise this may make React go _brrrrrr_. And it can be
very hard to pinpoint what exactly may be causing React to go _brrrrrr_.


![image](https://user-images.githubusercontent.com/14320932/211332339-95918c5c-e3ea-40e9-b8b4-756a798a4702.png)

First detected this issue apparently randomly while developing the new
SA table. Around 10-20 page refreshes would eventually trigger it. Was
not easy to find, but hopefully this fixes it permanently. At least I
haven't been able to reproduce it since. Maybe someone has a better idea
of where the issue could be or if this is a pretty good guess. Doesn't
seem like this change hurts us anyways.

I love React, `useEffect` and these very to-the-point error messages.
Very fun and productive.

Reference: https://react-table-v7.tanstack.com/docs/api/useTable
2023-01-10 08:15:12 +00:00
Tymoteusz Czech
1653b0449a
Orval generator POC (#2724)
for #2715
2023-01-05 11:57:53 +01:00
Fredrik Strand Oseberg
093156f5f5
Refactor/make styles batch 6 part 2 (#2811)
Adds another batch of refactored components
2023-01-03 16:15:22 +01:00
Fredrik Strand Oseberg
241ede8ca9
Refactor/make styles batch 6 (#2793)
Refactors a number of components in the frontend away from deprecated makeStyles
2023-01-03 09:24:55 +01:00
Nuno Góis
1d1219a055
Use new useConditionallyHiddenColumns hook (#2695)
https://linear.app/unleash/issue/2-515/adapt-tables-to-use-the-new-useconditionallyhiddencolumns-hook

Uses the new `useConditionallyHiddenColumns` hook, like mentioned here:
https://github.com/Unleash/unleash/pull/2691
Also includes small fixes for things I caught along the way. See
comments below.
2022-12-16 10:46:04 +01:00
Fredrik Strand Oseberg
e439e46090
fix: change domain vocabulary (#2503)
* Changes the naming of useOpenRequests to usePendingChangeRequests
2022-11-23 13:45:19 +01:00
Thomas Heartman
d5fbd0b743
refactor: move docs into new structure / fix links for SEO (#2416)
## What

This (admittedly massive) PR updates the "physical" documentation
structure and fixes url inconsistencies and SEO problems reported by
marketing. The main points are:

- remove or move directories : advanced, user_guide, deploy, api
- move the files contained within to the appropriate one of topics,
how-to, tutorials, or reference
- update internal doc links and product links to the content
- create client-side redirects for all the urls that have changed.

A number of the files have been renamed in small ways to better match
their url and to make them easier to find. Additionally, the top-level
api directory has been moved to /reference/api/legacy/unleash (see the
discussion points section for more on this).

## Why

When moving our doc structure to diataxis a while back, we left the
"physical' files lying where they were, because it didn't matter much to
the new structure. However, that did introduce some inconsistencies with
where you place docs and how we organize them.

There's also the discrepancies in whether urls us underscores or hyphens
(which isn't necessarily the same as their file name), which has been
annoying me for a while, but now has also been raised by marketing as an
issue in terms of SEO.

## Discussion points

The old, hand-written API docs have been moved from /api to
/reference/api/legacy/unleash. There _is_ a /reference/api/unleash
directory, but this is being populated by the OpenAPI plugin, and mixing
those could only cause trouble. However, I'm unsure about putting
/legacy/ in the title, because the API isn't legacy, the docs are. Maybe
we could use another path? Like /old-docs/ or something? I'd appreciate
some input on this.
2022-11-22 09:05:30 +00:00
Fredrik Strand Oseberg
978674e33a
feat: update strategy segments with edit / create strategy (#2420)
* Refactors how we add / edit segments to make it more ergonomic to work with in regards to change requests
2022-11-16 15:35:39 +01:00
Thomas Heartman
b61dbbd718
fix: remove lexical illusion in playground guidance (#2360)
## What

I have removed a lexical illusion lexical illusion in this guidance
step, where "context field" was repeated.

## Why

Because it's unintended and doesn't make any sense in the the sentence.
2022-11-09 13:56:34 +00:00
Tymoteusz Czech
0a855604af
feat: review your draft sidebar (#2305)
* refactor playground status chip component

* fix: update change request sidebar

* refactor: status badge cleanup

* fix: prettier formatting
2022-11-02 16:05:27 +01:00
Mateusz Kwasniewski
0dba973881
Feat/apply changes (#2258)
* feat: add suggested change component

* fix: build

* feat: suggestion header

* ui sketching different toggle changes

* feat: strategy change sets UI tweaks

* refactor: extract nested components

Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
2022-10-26 09:45:24 +02:00
Fredrik Strand Oseberg
6818a82cd1 Feat/dark mode exp (#1137)
* feat: add dark mode theme

* fix: feature metrics

* fix: add color

* styling

* fix: add switch

* fix: form sidebar

* fix: remove console log

* fix: add properties

* fix: strategy container

* feat: feature flag

* fix: tests

* fix: build

* fix: logo

* fix: icon

* fix: update snapshots

* fix: CES operator

* fix: typography

* fix: input styling

* fix: remove initial load

* fix: change flag name

* fix: refactor to custom hook

* fix: remove unused import

* fix: dialog headers

* fix: use uiConfig flags instead of flags
2022-08-23 14:20:02 +02:00
andreas-unleash
eaaaa29199 Playground UI bugs and improvements (#1219)
* fix status cell logic

* Add back disabled env wrapper

* Add back disabled env wrapper

* fmt

* Wording improvements, refactor for readability

* improvement

* fmt

* Fixes after merge

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2022-08-12 15:33:18 +02:00
Tymoteusz Czech
859aa435e0 Refine Playground UI (#1217)
* fix playground border radius consistency

* improve playground alerts

* fix: playground segments constraint type logic

* fix: refactor segment execution

* fix: comments

* fix: add summary width

* align playground spacing and borders

* fix build - ts segment type in playground

* fix status cell logic

* update playground disabled env info

* fix playground filter by status and sort

Co-authored-by: Nuno Góis <github@nunogois.com>

Co-authored-by: Fredrik Oseberg <fredrik.no@gmail.com>
Co-authored-by: andreas-unleash <104830839+andreas-unleash@users.noreply.github.com>
Co-authored-by: Nuno Góis <github@nunogois.com>
2022-08-12 10:13:07 +00:00
Tymoteusz Czech
d2225c62c9 fix playground custom strategy parameters debugging (#1213)
* fix playground custom strategy parameters debugging

* fix playground strategy parameters and chips consistency
2022-08-11 08:36:23 +00:00
Fredrik Oseberg
acbe61b74b fix: import typography 2022-08-10 14:30:57 +02:00
Fredrik Oseberg
ad1b7bf8fc fix: remove page content 2022-08-10 14:29:24 +02:00
andreas-unleash
a01bbb2db9 fix loader, change width to show full header name 2022-08-10 14:37:13 +03:00
Fredrik Oseberg
eaff77afd4 fix: add widths for viritualized table 2022-08-10 13:15:33 +02:00
andreas-unleash
1a30f42635 Merge branch 'main' into fix/playground_virtualisation_loader 2022-08-10 07:37:58 +03:00
andreas-unleash
af27e0bd5e added comment to playground model file 2022-08-09 18:02:09 +03:00
andreas-unleash
96818bd339 added comment to playground model file 2022-08-09 17:56:45 +03:00
andreas-unleash
a4c6ae2077 Added unknown evaluation state to table
Moved playground.model.ts to Playground folder
2022-08-09 17:41:43 +03:00
andreas-unleash
781813fd05 Merge remote-tracking branch 'origin/task/Add_strategy_information_to_playground_results' into task/Add_strategy_information_to_playground_results 2022-08-09 10:11:00 +03:00
andreas-unleash
69d6a1f186 PR comments 2022-08-09 10:10:45 +03:00
andreas-unleash
d0a04348f3 Update src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/FeatureDetails/FeatureDetails.tsx
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
2022-08-09 10:08:44 +03:00
andreas-unleash
fa0e75d22a PR comment 2022-08-08 16:24:14 +03:00
andreas-unleash
18afc34f85 fix build 2022-08-08 16:21:23 +03:00
andreas-unleash
a0091ffabc bug fix 2022-08-08 16:07:52 +03:00
andreas-unleash
66287948dd bug fix 2022-08-08 14:11:20 +03:00
andreas-unleash
eb7d7e59d5 improvements 2022-08-08 14:00:49 +03:00
andreas-unleash
90685cef22 improvements 2022-08-08 13:53:28 +03:00
andreas-unleash
3b2947e9af Merge remote-tracking branch 'origin/task/Add_strategy_information_to_playground_results' into task/Add_strategy_information_to_playground_results
# Conflicts:
#	src/component/playground/Playground/PlaygroundResultsTable/FeatureResultInfoPopoverCell/PlaygroundResultFeatureStrategyList/PlaygroundResultStrategyList/PlaygroundResultFeatureStrategyItem/PlaygroundResultFeatureStrategyItem.tsx
2022-08-08 13:46:38 +03:00
andreas-unleash
f057bbfd61 style fix 2022-08-08 13:46:11 +03:00
Tymoteusz Czech
b32b751f2c update custom strategy params from feature branch 2022-08-08 11:41:35 +02:00
Tymoteusz Czech
6bf05d89e7 fix react key warning 2022-08-08 11:36:33 +02:00
Tymoteusz Czech
1620d72c8f rename files related to playground 2022-08-08 11:23:37 +02:00
Tymoteusz Czech
d013475538 fix formatting - prettier 2022-08-08 11:23:37 +02:00
Tymoteusz Czech
e432ae45e0 update strategy border for playground 2022-08-08 11:20:47 +02:00
andreas-unleash
e75f03b8f2 fmt fix 2022-08-08 12:16:53 +03:00
andreas-unleash
ceb7d2e3cc Parameters Bug fix 2022-08-08 11:38:36 +03:00
andreas-unleash
ff33308d8e Parameters Bug fix 2022-08-08 10:42:45 +03:00
andreas-unleash
33288caae4 PR comments 2022-08-05 12:16:51 +03:00
andreas-unleash
8785c47ab4 improvement 2022-08-04 16:53:08 +03:00
andreas-unleash
3c5c855fc5 custom strategies adjustments 2022-08-04 16:25:45 +03:00
andreas-unleash
44f77c46c2 fmt 2022-08-04 15:49:41 +03:00
andreas-unleash
e3fcfb1318 improvements 2022-08-04 15:31:09 +03:00
andreas-unleash
22ab265db9 bug fix 2022-08-04 15:17:32 +03:00
andreas-unleash
b32ab004c8 bug fix 2022-08-04 15:17:17 +03:00
andreas-unleash
6e190834ff PR comments 2022-08-04 14:50:40 +03:00