Mateusz Kwasniewski
8e5aeff1a7
fix: table accessor should handle dots ( #2863 )
2023-01-10 13:15:55 +01:00
Nuno Góis
233e06ec6a
fix: disable autoResetHiddenColumns when useConditionallyHiddenColumns ( #2851 )
...
https://linear.app/unleash/issue/2-563/fix-issue-with-useconditionallyhiddencolumns-and-react-table
It seems like we should add `autoResetHiddenColumns: false` to
`useTable` whenever we use `useConditionallyHiddenColumns`.
Basically the thought is that, if we're controlling column visibility in
our own way, we should not want other things to change that state
unpredictably, otherwise this may make React go _brrrrrr_. And it can be
very hard to pinpoint what exactly may be causing React to go _brrrrrr_.
First detected this issue apparently randomly while developing the new
SA table. Around 10-20 page refreshes would eventually trigger it. Was
not easy to find, but hopefully this fixes it permanently. At least I
haven't been able to reproduce it since. Maybe someone has a better idea
of where the issue could be or if this is a pretty good guess. Doesn't
seem like this change hurts us anyways.
I love React, `useEffect` and these very to-the-point error messages.
Very fun and productive.
Reference: https://react-table-v7.tanstack.com/docs/api/useTable
2023-01-10 08:15:12 +00:00
Fredrik Strand Oseberg
093156f5f5
Refactor/make styles batch 6 part 2 ( #2811 )
...
Adds another batch of refactored components
2023-01-03 16:15:22 +01:00
sjaanus
8a8cd1bf27
UI Flags cleanup ( #2778 )
2023-01-02 15:41:43 +02:00
sjaanus
be045dc13a
Remove favorites feature flag ( #2722 )
2022-12-21 12:03:06 +00:00
Nuno Góis
1d1219a055
Use new useConditionallyHiddenColumns hook ( #2695 )
...
https://linear.app/unleash/issue/2-515/adapt-tables-to-use-the-new-useconditionallyhiddencolumns-hook
Uses the new `useConditionallyHiddenColumns` hook, like mentioned here:
https://github.com/Unleash/unleash/pull/2691
Also includes small fixes for things I caught along the way. See
comments below.
2022-12-16 10:46:04 +01:00
Nuno Góis
4afd505164
feat: make favorites a global preference ( #2685 )
...
https://linear.app/unleash/issue/2-508/make-pinned-favorites-a-global-preference
Also introduces a `useGlobalLocalStorage` hook where system-wide
preferences that are stored in LocalStorage can be maintained.
2022-12-13 13:20:43 +00:00
Nuno Góis
e8d0fdba1f
remove feature flag: toggle tag filtering ( #2668 )
...
https://linear.app/unleash/issue/2-482/clean-up-feature-flag-after-this-goes-ga
Relevant discussion:
https://unleash-internal.slack.com/archives/C046LV6HH6W/p1670837328201169
2022-12-12 13:21:12 +00:00
andreas-unleash
6bccffef97
Fix/favorites UI improvements ( #2636 )
...
<!-- Thanks for creating a PR! To make it easier for reviewers and
everyone else to understand what your changes relate to, please add some
relevant content to the headings below. Feel free to ignore or delete
sections that you don't think are relevant. Thank you! ❤️ -->
Favorite UI improvements
## About the changes
<!-- Describe the changes introduced. What are they and why are they
being introduced? Feel free to also add screenshots or steps to view the
changes if they're visual. -->
<!-- Does it close an issue? Multiple? -->
Closes #
<!-- (For internal contributors): Does it relate to an issue on public
roadmap? -->
<!--
Relates to [roadmap](https://github.com/orgs/Unleash/projects/10 ) item:
#
-->
### Important files
<!-- PRs can contain a lot of changes, but not all changes are equally
important. Where should a reviewer start looking to get an overview of
the changes? Are any files particularly important? -->
## Discussion points
<!-- Anything about the PR you'd like to discuss before it gets merged?
Got any questions or doubts? -->
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2022-12-08 14:41:51 +02:00
Tymoteusz Czech
3ee2e5ae9b
fix: favorites column visibility ( #2605 )
...
Co-authored-by: sjaanus <sellinjaanus@gmail.com>
2022-12-06 10:03:43 +00:00
Tymoteusz Czech
ef6ec4a83b
Favorite features on project ( #2580 )
2022-12-01 13:10:42 +01:00
Mateusz Kwasniewski
87d9466005
change request tooltips ( #2555 )
2022-11-29 12:56:19 +01:00
Mateusz Kwasniewski
a3957f8c99
disable change request overview actions when CR are disabled ( #2527 )
2022-11-24 16:16:14 +01:00
Mateusz Kwasniewski
4e28aef55e
react exhaustive check fix ( #2513 )
2022-11-23 16:59:39 +01:00
Nuno Góis
538bbe7105
fix: make the tags column have a fixed width ( #2451 )
...
By setting a fixed width in the tags column we can save some extra
space.
2022-11-16 16:05:17 +00:00
Nuno Góis
1ddc46011c
Feature toggles: Filtering by tags ( #2396 )
...
https://linear.app/unleash/issue/UNL-140/experiment-with-filtering-feature-toggles-by-tags-on-the-ui
Going with a naïve approach for now, tags can be searchable the same way
we search for text. The tags column only shows up if at least one toggle
has tags set. There's a simple highlightable component that lets us know
a match was found and then shows all the tags on a tooltip:
<img width="1289" alt="image"
src="https://user-images.githubusercontent.com/14320932/201155093-b8605ff2-5bf7-45c5-b240-a33da254c278.png ">
2022-11-15 10:24:36 +00:00
Fredrik Strand Oseberg
4689705f45
feat: update hook to use change request settings ( #2406 )
...
* Refactors the hook to use the change request settings from the API
2022-11-14 12:34:38 +01:00
Mateusz Kwasniewski
c6f906159b
feat: env check in change requests ( #2336 )
2022-11-07 09:16:29 +01:00
andreas-unleash
c1e0bd83b0
Frontend - Suggest change copy strategy ( #2312 )
...
* Suggest change copy strategy
* Fix merge conflicts
* Copy strategies from other environment added to draft
* Copy strategies from other environment added to draft
* Copy strategies from other environment added to draft
* Copy strategies from other environment added to draft
* fmt
* PR comments
* PR comments
* PR comments
* PR comments
* Fix: Conditionally hide Change Requests tab
2022-11-04 11:33:07 +02:00
Mateusz Kwasniewski
fae7de0d5d
refactor: hook for change requests ( #2331 )
...
* refactor: hook for change requests
* Update frontend/src/component/project/Project/ProjectFeatureToggles/ProjectFeatureToggles.tsx
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
* Update frontend/src/component/project/Project/Project.tsx
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
* Update frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewEnvSwitches/FeatureOverviewEnvSwitch/FeatureOverviewEnvSwitch.tsx
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
* Update frontend/src/component/feature/FeatureStrategy/FeatureStrategyRemove/FeatureStrategyRemove.tsx
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
* fix: fix imports
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
2022-11-04 09:50:00 +01:00
Mateusz Kwasniewski
6622346286
Add stable row id. ( #2315 )
...
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
2022-11-02 12:55:20 +01:00
sjaanus
5dd8616c74
Rename suggest changes to change request ( #2311 )
...
* Rename change request
* Merge with review status
* Move events and permissions
2022-11-02 08:34:14 +02:00
Tymoteusz Czech
c6c873d67d
feat: add changes to draft ( #2271 )
...
* feat: add changes to draft
* Make domain type and schema match
* Deleting change from changeset
* Add ability to merge
* Revert "Add ability to merge"
This reverts commit 504e7e796e2effc20378079f46c0db
2022-10-28 09:37:55 +02:00
Tymoteusz Czech
ea2cf144f9
Suggest changes dialog ( #2247 )
...
* refactor: suggested changes folder structure
* feat: add dialogue confirmation
2022-10-26 13:57:59 +02:00
Nuno Góis
4e61cf22c0
fix: small ui fixes related to groups and tooltips ( #1167 )
2022-07-28 15:27:38 +02:00
Tymoteusz Czech
9522c59674
Refactor project health table ( #1098 )
...
* minor archive table updates
* archived date cell
* archive import paths
* move project health table files
* fix: align actions cells
* simplify health table row mapping
* fix project pages browser tab title
* initial draft of virtualized table component
* refactor: virtualized table common component
* fix: health report name cell width
* refactor: report cell paths
2022-06-21 09:08:37 +02:00
Tymoteusz Czech
349106a2be
fix: sort order across the app
...
discussed with Nicolae and Nuno
2022-06-14 11:14:56 +02:00
olav
e338319afa
refactor: avoid relative positioning for tbody ( #1085 )
...
* refactor: expose vite dev server on local IP
* refactor: avoid relative positioning for tbody
* refactor: avoid height on tbody as well
* refactor: use row height from theme
2022-06-13 09:25:36 +02:00
Nuno Góis
4761847ce5
feat: upgrade search to use the new search component ( #1073 )
...
* feat: upgrade project list search to use the new search field
* cleanup unused imports
* feat: add upgraded search to projects and applications, polish search UX
* refactor: TableSearch to new Search common component
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2022-06-10 15:23:12 +02:00
Tymoteusz Czech
608171ce93
Improve table performance ( #1061 )
...
* improve table performance
* revert to react-router navigation
2022-06-09 11:34:55 +02:00
Nuno Góis
4a5ed3c3e7
feat: add filtering capabilities to search ( #1052 )
...
* feat: add filtering capabilities to search
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
* fix: state custom filter
* fix: undefined search crash
* feat: add suggestions component
* make search visible all the time
* fix: update snaps
* refactor, add tests, filterParsing, pass down searchContext to search components
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
* refactor: TableSearchFieldSuggestions and improvements
* some cleanup and fix edge cases
* adapt new search in project feature toggles
* small ui/ux improvements
* refactor: suggestions into smaller components
* fix: update snaps
* add responsiveness to the search
* fix: update snaps
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2022-06-03 11:32:30 +01:00
Nuno Góis
682921d5bf
fix: misc ui fixes post tables upgrade ( #1049 )
...
* fix: misc ui fixes post tables upgrade
* fix: update snaps, small cleanup
* refactor: ReportCard to styled, misc improvements
* cleanup remaining styles file
* rename `Feature Toggle Name` to just `name`
* refactor: address PR comments
2022-06-02 08:21:51 +01:00
Tymoteusz Czech
24cb1b21ef
Virtualize project toggles list ( #1043 )
...
* fix: virtualize project toggles list
* refactor: improve type for feature dialogs
* fix: formatting - prettier
2022-06-01 12:24:24 +00:00
Tymoteusz Czech
670bb33fad
fix: prevent search reset on project overview ( #1045 )
...
* fix: prevent search reset on project overview
* fix: use global filter for search in project
2022-05-31 08:31:52 +00:00
Tymoteusz Czech
581dcca2b2
Fix: global filter table rules ( #1016 )
2022-05-27 14:15:32 +00:00
olav
eb5e83cdb4
refactor: remove unused code ( #1036 )
...
* refactor: remove unused code
* refactor: remove more unused code
2022-05-27 13:28:58 +02:00
olav
504a4af274
refactor: port segments list to react-table ( #1024 )
...
* refactor: extract SegmentEmpty component
* refactor: extract CreateSegmentButton component
* refactor: extract EditSegmentButton component
* refactor: extract RemoveSegmentButton component
* refactor: normalize Created table header text
* refactor: port segments list to react-table
* fix: improve row text height in table row
* fix: update test snapshots
* refactor table cell with search highlight
* fix: update after review
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
Co-authored-by: Tymoteusz Czech <tymek+gpg@getunleash.ai>
2022-05-27 08:57:30 +02:00
Tymoteusz Czech
7480085698
Fix: Features table performance ( #1015 )
...
* feat: persistent table query
* project overview sort query
* refactor: api methods as hook callbacks
* persitent columns in project overview
* enable new project overview
* fix: refactor feature state change in overview
* add type to sort
* update e2e tests
now takes 10% less time with use of cypress session
* prevent sort reset on features list
* fix feature toggle list loading
* fix: features table items virtualization
* project overview screen limits
* table row height in theme
* rename row index variable
2022-05-25 14:39:14 +00:00
Tymoteusz Czech
a11cb72d99
Persistent table query ( #999 )
...
* feat: persistent table query
* project overview sort query
* refactor: api methods as hook callbacks
* persitent columns in project overview
* enable new project overview
* fix: refactor feature state change in overview
* add type to sort
* update e2e tests
now takes 10% less time with use of cypress session
* prevent sort reset on features list
* fix feature toggle list loading
* fix: update column state saving
* update local storage hook test
2022-05-25 08:14:22 +00:00
Tymoteusz Czech
6d130f61f6
feat: new contexts table ( #998 )
...
* feat: new contexts table
* improve context list actions
* refactor: disabled icon colors
* fix: update snapshots
* fix: icons
* fix: context fields typo
2022-05-20 08:29:23 +00:00
olav
2e367b3a04
feat: add trial expiration warning banner ( #985 )
...
* refactor: simplify useApiGetter cache keys
* refactor: simplify basePath helpers
* refactor: add UNLEASH_BASE_PATH frontend env var
* refactor: make sure AnnouncerElement does not affect the layout
* refactor: draw texture image above footer
* refactor: extract domain check helpers
* refactor: fix a few ts-expect-errors
* feat: add trial expiration warning banner
* refactor: fix IInstanceStatus interface prefix
* refactor: use ConditionallyRender in InstanceStatus
* refactor: simplify env helper functions
* refactor: use FC in InstanceStatus
* refactor: warn about expired trials
* refactor: fix eslint warnings
* refactor: disable banner outside of localhost
* refactor: use new instance state field name
2022-05-19 14:06:18 +02:00
Tymoteusz Czech
06b0a29ea8
Project features list update ( #991 )
...
* refactor: column icon position
* project overview horizontal scroll
* updated table headers styles
* fix: feature overview switch title
* refactor: cleanup of sortable header styles
* fix: z-index issue in test
* fix: html semantics after review
2022-05-18 11:56:55 +02:00
Tymoteusz Czech
b1166bb2f4
Project overview feature toggles list ( #971 )
...
* refactor: page container
* refactor: table page header
* feat: new feature toggles list in project overview
* feat: sortable enviromnents in project overview
* feat: project overview toggles search
* feat: project overview features column actions
* project overview table column sizing
* project overview feature actions permissions
* project overview archive feature action
* project overview toggle state strategy fallback
* remove previous project overview implementation
* fix: remove additional prop in sortable table
* fix: stale feature refetch
* improvements after review
* feat: manage visible columns in project overview
* improve project overview columns selection
* fix: simplify columns
* Revert "remove previous project overview implementation"
This reverts commit 98b051ff6a5a4fb8a9a0921b661514e15a00249a.
* restore legacy project overview table
2022-05-13 14:51:22 +02:00
Tymoteusz Czech
44c579f7a8
Refactor: page container ( #967 )
...
* refactor: page container
* refactor: table page header
2022-05-09 14:38:12 +02:00
olav
d8143c6ff4
chore: update react-router to v6 ( #946 )
...
* refactor: fix child selector warnings
* refactor: update react-router-dom
* refactor: use BrowserRouter as in react-router docs
* refactor: replace Redirect with Navigate
* refactor: replace Switch with Routes
* refactor: replace useHistory with useNavigate
* refactor: replace useParams types with useRequiredPathParam
* refactor: replace NavLink activeStyle with callback
* refactor: fix matchPath arg order
* refactor: Remove unused link state
* refactor: delete broken snapshot test
* refactor: render 404 page without redirect
* refactor: normalize path parameter names
* refactor: fix Route component usage
2022-05-05 13:42:18 +02:00
olav
24c11332b5
chore: update MUI to v5 ( #923 )
...
* refactor: update mui packages
* refactor: run mui codemods
* refactor: format files after codemods
* refactor: fix broken types
* refactor: clean up theme
* refactor: fix broken tests
* refactor: replace @mui/styles with tss-react
* refactor: move breakpoints into classes for tss
* refactor: fix crash on missing feature description
* refactor: remove void classNames
* refactor: adjust styles to new defaults
* refactor: remove broken rollout slider e2e test
* refactor: fix duplicate e2e testid
* refactor: update makeStyles after rebase
* refactor: add missing snapshot after rebase
* refactor: fix TableCellSortable focus styles
* refactor: use 1.4 as the default line-height
* refactor: hide webkit search field icons
* refactor: fix select box label
* refactor: make AutocompleteBox smaller
* refactor: make heading smaller
* refactor: fix toast close icon color
* refactor: update snapshots
* refactor: add missing test event awaits
* refactor: fix default button line-height
2022-05-02 15:52:41 +02:00
Tymoteusz Czech
23a874d051
Refactor: convert jsx files to typescript ( #881 )
...
* refactor: convert remaining js files to typescript
* refactor: conditionally render remove index
* refactor: dialog component to tsx
* refactor: migrate some files from jsx to tsx
* refactor: convert dropdown element to tsx
* refactor: feature toggle list to tsx
* refactor: update context name in use overrides
* refactor: variant overrides to tsx
refactor: remove unused strategy constraint file
* fix: tsx imports
* fix: update refectored components after rebase
* refactor: rename report list files to tsx
* fix: project health list types
* refactor: addon form - add types
* refactor: copy feature component types
* fix: projects toggle style after tsx refactor
* refactor: update ts types from openapi
* fix: ts refactor changes after review
* fix: header title prop
* fix: update after PR comments
* add test to useoverrides hook
* fix conditionally render time ago
* fix: toggle list empty tooltip
* fix: remove unused variable
* remove unused variable
* fix: remove faulty snapshot
2022-05-02 12:52:33 +02:00
olav
531d969fa6
refactor: misc login page accessibility improvements ( #914 )
...
* refactor: add missing input field labels
* refactor: add missing className prop
* refactor: add missing image labels
* refactor: fix forgot password title size
* refactor fix StandaloneLayout page landmarks
* refactor: improve project page title
* refactor: add autoFocus to login fields
2022-04-27 09:29:43 +02:00
olav
f7266cde10
fix: announce navigation to screen readers ( #911 )
...
* refactor: unify page titles
* refactor: update page title on navigation
* refactor: add AnnouncerContext to test contexts
* fix: announce navigation to screen readers
2022-04-27 09:14:44 +02:00
Youssef Khedher
4589a19e03
fix: misc UI improvements ( #806 )
...
* fix: link color in project features
Co-authored-by: olav <mail@olav.io>
* fix: link in health page
Co-authored-by: olav <mail@olav.io>
* fix: keep sorting state in project toggles list
Co-authored-by: olav <mail@olav.io>
* fix: style link in the toggle list project
Co-authored-by: olav <mail@olav.io>
* refactor: update browser list
Co-authored-by: olav <mail@olav.io>
Co-authored-by: olav <mail@olav.io>
2022-03-25 15:30:52 +01:00
