1
0
mirror of https://github.com/Unleash/unleash.git synced 2024-10-18 20:09:08 +02:00
Commit Graph

167 Commits

Author SHA1 Message Date
Nuno Góis
9f4b34367c
fix: secondary button should say "cancel" instead of "close" (#2496)
Small fix after talking with @NicolaeUnleash
2022-11-22 12:33:03 +00:00
Fredrik Strand Oseberg
a53d970263
feat: add badges to modified strategies (#2492)
<!-- Thanks for creating a PR! To make it easier for reviewers and
everyone else to understand what your changes relate to, please add some
relevant content to the headings below. Feel free to ignore or delete
sections that you don't think are relevant. Thank you! ❤️ -->

## About the changes
<!-- Describe the changes introduced. What are they and why are they
being introduced? Feel free to also add screenshots or steps to view the
changes if they're visual. -->

* Adds a badge to strategies if the change can be found and the change
is relevant:
<img width="893" alt="Skjermbilde 2022-11-22 kl 11 18 32"
src="https://user-images.githubusercontent.com/16081982/203289081-b59ecaaf-e6cd-4802-b633-9cc118ca405d.png">

* I was considering making this more ergonomic using the slots vs props
pattern, but since this component is used in multiple places I left it
as is for now.

<!-- Does it close an issue? Multiple? -->
Closes #

<!-- (For internal contributors): Does it relate to an issue on public
roadmap? -->
<!--
Relates to [roadmap](https://github.com/orgs/Unleash/projects/10) item:
#
-->

### Important files
<!-- PRs can contain a lot of changes, but not all changes are equally
important. Where should a reviewer start looking to get an overview of
the changes? Are any files particularly important? -->


## Discussion points
<!-- Anything about the PR you'd like to discuss before it gets merged?
Got any questions or doubts? -->
2022-11-22 12:07:50 +01:00
Simon Hornby
2a4ca96da2
Permission for variant environments (#2490)
adds permissions for variants per environment
2022-11-22 11:54:04 +02:00
Nuno Góis
137d2caaa4
feat: add details section to overview sidepanel (#2489)
https://linear.app/unleash/issue/2-423/update-feature-toggle-overview-sidepanel
2022-11-22 09:27:19 +00:00
Nuno Góis
ac16e7e3ba
feat: add tags to the new feature overview sidepanel (#2488)
https://linear.app/unleash/issue/2-423/update-feature-toggle-overview-sidepanel
2022-11-22 09:14:57 +00:00
Thomas Heartman
d5fbd0b743
refactor: move docs into new structure / fix links for SEO (#2416)
## What

This (admittedly massive) PR updates the "physical" documentation
structure and fixes url inconsistencies and SEO problems reported by
marketing. The main points are:

- remove or move directories : advanced, user_guide, deploy, api
- move the files contained within to the appropriate one of topics,
how-to, tutorials, or reference
- update internal doc links and product links to the content
- create client-side redirects for all the urls that have changed.

A number of the files have been renamed in small ways to better match
their url and to make them easier to find. Additionally, the top-level
api directory has been moved to /reference/api/legacy/unleash (see the
discussion points section for more on this).

## Why

When moving our doc structure to diataxis a while back, we left the
"physical' files lying where they were, because it didn't matter much to
the new structure. However, that did introduce some inconsistencies with
where you place docs and how we organize them.

There's also the discrepancies in whether urls us underscores or hyphens
(which isn't necessarily the same as their file name), which has been
annoying me for a while, but now has also been raised by marketing as an
issue in terms of SEO.

## Discussion points

The old, hand-written API docs have been moved from /api to
/reference/api/legacy/unleash. There _is_ a /reference/api/unleash
directory, but this is being populated by the OpenAPI plugin, and mixing
those could only cause trouble. However, I'm unsure about putting
/legacy/ in the title, because the API isn't legacy, the docs are. Maybe
we could use another path? Like /old-docs/ or something? I'd appreciate
some input on this.
2022-11-22 09:05:30 +00:00
Nuno Góis
3dca3d53f9
feat: improved feature overview sidepanel env toggles (#2487)
https://linear.app/unleash/issue/2-423/update-feature-toggle-overview-sidepanel
2022-11-22 08:50:31 +00:00
Nuno Góis
93bd9d869a
Variants per environment (frontend) (#2453)
![image](https://user-images.githubusercontent.com/14320932/202286759-b9c30228-59cc-4c58-a7b0-3c6c3d0ecba6.png)
## About the changes

https://linear.app/unleash/issue/2-425/variants-crud-new-environment-cards-with-tables-inside-add-edit-and

Basically created parallel components for the **variants per
environments** feature, so both flows should work correctly depending on
the feature flag state. Some of the duplication means that cleanup
should be straightforward - Once we're happy with this feature it should
be enough to delete
`frontend/src/component/feature/FeatureView/FeatureVariants/FeatureVariantsList`
and do some little extra cleanup.

I noticed we had some legacy-looking code in variants, so this involved
*some* rewriting of the current variants logic. Hopefully this new code
looks nicer, more maintainable, and more importantly **doesn't break
anything**.

Relates to [roadmap](https://github.com/orgs/Unleash/projects/10) item:
#2254

### Important files
Everything inside the
`frontend/src/component/feature/FeatureView/FeatureVariants/FeatureEnvironmentVariants`
folder.
2022-11-18 11:43:24 +00:00
Fredrik Strand Oseberg
978674e33a
feat: update strategy segments with edit / create strategy (#2420)
* Refactors how we add / edit segments to make it more ergonomic to work with in regards to change requests
2022-11-16 15:35:39 +01:00
andreas-unleash
48c340585b
Copy strategy bug fix (#2444)
<!-- Thanks for creating a PR! To make it easier for reviewers and
everyone else to understand what your changes relate to, please add some
relevant content to the headings below. Feel free to ignore or delete
sections that you don't think are relevant. Thank you! ❤️ -->
This PR fixes a bug where when you copy a strategy, instead of the
strategy being copied to the target environment, it was copied to the
source environment

## About the changes
<!-- Describe the changes introduced. What are they and why are they
being introduced? Feel free to also add screenshots or steps to view the
changes if they're visual. -->

<!-- Does it close an issue? Multiple? -->
Closes #

<!-- (For internal contributors): Does it relate to an issue on public
roadmap? -->
<!--
Relates to [roadmap](https://github.com/orgs/Unleash/projects/10) item:
#
-->

### Important files
<!-- PRs can contain a lot of changes, but not all changes are equally
important. Where should a reviewer start looking to get an overview of
the changes? Are any files particularly important? -->


## Discussion points
<!-- Anything about the PR you'd like to discuss before it gets merged?
Got any questions or doubts? -->
2022-11-16 09:43:23 +02:00
Fredrik Strand Oseberg
89f2d81253
fix: copy strategy change request (#2430)
* Fixes a bug where turning off change requests would not turn off change request for copy strategy
2022-11-15 09:49:44 +01:00
Fredrik Strand Oseberg
4689705f45
feat: update hook to use change request settings (#2406)
* Refactors the hook to use the change request settings from the API
2022-11-14 12:34:38 +01:00
Ivar Conradi Østhus
670b97dede
fix: set suggested min value to 0 (#2363)
This PR does one thing, it sets the y-axis to start at "0" when showing
request counts over time.


![image](https://user-images.githubusercontent.com/158948/200946347-b3e803c6-6ace-4ecc-b5cf-aa92a5505331.png)

fixes #2107
2022-11-09 21:43:13 +00:00
Mateusz Kwasniewski
c6f906159b
feat: env check in change requests (#2336) 2022-11-07 09:16:29 +01:00
andreas-unleash
c1e0bd83b0
Frontend - Suggest change copy strategy (#2312)
* Suggest change copy strategy

* Fix merge conflicts

* Copy strategies from other environment added to draft

* Copy strategies from other environment added to draft

* Copy strategies from other environment added to draft

* Copy strategies from other environment added to draft

* fmt

* PR comments

* PR comments

* PR comments

* PR comments

* Fix: Conditionally hide Change Requests tab
2022-11-04 11:33:07 +02:00
Mateusz Kwasniewski
fae7de0d5d
refactor: hook for change requests (#2331)
* refactor: hook for change requests

* Update frontend/src/component/project/Project/ProjectFeatureToggles/ProjectFeatureToggles.tsx

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>

* Update frontend/src/component/project/Project/Project.tsx

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>

* Update frontend/src/component/feature/FeatureView/FeatureOverview/FeatureOverviewEnvSwitches/FeatureOverviewEnvSwitch/FeatureOverviewEnvSwitch.tsx

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>

* Update frontend/src/component/feature/FeatureStrategy/FeatureStrategyRemove/FeatureStrategyRemove.tsx

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>

* fix: fix imports

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
2022-11-04 09:50:00 +01:00
Tymoteusz Czech
0a855604af
feat: review your draft sidebar (#2305)
* refactor playground status chip component

* fix: update change request sidebar

* refactor: status badge cleanup

* fix: prettier formatting
2022-11-02 16:05:27 +01:00
Fredrik Strand Oseberg
9b10a8815b
Feat/review page timeline (#2310)
* fix: styling

* feat: overview timeline

* fix: rename types

* fix: pr comments
2022-11-02 11:14:26 +01:00
sjaanus
5dd8616c74
Rename suggest changes to change request (#2311)
* Rename change request

* Merge with review status

* Move events and permissions
2022-11-02 08:34:14 +02:00
Tymoteusz Czech
b7183fdf98
feat: get suggested changeset draft (#2274)
* feat: get suggested changeset draft

* fix: update routes snapshot
2022-10-28 09:43:49 +02:00
Tymoteusz Czech
c6c873d67d
feat: add changes to draft (#2271)
* feat: add changes to draft

* Make domain type and schema match

* Deleting change from changeset

* Add ability to merge

* Revert "Add ability to merge"

This reverts commit 504e7e796e.

* gRevert "Deleting change from changeset"

This reverts commit 2effc20378.

* Revert "Make domain type and schema match"

This reverts commit 079f46c0db.

Co-authored-by: sjaanus <sellinjaanus@gmail.com>
2022-10-28 09:37:55 +02:00
Tymoteusz Czech
ea2cf144f9
Suggest changes dialog (#2247)
* refactor: suggested changes folder structure

* feat: add dialogue confirmation
2022-10-26 13:57:59 +02:00
sellinjaanus
8270166286
Review your changes - approval flow (#2215)
* Initial changes

* Fix

* continue styling changes review draft

* fix: remove unused import

* update flags snapshot

Co-authored-by: sjaanus <sellinjaanus@gmail.com>
Co-authored-by: Tymoteusz Czech <tymek+gpg@getunleash.ai>
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
2022-10-24 19:15:22 +03:00
Aneesh Relan
1a09d1778b
feat: prettify large numbers in metrics (#2176)
* prettify large numbers

* add tooltip for larger numbers

* add test ids, add unit test

* move dependency to devDependency

* remove unused import

* use conditional render component

* use prettify large number component for feature overview metrics
2022-10-12 16:19:37 +01:00
andreas-unleash
64b8df7ee0
fixed segments not being copied (#2105)
* fixed segments not being copied

* fix fmt

* bug fix

* return segmentId[] when getting a feature strategy

* do not return segments if they are not there

* Update src/lib/services/feature-toggle-service.ts

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>

* fix lint

* fix: more explicit column sorting and bug fix

* update snapshot

* rollback

* add segment ids to feature strategies

* bug fix

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2022-10-10 15:32:34 +03:00
Tymoteusz Czech
c64f9a0e20
fix: toggle strategies ui adjustments (#2030)
* fix: toggle strategies ui adjustments

* fix dark theme type ts issue
2022-09-05 11:00:36 +02:00
olav
e002bd5c81
feat: add counter to variants table (#2029) 2022-08-31 16:01:46 +02:00
Fredrik Strand Oseberg
6818a82cd1 Feat/dark mode exp (#1137)
* feat: add dark mode theme

* fix: feature metrics

* fix: add color

* styling

* fix: add switch

* fix: form sidebar

* fix: remove console log

* fix: add properties

* fix: strategy container

* feat: feature flag

* fix: tests

* fix: build

* fix: logo

* fix: icon

* fix: update snapshots

* fix: CES operator

* fix: typography

* fix: input styling

* fix: remove initial load

* fix: change flag name

* fix: refactor to custom hook

* fix: remove unused import

* fix: dialog headers

* fix: use uiConfig flags instead of flags
2022-08-23 14:20:02 +02:00
olav
d3e853cf7f refactor: fix some @ts-expect-errors (#1216)
* refactor: fix AddonMultiSelector errors

* refactor: fix FeatureOverviewTags errors

* refactor: fix EditProjectRole error

* refactor: fix ProjectCard error
2022-08-11 11:26:08 +02:00
andreas-unleash
e46b75edf0 Merge branch 'main' into task/Add_strategy_information_to_playground_results 2022-08-09 18:04:14 +03:00
olav
b3ac69a2c8 feat: add search to event log pages (#1205)
* feat: add search to event log pages

* refactor: redesign event log pages

* refactor: convert makeStyles to styled components
2022-08-09 16:00:51 +02:00
andreas-unleash
ec55e3e395 Merge branch 'main' into task/Add_strategy_information_to_playground_results 2022-08-08 16:23:15 +03:00
olav
4862ba9dc7 refactor: improve feature sidebar tooltip placement (#1209)
* refactor: improve feature sidebar tooltip placement

* refactor: improve tooltip text
2022-08-08 14:58:22 +02:00
Tymoteusz Czech
85858cf11f refactor strategy item component for reuse
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2022-08-08 11:20:46 +02:00
Tymoteusz Czech
b063cfa180 Merge branch 'main' into task/Add_strategy_information_to_playground_results 2022-08-05 10:23:08 +02:00
Tymoteusz Czech
6eb3922741 Improve drag and drop on strategies (#1203)
* initial drag and drop improvements

* prevent oscillation when dragging strategies by handle
2022-08-05 07:54:15 +00:00
andreas-unleash
7696d7b0bc Merge branch 'main' into task/Add_strategy_information_to_playground_results 2022-08-04 15:50:16 +03:00
Tymoteusz Czech
b7de1fba52 Segment preview (#1194)
* segment preview

* fix: loading and font size inconsistencies

* update segment accordion styles
2022-08-04 14:44:18 +02:00
andreas-unleash
13a536904f Merge branch 'main' into task/Add_strategy_information_to_playground_results
# Conflicts:
#	src/component/common/StrategySeparator/StrategySeparator.tsx
2022-08-04 14:18:21 +03:00
Tymoteusz Czech
0b93776db6 Update UI for strategies - segmentation and for mobile devices (#1189)
* fix: strategies rwd ui updates

* rwd updates to strategies

* add item numbers to strategies

* update strategy segmentation styles
2022-08-04 08:13:07 +00:00
olav
367d8a6a5a refactor: port event pages to TS (#1193) 2022-08-04 08:41:01 +02:00
andreas-unleash
2299eb9305 fmt and lint 2022-08-03 17:20:27 +03:00
andreas-unleash
f62d8d4c35 Merge branch 'main' into task/Add_strategy_information_to_playground_results 2022-08-03 16:23:06 +03:00
andreas-unleash
0d083231a3 parameter handling 2022-08-03 14:03:04 +03:00
Tymoteusz Czech
537bcdc1b7 fix: proper spacing and dividers between strategies (#1187)
* fix: proper spacing and dividers between strategies

* fix: improve strategy execution list logic

* update custom strategy execution styles

* interpret not defined custom strategy parameters
2022-08-03 09:23:57 +02:00
andreas-unleash
1a753a3bcb Merge branch 'main' into task/Add_strategy_information_to_playground_results 2022-08-03 07:13:42 +03:00
Tymoteusz Czech
826c8ff116 copy all strategies into an environment (#1182) 2022-08-02 20:19:29 +02:00
andreas-unleash
4486b8ee11 Merge branch 'main' into task/Add_strategy_information_to_playground_results 2022-08-02 11:57:04 +03:00
olav
0d5f55a706 refactor: lazy-load the charting library (#1184) 2022-08-02 10:23:55 +02:00
olav
710ebe08b3 refactor: fix small issues around custom strategies (#1181)
* refactor: validate strategy name on blur

* refactor: remove strategy parameter type text in favor of docs

* refactor: improve pie chart rendering

* refactor: show icons for all feature strategies

* refactor: fix list parameter add button style
2022-08-02 10:10:01 +02:00