Thomas Heartman
a4c1161285
chore: fix lints on main ( #5877 )
...
These were introduced by prs created before the new biome update.
2024-01-12 11:38:08 +00:00
Thomas Heartman
8ae267ea25
feat: show suspended schedules in timeline ( #5873 )
...
This PR updates the timeline to show suspended schedules. It also adds
"schedule failed" when the schedule has failed.
<img width="465" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/aabbee02-b407-4653-959b-92bec8a1fa66 ">
<img width="465" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/7242c34a-1b1e-4efc-a778-a360e3bc4428 ">
2024-01-12 16:50:08 +05:30
Thomas Heartman
a88763283a
feat: show suspended schedule states in review status ( #5872 )
...
Updates the change request review status box to handle suspended
schedules.
<img width="852" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/2af52b6d-d821-4d30-9166-e8e76ead120d ">
2024-01-12 16:48:58 +05:30
Thomas Heartman
aecc0b54a1
feat: show suspended states in change request badge ( #5871 )
...
This updates the CR badge to show suspended states correctly.
<img width="370" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/f678059b-f72a-46ef-9111-0fc90f228fc8 ">
2024-01-12 16:48:34 +05:30
Christopher Kolstad
5a3bb1ffc3
Biome1.5.1 ( #5867 )
...
Lots of work here, mostly because I didn't want to turn off the
`noImplicitAnyLet` lint. This PR tries its best to type all the untyped
lets biome complained about (Don't ask me how many hours that took or
how many lints that was >200...), which in the future will force test
authors to actually type their global variables setup in `beforeAll`.
---------
Co-authored-by: Gastón Fournier <gaston@getunleash.io>
2024-01-12 09:25:59 +00:00
Thomas Heartman
39145e2617
refactor: use union types for change request types ( #5870 )
...
This changes the two interfaces IChangeRequest and
IChangeRequestSchedule to be union types instead of interfaces. It also
extracts the constituents of those union types into proper types
themselves (so that they can be used in function type signatures etc).
It also updates the type names.
This turned out to be more work than I had imagined, but I think the end
result pays off, giving us more type safety and control.
I wanted to use just `ChangeRequest` for the IChangeRequest type, but
that caused issues due to naming collisions with the `ChangeRequest`
component that we have, causing tests to fail. I've named it
`ChangeRequestType` as a potential solution, but suggestions are
welcome.
The relevant changes are in
`frontend/src/component/changeRequest/changeRequest.types.ts`.
Everything else is updated references and some necessary refactoring to
respect the new types.
2024-01-12 13:15:43 +05:30
Nuno Góis
b496990f79
chore: add no unused imports biome rule ( #5855 )
...
Adds a Biome rule for "no unused imports", which is something we
sometimes have trouble catching.
We're adding this as a warning for now. It is safely and easily fixable
with `yarn lint:fix`.
2024-01-11 12:44:05 +00:00
Fredrik Strand Oseberg
2a723ea9e8
fix: remove empty variants when changing tabs ( #5850 )
...
This PR makes a change to how variants work in the new setup. Variants
will now:
* Be removed if you change tab or unmount the component and it has no
name
* Moved StrategyVariants into a separate component to isolate this
change
* Add error handling around onSubmit and only trigger feedback if it's
successful
2024-01-11 10:43:29 +01:00
andreas-unleash
fbeb5425af
feat: add tooltip to Scheduled badge ( #5726 )
...
Closes #
[1-1831](https://linear.app/unleash/issue/1-1831/enhancement-tooltips-for-change-request-overview-page-to-add-hover )
<img width="1332" alt="Screenshot 2023-12-22 at 12 59 15"
src="https://github.com/Unleash/unleash/assets/104830839/1a851b47-4756-4f3f-a9e6-14067e395738 ">
<img width="1263" alt="Screenshot 2023-12-22 at 12 59 07"
src="https://github.com/Unleash/unleash/assets/104830839/cdce0e81-3e04-4414-8965-13072b282dea ">
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2024-01-09 10:32:52 +02:00
Thomas Heartman
ff96563742
fix: align timeline icon for schedule failures ( #5761 )
...
Aligns the icon to the end of the end of the box to make it match the
text.
Also removes a redundant br element.
2024-01-04 16:04:50 +05:30
Thomas Heartman
795aa18bca
fix: use the correct icon for failed scheduled CRs ( #5760 )
...
This PR switches the notification icon to an exclamation mark (the Error
icon). It updates three components:
1. The badge
2. The timeline
3. The review status
Screenshot with all the replaced icons
2024-01-04 15:44:53 +05:30
Thomas Heartman
1556a51e37
fix: update text in scheduling components ( #5746 )
...
This pr updates the text in some of the scheduling components to be more
clear and consistent.
2024-01-03 18:18:52 +05:30
Thomas Heartman
b0c5baa9d3
chore: format schedule information according to user preferences ( #5747 )
...
This pr uses the user's preferred timezone to display the scheduled
times. If the user has no preferences, the default will be used.
With norwegian locale set as preference:
<img width="1529" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/0072432c-e470-4edc-91fb-864a86bc8f30 ">
With nothing set (falls back to my system setting):
<img width="1529" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/adf3d95f-4015-4302-ac09-e3ba511090db ">
2024-01-03 18:18:43 +05:30
Fredrik Strand Oseberg
049c5b9afa
feat: variant name change on create ( #5742 )
...
This PR refactores the StrategyVariants component to be passed in from
the outside to the new form component. This allows us to pass in the
StrategyVariants with an "editable" property in the create form which we
use to determine the editable state of the name input field. If the
editable field is not passed in we keep the old behavior.
Notable changes:
* StrategyVariants is now passed in from the outside, allowing us to
define different props at call time
* Added tests for the new behavior, and for keeping the old behavior
(such as in edit strategy)
* Added tracking
2024-01-02 13:53:04 +01:00
andreas-unleash
12100b3912
fix: add padding to warning banner ( #5720 )
...
Closes #
[1-1830](https://linear.app/unleash/issue/1-1830/potential-conflict-warning-add-padding-8px )
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-12-21 14:58:17 +02:00
andreas-unleash
aea18d1ac4
fix: review status title color ( #5716 )
...
Closes #
[1-1825](https://linear.app/unleash/issue/1-1825/change-the-color-of-the-scheduled-and-pending-state-to-warningdark )
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-12-21 14:38:33 +02:00
andreas-unleash
e0f83347ab
fix: hide variant diff if no change in ChangeRequestOverview ( #5715 )
...
Closes #
[1-1813](https://linear.app/unleash/issue/1-1813/do-not-show-variants-table-in-change-request-when-no-variant-change )
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-12-21 10:39:18 +02:00
Mateusz Kwasniewski
f3ca4f0c54
chore: upgrading vite to newer version ( #5703 )
2023-12-20 14:48:18 +01:00
andreas-unleash
0f8a6661a8
Feat: allow rescheduling of failed scheduled cr ( #5702 )
...
Allows for rescheduling failed scheduled requests
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-12-20 15:19:23 +02:00
andreas-unleash
75bdd73c15
feat: add plausible tracking to scheduling ( #5668 )
...
Adds plausible tracking with actions:
- scheduled-created
- scheduled-updated
- scheduled-rejected
- scheduled-applied
Closes #
[1-1630](https://linear.app/unleash/issue/1-1630/add-plausible-metrics )
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-12-18 15:06:58 +02:00
andreas-unleash
7fdd720aa3
feat: show failure in cr overview ( #5660 )
...
Show failure reason in change request overview
Closes
[1-1769](https://linear.app/unleash/issue/1-1769/add-reason-and-icon-to-change-request-overview )
<img width="771" alt="Screenshot 2023-12-15 at 10 37 03"
src="https://github.com/Unleash/unleash/assets/104830839/898b6ac9-bd44-442f-92a4-9b4d5754fea7 ">
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-12-18 11:37:56 +02:00
Fredrik Strand Oseberg
864ae4530b
Feat/new strategy configuration header ( #5655 )
...
This PR adds more information to the header of the strategy according to
the new designs:
<img width="1298" alt="Skjermbilde 2023-12-15 kl 13 31 26"
src="https://github.com/Unleash/unleash/assets/16081982/73a3bc6b-c78b-4f24-b9f3-8a4b2c14e39c ">
2023-12-15 14:09:47 +01:00
andreas-unleash
a595c0fbcc
feat: show failure reason for scheduled requests in timeline ( #5639 )
...
Adds an icon with a tooltip and changes the dot color to red for
scheduled change requests
Closes #
[1-1768](https://linear.app/unleash/issue/1-1768/add-reason-and-icon-to-timeline )
<img width="1668" alt="Screenshot 2023-12-14 at 10 20 27"
src="https://github.com/Unleash/unleash/assets/104830839/dcf54834-ea9f-4e78-b69d-15d6179ffce3 ">
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-12-14 11:49:14 +02:00
andreas-unleash
cbd50ac0f5
Feat: show status of scheduled change request ( #5630 )
...
Modifies the ChangeRequestStatusBadge to display the failed execution
Closes #
[1-1767](https://linear.app/unleash/issue/1-1767/add-status-to-scheduled-badge )
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-12-14 11:49:03 +02:00
Fredrik Strand Oseberg
9dbb7ea9a9
feat: add initial setup for tabs ( #5586 )
...
This PR sets up the initial tab structure for the new strategy form
2023-12-11 13:39:21 +01:00
Thomas Heartman
a0a15416c4
feat: display potential conflicts in existing change requests ( #5521 )
...
This update displays schedule conflicts in active change requests (any
CR that isn't applied, canceled, or rejected).
2023-12-04 13:33:28 +01:00
andreas-unleash
02451baaf2
feat: hide change actions when change request is scheduled ( #5514 )
...
Added 'Scheduled' state to the check for non-pending change requests
Closes #
[1-1680](https://linear.app/unleash/issue/1-1680/remove-edit-change-ui-when-cr-is-scheduled )
<img width="868" alt="Screenshot 2023-11-30 at 11 54 44"
src="https://github.com/Unleash/unleash/assets/104830839/8e6afec5-1353-4030-b49b-4a8f3eaee5f6 ">
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-30 12:52:29 +02:00
andreas-unleash
8ffc92af5b
fix: Only show strategy variant changes if there is a diff in the variants ( #5353 )
...
What it says on the box
Closes #
[1-1652](https://linear.app/unleash/issue/1-1652/remove-the-variants-from-change-request-page-when-not-modified )
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-22 09:50:03 +02:00
andreas-unleash
0dc5f306cc
Feat: change request scheduled timeline ( #5346 )
...
Adds the scheduled state to the timeline
Closes #
[1-1632](https://linear.app/unleash/issue/1-1632/update-the-progress-bar-for-scheduled-changes )
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-17 11:20:14 +02:00
Jaanus Sellin
069d90d8cb
fix: date should sort asc/desc properly ( #5335 )
2023-11-14 14:47:28 +02:00
andreas-unleash
180c0dceae
Fix/scheduled request UI ( #5318 )
...
Change timezone format
Fixes a bug where the Edit button on hover being elongated
Before:
<img width="755" alt="Screenshot 2023-11-09 at 21 36 01"
src="https://github.com/Unleash/unleash/assets/104830839/189f21d5-8a68-4d6b-b094-b518749a9b2f ">
After:
<img width="812" alt="Screenshot 2023-11-09 at 22 09 26"
src="https://github.com/Unleash/unleash/assets/104830839/9056f995-bd2b-4353-8526-77160e49e990 ">
Adds the missed onClick to the edit button to show the dialog
Fixes a bug with ScheduleChangesDialog onClose
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-10 11:22:03 +02:00
andreas-unleash
100c22b42a
Feat: scheduled change request badges ( #5300 )
...
Adds a new badge to strategies that have changes in an a scheduled
change request
Closes #
[1-1620](https://linear.app/unleash/issue/1-1620/create-a-new-badge-for-flag-that-is-part-of-scheduled-change )
<img width="1671" alt="Screenshot 2023-11-09 at 11 49 53"
src="https://github.com/Unleash/unleash/assets/104830839/596abbc0-f9ab-4642-9ed2-79ef50fb6c05 ">
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.io>
2023-11-09 13:48:29 +02:00
andreas-unleash
3e9d88f789
Feat/scheduled cr UI tests ( #5296 )
...
Ui tests scheduled change requests
Closes # [1-1598](https://linear.app/unleash/issue/1-1598/e2e-ui-tests )
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.io>
2023-11-08 14:28:16 +02:00
Tymoteusz Czech
06d62278dc
fix: change request table sort type ( #5295 )
2023-11-07 17:13:43 +01:00
andreas-unleash
addda5b022
feat: schedule changes dialog ( #5285 )
...
Closes: #
[1-1585](https://linear.app/unleash/issue/1-1585/reschedule-changes-dialog )
[1-1582](https://linear.app/unleash/issue/1-1582/change-apply-changes-apply-or-schedule-changes )
Manually tested e2e -> Approve -> Schedule -> Reschedule ->
Apply/Reject: ui tests verifying it in next pr
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
2023-11-07 10:59:49 +02:00
andreas-unleash
2262ca1be6
Feat: scheduled change request dialogs ( #5267 )
...
Creates the Apply and Reject scheduled change request dialogs
Closes #
[1-1584](https://linear.app/unleash/issue/1-1584/add-modal-for-apply-now )
Closes #
[1-1586](https://linear.app/unleash/issue/1-1586/reject-changes-dialog )
<img width="1669" alt="Screenshot 2023-11-03 at 14 43 17"
src="https://github.com/Unleash/unleash/assets/104830839/832edb8e-1da1-4d96-a5c3-4fa0cd336fea ">
<img width="1669" alt="Screenshot 2023-11-03 at 14 43 28"
src="https://github.com/Unleash/unleash/assets/104830839/f9028671-e5e1-441c-886b-1e562c83f214 ">
UI e2e tests will be in a follow up PR
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-06 11:13:50 +02:00
andreas-unleash
6b637d5fa9
feat: scheduled change request state ( #5261 )
...
Adds the scheduled state to ChangeRequestOverview.tsx
<img width="1523" alt="Screenshot 2023-11-03 at 12 52 07"
src="https://github.com/Unleash/unleash/assets/104830839/710b5f26-04a0-4ee9-b646-8ff3090ad86a ">
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2023-11-03 15:02:51 +02:00
Thomas Heartman
7cf998c509
fix: move useUiFlag before "return null" to avoid rendering more hooks on the first render ( #5258 )
...
Move the hook to before the first return to avoid React erroring out.
2023-11-03 10:04:03 +00:00
Thomas Heartman
9fbb61a1c4
chore: add schedule option to approved change requests ( #5252 )
...
The button doesn't do anything at the moment, but it's there visually.
Because this uses the same button as the dual-function button for
approve/reject, I extracted that component into a reusable
"multi-action" button. I could have copied the code wholesale, but it's
a complex component, so I thought this would be a better solution.
I'll add the dialog in a follow-up PR. This one already has a lot of
changes.
Visual:
2023-11-03 08:46:06 +01:00
Nuno Góis
347c1cabbc
feat: add new sticky component to handle stacked stickies ( #5088 )
...
https://linear.app/unleash/issue/2-1509/discovery-stacked-sticky-elements
Adds a new `Sticky` element that will attempt to stack sticky elements
in the DOM in a smart way.
This needs a wrapping `StickyProvider` that will keep track of sticky
elements.
This PR adapts a few components to use this new element:
- `DemoBanner`
- `FeatureOverviewSidePanel`
- `DraftBanner`
- `MaintenanceBanner`
- `MessageBanner`
Pre-existing `top` properties are taken into consideration for the top
offset, so we can have nice margins like in the feature overview side
panel.
### Before - Sticky elements overlap 😞
### After - Sticky elements stack 😄
2023-10-19 15:50:37 +01:00
Mateusz Kwasniewski
af50fc2fd3
feat: visualize dependencies managment in change requests ( #4978 )
2023-10-10 10:36:13 +02:00
Mateusz Kwasniewski
80eb6e12c6
refactor: custom render should provide container ( #4938 )
2023-10-06 09:19:49 +02:00
Gastón Fournier
bd8b54b5bd
fix: yarn lint:fix ( #4917 )
...
## About the changes
Running yarn lint:fix solves errors in frontend
2023-10-04 11:28:05 +02:00
andreas-unleash
c1f8929ddf
fix: separate project and project enterprise settings forms ( #4911 )
...
Separates ProjectForm and ProjectEnterpriseSettings forms
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
2023-10-04 10:42:02 +03:00
Nuno Góis
4167a60588
feat: biome lint frontend ( #4903 )
...
Follows up on https://github.com/Unleash/unleash/pull/4853 to add Biome
to the frontend as well.
Added a few `biome-ignore` to speed up the process but we may want to
check and fix them in the future.
2023-10-02 13:25:46 +01:00
Mateusz Kwasniewski
40dfb927e9
feat: parent and child info in feature overview header ( #4901 )
2023-10-02 11:47:48 +02:00
Fredrik Strand Oseberg
d3e01d84d9
fix: account for array length ( #4849 )
...
Small fix to account for array length in conditional check
2023-09-27 15:12:01 +02:00
Fredrik Strand Oseberg
cefbf01934
feat: visualize feature variants on cr ( #4809 )
...
Adds a view over feature strategy variants on addStrategy or
editStrategy action
2023-09-22 16:17:41 +02:00
Mateusz Kwasniewski
a0fbad26bf
feat: persistent search queries ( #4624 )
2023-09-06 15:46:10 +02:00
Mateusz Kwasniewski
2b85eed5b5
feat: Search UI improvements ( #4613 )
2023-09-06 10:50:20 +02:00
