1
0
mirror of https://github.com/Unleash/unleash.git synced 2024-12-22 19:07:54 +01:00
Commit Graph

2301 Commits

Author SHA1 Message Date
andreas-unleash
61c8c4d66b bug fix 2022-07-29 11:37:44 +03:00
andreas-unleash
a0a7c83366 Playground context value 2022-07-29 11:16:14 +03:00
andreas-unleash
9e38cf3ff9 Playground result segments, constraints initial 2022-07-29 08:52:22 +03:00
andreas-unleash
352a4cca13 Playground result info structure and initial styles 2022-07-28 19:23:38 +03:00
andreas-unleash
cdaf7299be Merge branch 'main' into task/Add_strategy_information_to_playground_results 2022-07-28 16:52:41 +03:00
Christopher Kolstad
edb093f1ab 4.14.1 2022-07-28 15:35:50 +02:00
Christopher Kolstad
ff6ef4ae5a Update release changelog to flag prereleases properly 2022-07-28 15:34:58 +02:00
Christopher Kolstad
0f93743772 4.14.0 2022-07-28 15:30:25 +02:00
Nuno Góis
4e61cf22c0 fix: small ui fixes related to groups and tooltips (#1167) 2022-07-28 15:27:38 +02:00
Tymoteusz Czech
d7b168e4a8 fix: add permission lock to quick strategy add (#1165) 2022-07-28 13:02:41 +00:00
andreas-unleash
e894cbb52a Playground result info modal initial 2022-07-28 15:16:40 +03:00
Tymoteusz Czech
c79465e7d9 fix: refetch immutable toggle when adding strategy (#1164) 2022-07-28 12:45:08 +01:00
andreas-unleash
562ca62b42 Merge branch 'main' into task/Add_strategy_information_to_playground_results 2022-07-28 14:34:47 +03:00
Tymoteusz Czech
850c7a26db fix: minor ui improvements (#1163) 2022-07-28 12:05:48 +02:00
Tymoteusz Czech
c20aa300ce Visual updates to constraints (#1157) 2022-07-28 09:34:15 +02:00
renovate[bot]
7df59cf286 chore(deps): update dependency @types/react to v17.0.48 2022-07-28 00:23:27 +00:00
renovate[bot]
fe36779927 chore(deps): update dependency vite-plugin-svgr to v2.2.1 2022-07-27 21:40:34 +00:00
renovate[bot]
aaa16cbf21 chore(deps): update dependency vite to v2.9.14 2022-07-27 19:29:52 +00:00
renovate[bot]
0dc3ae2af9 chore(deps): update dependency tss-react to v3.7.1 2022-07-27 16:14:18 +00:00
andreas-unleash
1d83643e15 Playground result info modal initial 2022-07-27 18:48:17 +03:00
renovate[bot]
5ea9de021e chore(deps): update dependency chart.js to v3.8.2 2022-07-27 13:43:21 +00:00
renovate[bot]
c4da09a050 chore(deps): pin dependencies (#1155)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
2022-07-27 11:56:50 +00:00
andreas-unleash
c3e9b49e12 Fix/constraint card adjustments (#1154)
* style fixes

* Constraint card styling adjustments

* Style Fixes

* lint and fmt

* lint and fmt

* Changed the way the expandable property is evaluated to use the text.length

Co-authored-by: Tymoteusz Czech <tymek+gpg@getunleash.ai>
2022-07-27 13:50:47 +02:00
Tymoteusz Czech
c70b38a62a Feature toggle page update (#1140)
* feat: add icon to custom strategies

* feat: update feature toggle screen layout

* strategy and constraints separators

* style disabled envirnments

* strategy constraint style

* strategy drag and drop

* feature env emtpy state

* quick add strategy api

* reorder strategies api integration

* feature strategy header title

* openapi update

* style small chip component

* fix comments after review

* fix issues with strategy constraint operators

* Revert "openapi update"

This reverts commit 27e7651ebae26f61ca76ec910e1f209bae7f2955.

* fix tooltip ref
2022-07-27 10:00:15 +00:00
renovate[bot]
d1d23d1b4c chore(deps): update metcalfc/changelog-generator action to v3 (#513)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Christopher Kolstad <chriswk@getunleash.ai>
2022-07-27 09:42:53 +00:00
sjaanus
00ab52875e Delete archived toggles from the front end (#1150)
* Grouping fix grid not showing user names

* Remove deprecated access endpoints

* Manual prettier

* Revert user role update

* Add a way to delete archived toggles from the front end

* Fix layout

* Add project to permissionbutton

* Prettier

* Minor fixes

* Run prettier
2022-07-27 07:46:12 +00:00
Nuno Góis
61c0d6f0a1 refactor: create user avatar component, clean up (#1151)
* refactor: create user avatar component, clean up

* fix: small changes regarding the new badge component
2022-07-26 18:50:19 +01:00
Fredrik Strand Oseberg
e59d516aae Merge branch 'main' into task/constraint_card_adjustmnets 2022-07-26 14:47:35 +02:00
sjaanus
ca08e659b0 New release (#1153) 2022-07-26 12:41:26 +00:00
sjaanus
ec544a02f2 Grouping access endpoint (#1152)
* Grouping access endpoint

* Remove default values
2022-07-26 12:02:54 +00:00
andreas-unleash
a13e771f0e Lint and fmt 2022-07-26 13:39:58 +03:00
andreas-unleash
3c23fb554e Merge branch 'main' into task/constraint_card_adjustmnets 2022-07-26 13:10:45 +03:00
andreas-unleash
9ce7572ba0 PR comments 2022-07-26 13:10:30 +03:00
Nuno Góis
65c0580519 fix: pro flow stripe integration refinements (#1149) 2022-07-26 08:50:27 +01:00
Fredrik Strand Oseberg
23b9cbaf03 fix: truncator (#1148)
* fix: truncator

* Update src/component/common/StringTruncator/StringTruncator.tsx

Co-authored-by: Thomas Heartman <thomas@getunleash.ai>

Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
2022-07-26 08:58:57 +02:00
Fredrik Strand Oseberg
d4f46eaf2e feat: lazy load playground (#1145)
* feat: lazy load playground

* fix: app.tsx

* fix: add suspense

* fix: update snapshot
2022-07-25 16:01:58 +02:00
sighphyre
3a811b66d6 4.14.0-beta.5 2022-07-25 12:42:16 +02:00
sjaanus
e95825a000 Feat/grouping fixes (#1146)
* Grouping fix grid not showing user names

* Remove deprecated access endpoints

* Manual prettier

* Revert user role update
2022-07-25 10:14:02 +00:00
andreas-unleash
f99937a334 Merge remote-tracking branch 'origin/task/constraint_card_adjustmnets' into task/constraint_card_adjustmnets 2022-07-25 11:13:28 +03:00
andreas-unleash
37669fadb8 bug fix 2022-07-25 11:13:21 +03:00
andreas-unleash
1f309fb35e Merge branch 'main' into task/constraint_card_adjustmnets 2022-07-25 09:34:26 +03:00
andreas-unleash
70e8df83b5 bug fix 2022-07-25 09:30:04 +03:00
sjaanus
d9822bead0 Create a custom group popover for avatars (#1143)
* Create a custom group tooltip for avatars

* Remove data attribute

* Fix naming convention

* Fix naming convention

* Run prettier manually

* Prettier malfunction fix

Co-authored-by: Jaanus Sellin <jaanus@getunleash.ai>
2022-07-22 12:27:19 +00:00
andreas-unleash
9a13c5c489 Merge remote-tracking branch 'origin/task/constraint_card_adjustmnets' into task/constraint_card_adjustmnets 2022-07-22 14:41:22 +03:00
andreas-unleash
54f62d610f styling fixes 2022-07-22 14:41:14 +03:00
andreas-unleash
6d405c9af5 Merge branch 'main' into task/constraint_card_adjustmnets 2022-07-22 14:34:13 +03:00
andreas-unleash
408f24dcdd styling fixes 2022-07-22 14:33:15 +03:00
Fredrik Strand Oseberg
d4fcf52020 feat/playground-second-iteration (#1139)
* fix: rearrange ui

* fix: make request on load

* fix: default to the first environment

* feat: add codemirror

* fix: layout

* fix: styling

* feat: add popover

* feat: variant popover

* fix: add sticky

* feat: resolve input

* refactor: date field

* fix: move deps

* fix: clean up any

* fix: resolve import

* fix: hide columns on mobile

* fix: search style

* fix: rename styles

* fix: PR comments

* fix: add popover for guidance

* fix: guidance popover

* fix: verbose function

* fix: wording

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
2022-07-22 13:15:28 +02:00
andreas-unleash
103ccc96d9 add help tooltip 2022-07-22 14:06:47 +03:00
andreas-unleash
44cefd9bcd add help tooltip 2022-07-22 14:06:29 +03:00
andreas-unleash
d617eaaefc bug fix 2022-07-22 14:05:15 +03:00
andreas-unleash
47c33e62e1 bug fix 2022-07-22 13:56:27 +03:00
andreas-unleash
5feee0d2d8 Merge remote-tracking branch 'origin/task/constraint_card_adjustmnets' into task/constraint_card_adjustmnets 2022-07-22 13:40:32 +03:00
andreas-unleash
d23092ca8a bug fix 2022-07-22 13:40:22 +03:00
andreas-unleash
d524222ffa Merge branch 'main' into task/constraint_card_adjustmnets 2022-07-22 13:34:59 +03:00
andreas-unleash
1cb632b561 Comment fixes and polishing 2022-07-22 13:34:39 +03:00
sighphyre
19cf253773 4.14.0-beta.4 2022-07-22 11:30:51 +02:00
andreas-unleash
5ea7e8781f Merge remote-tracking branch 'origin/task/constraint_card_adjustmnets' into task/constraint_card_adjustmnets 2022-07-22 12:27:18 +03:00
andreas-unleash
19b7e92546 Bug fixes 2022-07-22 12:27:04 +03:00
andreas-unleash
b96ef9ff8e Merge branch 'main' into task/constraint_card_adjustmnets 2022-07-22 10:35:32 +03:00
Nuno Góis
df6208e309 feat: add user groups (#1130)
* feat: add user groups table

* add groups and group view

* fix top level await on mock data

* add UG flag

* create group files, refactor group cards

* add generic badge component

* adapt hooks to use endpoints

* implement basic create group

* fix: update snap

* fix: type id as string for now

* implement create group, use api, refactoring

* add stars to group owners

* refactor GroupForm.tsx to use styled components

* feat: remove group

* add edit group

* add group card actions

* feat: edit and remove group users

* add users to groups

* Initial commit

* refine project access table

* add project access group view

* Take users and groups from backend

* Add onsubmit

* new project access, assign and edit

* fix EditGroup, Group

* Finish assigning roles in project

* List assigned projects in group card

* Run prettier

* Add added column to project access table

Co-authored-by: Jaanus Sellin <jaanus@getunleash.ai>
Co-authored-by: sighphyre <liquidwicked64@gmail.com>
2022-07-22 07:31:08 +00:00
andreas-unleash
d65c3b4915 Fix build 2022-07-22 09:53:42 +03:00
andreas-unleash
d66359f6a4 Merge branch 'main' into task/constraint_card_adjustmnets 2022-07-22 09:43:53 +03:00
andreas-unleash
d6d8a9ddb4 Refactored to single responsibility components 2022-07-22 09:40:51 +03:00
andreas-unleash
f6b6aa0ae8 Refactored to single responsibility components 2022-07-22 09:40:08 +03:00
andreas-unleash
c16272ec26 Constraint View header adjustments 2022-07-21 15:27:29 +03:00
andreas-unleash
9316b633a2 Constraint View header adjustments 2022-07-21 15:22:49 +03:00
Christopher Kolstad
e5b2f907e4 feat: Wrap addons form in FormTemplate (#1138)
* feat: Wrap addons form in FormTemplate

* Change styled button section
2022-07-21 14:02:17 +02:00
andreas-unleash
f34aafade5 Create/edit constraint adjustments 2022-07-21 14:15:21 +03:00
andreas-unleash
c0796f3c21 Create/edit constraint adjustments 2022-07-21 14:12:30 +03:00
andreas-unleash
7f0a0afb84 Constrain card adjustments 2022-07-20 15:42:13 +03:00
andreas-unleash
e33ed6b8e7 Make accordion expand dependent on text width 2022-07-20 13:01:25 +03:00
andreas-unleash
ffc0c0a229 Make accordion expand dependent on text width 2022-07-20 10:17:26 +03:00
Christopher Kolstad
4c5eb20e09 Task/filter addon by project and environment (#1133)
* feat: add project and environments filters for addons

Co-authored-by: Simon Hornby <liquidwicked64@gmail.com>
2022-07-14 12:55:37 +02:00
Fredrik Oseberg
235bf428fe 4.14.0-beta.1 2022-07-14 09:47:39 +02:00
sellinjaanus
625cc43ef9 Fixed naming (#1134) 2022-07-14 07:07:25 +00:00
Tymoteusz Czech
9d74fd976d Refine playground form (#1136)
* integrate results table with playground form

* fix playground api integration

* fix: playground loading state from api
2022-07-13 14:35:43 +00:00
andreas-unleash
8f4f1f6f5f Fix PR commments 2022-07-13 09:47:22 +03:00
andreas-unleash
e8a77d4928 Fix PR commments 2022-07-13 09:40:39 +03:00
andreas-unleash
672d948d24 Playground results light 2022-07-12 18:13:18 +03:00
Tymoteusz Czech
2e94cd660c Playground form (#1129)
* playground form

* playground context fields

* playground interactive json form

* add playground route

* remove memo from select options generation

* add toast when playground context parsing fails

* add error handling when adding a fiedl to playground context

* remove playground context options memo
2022-07-08 09:35:32 +02:00
andreas-unleash
69f4b73b16 Merge branch 'main' into meta/add-stalebot 2022-07-07 13:27:41 +03:00
Thomas Heartman
8db75dd923 meta: add stale bot config (reference unleash/.github)
This change adds a stale bot configuration with a reference to the [org-wide Unleash configuration](https://github.com/Unleash/.github/blob/main/.github/stale.yml).

## About the change

We're adding stale bot as a way to help us manage issues that don't see any activity. When that happens, it's usually because we don't have further resources to work on something or because we're missing information. These issues often go forgotten and end up lying around open. This is an attempt to get around that.

The config file contains the details for how long the bot waits before touching an issue and then how much longer before it closes it if no further activity occurs. (Currently set to 30 and 10 days respectively.)

## Keeping issues open

If there are long-standing issues that should _not_ be closed or marked as stale, you can label it with one of the `exemptLabels` in the stale config file (for instance: `pinned`). That'll keep stale bot from touching the issue at all.

## For maintainers

We know there are differing views on whether stale bots are healthy or not, and we would not want to impose a bot on a repo that we do not control. So if you're not sure this is a good idea (or if you're sure that it _isn't_), let us know, and we'll have a discussion. If we come to the conclusion that it's not the right decision (for whatever reason), then we're happy to leave the bot out.

Further, if you're happy to accept the stale bot, but don't like the org-wide configuration, then we can also override parts or all of the config to make it fit better with this repo.
2022-07-05 09:51:53 +02:00
renovate[bot]
7d1c23717f chore(deps): update dependency vitest to v0.16.0 2022-06-28 19:53:44 +00:00
renovate[bot]
75b3107808 chore(deps): update dependency vite-plugin-svgr to v2.2.0 2022-06-28 16:30:49 +00:00
Christopher Kolstad
dd2e04990f 4.14.0-beta.0 2022-06-28 14:21:52 +02:00
Tymoteusz Czech
c0b52fa672 Fix: UI improvements (#1114)
* fix: segments table author column width

* fix: update feature form ui

* fix: strategies breadcrumbs

* fix: api token page title

* fix: deprecated strategy label color

* fix: project access remove user toast

* fix: addon enable toast message

* fix: ces from ui

* fix: ui improvements with dialog typography

* fix: revert ces

* fix: change password error type
2022-06-28 12:58:10 +02:00
olav
566d0613a4 refactor: improve password error handling (#1118)
* refactor: improve password error handling

* Update src/component/user/common/ResetPasswordForm/PasswordChecker/PasswordChecker.tsx

Co-authored-by: Thomas Heartman <thomas@getunleash.ai>

Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
2022-06-28 09:47:22 +02:00
Nuno Góis
38cfc549f2 fix: copy feature double validation popup (#1117)
* fix: copy feature double validation popup

* fix: add aria-required, validate on submit

* refactor: rename variable to be more consistent with codebase
2022-06-28 07:54:31 +01:00
renovate[bot]
853d763194 chore(deps): update dependency sass to v1.53.0 2022-06-28 04:38:12 +00:00
renovate[bot]
4a5676293d chore(deps): update dependency @testing-library/dom to v8.14.0 2022-06-28 01:24:27 +00:00
renovate[bot]
d22dd96304 chore(deps): update material-ui monorepo 2022-06-27 22:56:12 +00:00
renovate[bot]
89545611ae chore(deps): update dependency vite to v2.9.13 2022-06-27 20:03:55 +00:00
renovate[bot]
e36ae52162 chore(deps): update dependency msw to v0.42.3 2022-06-27 16:48:59 +00:00
renovate[bot]
afd36a6cf1 chore(deps): update dependency jsdom to v20 (#1106)
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
2022-06-27 12:53:07 +00:00
olav
685e94bab7 fix: wrap long words in toast text (#1119) 2022-06-27 13:39:50 +02:00
olav
68bfde58f7 fix: use correct docs API URL for feature strategy create/update (#1116)
* fix: use correct URL for update feature strategy

* fix: use correct URL for create feature strategy
2022-06-23 12:05:06 +02:00
olav
625a92ca74 refactor: fix instance status modal close button (#1115)
* refactor: fix instance status modal close button

* refactor: only close the modal on button click
2022-06-23 10:29:17 +02:00
Nuno Góis
9ca2b6fc46 feat: add stripe integration (#1109)
* feat: add stripe integration

* add start:demo yarn script
2022-06-23 07:54:08 +01:00
olav
7a6321746c refactor: improve segment warning texts 2022-06-22 14:58:36 +02:00
olav
b21ae4164d refactor: remove outdated root role info text (#1112)
* refactor: remove unused imports

* refactor: remove outdated root role info text
2022-06-22 14:58:05 +02:00
olav
7d909c6b66 refactor: show env buttons when missing permission (#1111)
* refactor: disable environment drag-and-drop when missing permission

* refactor: show env buttons when missing permission
2022-06-22 13:13:08 +02:00
Nick
b4197e54e6 fix: input fields (PR #1110 from NickMolloy/improve-input-attributes)
* Use correct input type

"string" is not a valid input type: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input#input_types
"text" is the actual valid value.

* Use correct autocomplete values for credential fields
"true", "on", and "confirm-password" are not valid autocomplete values https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete
2022-06-22 11:05:03 +02:00
sellinjaanus
797cd8c28f chore: remove splash environment (#1108)
* chore: remove splash environment

* Remove related images aswell

Co-authored-by: sighphyre <liquidwicked64@gmail.com>
2022-06-21 16:31:14 +03:00
olav
583d636144 refactor: fix handling of expired/churned trial states (#1107) 2022-06-21 11:22:27 +02:00
Tymoteusz Czech
9522c59674 Refactor project health table (#1098)
* minor archive table updates

* archived date cell

* archive import paths

* move project health table files

* fix: align actions cells

* simplify health table row mapping

* fix project pages browser tab title

* initial draft of virtualized table component

* refactor: virtualized table common component

* fix: health report name cell width

* refactor: report cell paths
2022-06-21 09:08:37 +02:00
renovate[bot]
c9aed1e6e2 chore(deps): update dependency eslint to v8.18.0 2022-06-18 03:44:42 +00:00
renovate[bot]
f05e91c2a5 chore(deps): update dependency typescript to v4.7.4 2022-06-18 00:48:48 +00:00
renovate[bot]
5709fa8ac8 chore(deps): update dependency @types/react to v17.0.47 2022-06-17 21:58:21 +00:00
renovate[bot]
a7b3cf2a7e chore(deps): update dependency @testing-library/user-event to v14.2.1 2022-06-17 18:52:44 +00:00
renovate[bot]
7bffb67b76 chore(deps): update dependency prettier to v2.7.1 2022-06-17 15:51:46 +00:00
olav
69171a75a7 refactor: improve button label markup (#1091)
* refactor: improve button label markup

* refactor: remove misused tooltip roles

* refactor: simplify FeatureStrategyIcon labelling

* refactor: simplify labels for disabled buttons

* refactor: add missing switch input labels
2022-06-17 11:27:54 +02:00
Renovate Bot
accf9294c8 chore(deps): update dependency @types/semver to v7.3.10 2022-06-15 20:51:19 +00:00
Renovate Bot
b38f5e21f1 chore(deps): update dependency vitest to v0.15.1 2022-06-15 17:12:39 +00:00
Tymoteusz Czech
37fa469faf Archive table updates (#1097)
* minor archive table updates

* archived date cell

* archive import paths
2022-06-15 16:16:42 +03:00
Renovate Bot
522f4aed41 chore(deps): update dependency vitest to v0.15.0 2022-06-15 01:07:54 +00:00
Renovate Bot
dffb4e1514 chore(deps): update material-ui monorepo 2022-06-14 22:03:20 +00:00
Renovate Bot
bb22a1fe24 chore(deps): update dependency prettier to v2.7.0 2022-06-14 18:40:51 +00:00
olav
4fb0be3710 fix: show previous invoices page if UNLEASH_CLOUD is falsy (#1094)
* fix: restore previous invoices page

* fix: show previous invoices page if UNLEASH_CLOUD is falsy

* fix: use correct amountFormatted invoice field name
2022-06-14 15:41:28 +02:00
Tymoteusz Czech
51e5939f68 feat: Align switches in table actions (#1082)
* feat: strateges state changing switch

* refactor: ActionCell for table

* fix: remove image clipping for webhook icons

* feat: align addons switch in table

* feat: align enviromnemnts table switch

* fix: disallow turning off protected environment

* refactor: move environment table sub-components

* feat: add predefined badge to default environment

* feat: environment reorder handle hightlight

* fix: environment table padding when searching

* Update src/hooks/api/actions/useStrategiesApi/useStrategiesApi.ts

Co-authored-by: olav <mail@olav.io>

* refactor: toggle addon promise

* remove dragging highlight

* fix: strategy switch tooltip

* fix: switch tooltips

Co-authored-by: olav <mail@olav.io>
2022-06-14 12:32:16 +00:00
andreas-unleash
bfbbf57de0 Merge branch 'main' into archive_table 2022-06-14 13:22:35 +03:00
olav
864f70624f 4.13.0-beta.1 2022-06-14 12:15:26 +02:00
Tymoteusz Czech
aaaefa864d Merge branch 'main' into archive_table 2022-06-14 11:51:29 +02:00
olav
f46047f10a refactor: fix trial expiration calculations (#1090)
* refactor: fix trial expiration calculations

* refactor: count full trial days for warning banner

* refactor: fix flaky test
2022-06-14 11:51:11 +02:00
Tymoteusz Czech
ee2d852ef2 fix: search clear bug 2022-06-14 11:48:49 +02:00
Tymoteusz Czech
b1d9437d99 Merge branch 'main' into archive_table 2022-06-14 11:43:06 +02:00
Tymoteusz Czech
67a4f2e67f remove unused TableSearch 2022-06-14 11:42:12 +02:00
Tymoteusz Czech
7bfe7201c0 fix: simplified empty archive list page 2022-06-14 11:28:40 +02:00
Tymoteusz Czech
349106a2be fix: sort order across the app
discussed with Nicolae and Nuno
2022-06-14 11:14:56 +02:00
olav
aaa540fc1c 4.13.0-beta.0 2022-06-14 10:11:35 +02:00
Tymoteusz Czech
1d8c286c79 fix archive type column 2022-06-14 09:36:33 +02:00
Tymoteusz Czech
f35d3a4881 update table search and columns width 2022-06-14 09:32:04 +02:00
Tymoteusz Czech
439d7c1745 hide project column on project archive 2022-06-14 09:19:41 +02:00
Tymoteusz Czech
fdac3a6eaf fix archive row virtualization 2022-06-14 09:16:27 +02:00
andreas-unleash
de8119961f Merge branch 'main' into archive_table 2022-06-14 09:14:31 +03:00
Renovate Bot
bd67dcbd31 chore(deps): update dependency immer to v9.0.15 2022-06-13 23:50:42 +00:00
Renovate Bot
9f99722f40 chore(deps): update emotion monorepo to v11.9.3 2022-06-13 19:38:57 +00:00
Tymoteusz Czech
6cb0837fec Merge remote-tracking branch 'origin/main' into archive_table 2022-06-13 15:41:06 +02:00
Tymoteusz Czech
dd1246d67c Fix/archive table (#1086)
* feat: upgrade search to use the new search component (#1073)

* feat: upgrade project list search to use the new search field

* cleanup unused imports

* feat: add upgraded search to projects and applications, polish search UX

* refactor: TableSearch to new Search common component

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>

* fix: resolve issues with project edit/delete button conditions (#1084)

* fix: fix UPDATE_PROJECT permission checks for editors

* fix: disable delete button for the default project

* fix: warn about access on edit project page

* fix: hide broken project edit/delete buttons for OSS

* refactor: avoid project card clicks when closing modals

* refactor: improve default project deletion message

* refactor: improve project access error text

* Update src/component/project/ProjectCard/ProjectCard.tsx

Co-authored-by: Thomas Heartman <thomas@getunleash.ai>

* refactor: fix string quotes

* refactor: improve disabled menu item contrast

* refactor: remove Enterprise routes for OSS

Co-authored-by: Thomas Heartman <thomas@getunleash.ai>

* fix: archive table small adjustments

* refactor archive table params

Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
Co-authored-by: olav <mail@olav.io>
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
2022-06-13 15:22:27 +02:00
olav
e338319afa refactor: avoid relative positioning for tbody (#1085)
* refactor: expose vite dev server on local IP

* refactor: avoid relative positioning for tbody

* refactor: avoid height on tbody as well

* refactor: use row height from theme
2022-06-13 09:25:36 +02:00
renovate[bot]
d7bc30871f chore(deps): update dependency react-timeago to v7 (#1088)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-06-13 09:07:14 +02:00
Renovate Bot
7592e4f643 chore(deps): update dependency vitest to v0.14.2 2022-06-10 22:50:33 +00:00
Renovate Bot
ad9519c181 chore(deps): update dependency vite to v2.9.12 2022-06-10 19:20:55 +00:00
Fredrik Strand Oseberg
bd4651b9ca Merge branch 'main' into archive_table 2022-06-10 16:22:07 +02:00
olav
2d24d92f5a fix: resolve issues with project edit/delete button conditions (#1084)
* fix: fix UPDATE_PROJECT permission checks for editors

* fix: disable delete button for the default project

* fix: warn about access on edit project page

* fix: hide broken project edit/delete buttons for OSS

* refactor: avoid project card clicks when closing modals

* refactor: improve default project deletion message

* refactor: improve project access error text

* Update src/component/project/ProjectCard/ProjectCard.tsx

Co-authored-by: Thomas Heartman <thomas@getunleash.ai>

* refactor: fix string quotes

* refactor: improve disabled menu item contrast

* refactor: remove Enterprise routes for OSS

Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
2022-06-10 16:09:50 +02:00
Fredrik Strand Oseberg
3040256047 Merge branch 'main' into archive_table 2022-06-10 16:07:59 +02:00
Nuno Góis
4761847ce5 feat: upgrade search to use the new search component (#1073)
* feat: upgrade project list search to use the new search field

* cleanup unused imports

* feat: add upgraded search to projects and applications, polish search UX

* refactor: TableSearch to new Search common component

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2022-06-10 15:23:12 +02:00
andreas-unleash
9536a1b78f formatting 2022-06-10 16:04:06 +03:00
andreas-unleash
f44bc9a849 PR comments 2022-06-10 15:55:54 +03:00
andreas-unleash
fb2005a2df PR comments 2022-06-10 15:47:42 +03:00
andreas-unleash
a5094b1fc0 replace useLocalStorage 2022-06-10 09:34:42 +03:00
andreas-unleash
cb7ff9372e Merge branch 'main' into archive_table 2022-06-10 09:24:20 +03:00
Renovate Bot
63852441dd chore(deps): update dependency sass to v1.52.3 2022-06-09 18:48:12 +00:00
olav
3add10ccbe refactor: simplify error toast text (#1081)
* refactor: simplify error toast text

* refactor: simplify 404 error text
2022-06-09 15:36:01 +02:00
andreas-unleash
c3c7c07c05 Merge branch 'main' into archive_table 2022-06-09 15:25:24 +03:00
olav
97206760be fix: allow horizontal scroll in tokens table (#1080)
* fix: allow horizontal scroll in tokens table

* refactor: fix username column width

* refactor: always show username column since we now may scroll
2022-06-09 14:04:19 +02:00
andreas-unleash
efa66b2ab2 Merge remote-tracking branch 'origin/archive_table' into archive_table 2022-06-09 12:47:22 +03:00
andreas-unleash
055e7bebff PR comment 2022-06-09 12:47:13 +03:00
andreas-unleash
0e9d19ee7c PR comment 2022-06-09 12:46:04 +03:00
andreas-unleash
27fd367199 Merge branch 'main' into archive_table 2022-06-09 12:43:50 +03:00
Tymoteusz Czech
608171ce93 Improve table performance (#1061)
* improve table performance

* revert to react-router navigation
2022-06-09 11:34:55 +02:00
andreas-unleash
2dcae647f2 Merge branch 'main' into archive_table 2022-06-09 08:24:33 +03:00
Renovate Bot
31d3572dad chore(deps): update dependency msw to v0.42.1 2022-06-08 19:27:08 +00:00
olav
d32674fc4c refactor: improve archive title text (#1076) 2022-06-08 16:01:10 +02:00
andreas-unleash
193cc82ffa Merge branch 'main' into archive_table 2022-06-08 16:05:13 +03:00
olav
6d05c65631 refactor: fix operator upgrade alert box margins (#1078) 2022-06-08 14:55:15 +02:00
andreas-unleash
d50edfa294 remove dead code 2022-06-08 14:47:44 +03:00
andreas-unleash
88f2bef1be Merge remote-tracking branch 'origin/archive_table' into archive_table 2022-06-08 14:37:05 +03:00
andreas-unleash
65c252a20c add search and filters 2022-06-08 14:36:29 +03:00
andreas-unleash
9c26dfc6c8 Merge branch 'main' into archive_table 2022-06-08 14:25:39 +03:00
andreas-unleash
e53baaf718 removed unused code 2022-06-08 14:07:55 +03:00
andreas-unleash
b6beae95cc added filterName to column 2022-06-08 13:54:12 +03:00
andreas-unleash
854ffaf0b2 PR comments and tidying up 2022-06-08 13:26:41 +03:00
renovate[bot]
c0edf76033 chore(deps): update material-ui monorepo (#1075)
Co-authored-by: Renovate Bot <bot@renovateapp.com>
2022-06-08 11:57:30 +02:00
Nuno Góis
81c25c7774 fix: constraint-related UI fixes (#1069)
* fix: constraint-related UI fixes

* test spans on values list

* fix: values truncation, misc UI fixes

* fix: no longer assign const variable (debug)
2022-06-08 08:33:39 +01:00
Renovate Bot
ee52f224bc chore(deps): update dependency react-chartjs-2 to v4.2.0 2022-06-07 23:21:29 +00:00
Renovate Bot
f4386e0228 chore(deps): update dependency plausible-tracker to v0.3.8 2022-06-07 19:36:01 +00:00
olav
42d30e2d79 refactor: remove error class names from input error messages (#1071)
* refactor: remove error class names from input error messages

* refactor: update error message test

* refactor: show constraint value length error earlier
2022-06-07 15:03:40 +02:00
andreas-unleash
c26bfcf9da PR comment 2022-06-07 14:22:51 +03:00
andreas-unleash
de51478e19 PR comment 2022-06-07 14:21:36 +03:00
andreas-unleash
539aa89639 lint fix 2022-06-07 14:20:25 +03:00
andreas-unleash
1b1f21caeb bug fix 2022-06-07 14:16:56 +03:00
andreas-unleash
1922c26f11 bug fix 2022-06-07 14:06:58 +03:00
andreas-unleash
de2a3037f5 Fix PR comments 2022-06-07 13:28:22 +03:00
andreas-unleash
fdf7ef8fb2 Fix PR comments 2022-06-07 13:27:05 +03:00
andreas-unleash
fa0c32a478 Fix PR comments 2022-06-07 13:24:58 +03:00
andreas-unleash
63f147b492 Fix PR comments 2022-06-07 13:23:15 +03:00
andreas-unleash
4ddf69436e Merge remote-tracking branch 'origin/archive_table' into archive_table 2022-06-07 11:54:47 +03:00
andreas-unleash
dd9a291e09 Fix PR comments 2022-06-07 11:54:16 +03:00
andreas-unleash
8e1bf96d04 Merge branch 'main' into archive_table 2022-06-07 10:12:14 +03:00
Renovate Bot
2f604440b4 chore(deps): update dependency vite to v2.9.10 2022-06-06 22:59:05 +00:00
Renovate Bot
f60aa5fb72 chore(deps): update dependency vitest to v0.14.1 2022-06-06 19:29:59 +00:00
Renovate Bot
aa0cae8471 chore(deps): update dependency plausible-tracker to v0.3.7 2022-06-06 16:05:08 +00:00
Tymoteusz Czech
53b12604b8 Search keyboard shortcut (#1048)
* feat: search keyboard shortcut

* fix: search input placeholder snapshot update

* fix: update apple device recognition

Co-authored-by: Nuno Góis <github@nunogois.com>

* refactor: return hotkey from useKeyboardShortcut

* fix: don't close non-empty search field

* Archive table
new sort parameter

* Revert "Archive table"

This reverts commit 171806352c2a01ce439ce7bd77476797d544275c.

* update search field focus

* refactor: clarify hotkey description

* fix: make variant payload text box multiline (#1060)

* fix: make variant payload text box multiline

* refactor: adjust min/max rows

* refactor: use fixed number of rows to avoid MUI render loop bug

* fix: toggle search on escape only in focused

* fix: add hotkey to custom placeholders

Co-authored-by: Nuno Góis <github@nunogois.com>
Co-authored-by: andreas-unleash <andreas@getunleash.ai>
Co-authored-by: olav <mail@olav.io>
2022-06-06 14:23:48 +02:00
andreas-unleash
406c187372 Project Archive 2022-06-06 12:12:28 +03:00
andreas-unleash
b622767ae9 Merge remote-tracking branch 'origin/archive_table' into archive_table 2022-06-06 10:42:49 +03:00
andreas-unleash
dcad6d2b40 Archive table
new sort parameter
2022-06-06 10:21:40 +03:00
Renovate Bot
6dceedbd35 chore(deps): update dependency vitest to v0.14.0 2022-06-06 09:13:05 +02:00
Renovate Bot
3a69fce4a0 chore(deps): update dependency eslint to v8.17.0 2022-06-06 09:13:05 +02:00
Renovate Bot
636db67254 chore(deps): update dependency typescript to v4.7.3 2022-06-06 09:13:05 +02:00
Renovate Bot
a60112a5c8 chore(deps): update dependency sass to v1.52.2 2022-06-06 09:13:05 +02:00
olav
5ff790aa81 fix: make variant payload text box multiline (#1060)
* fix: make variant payload text box multiline

* refactor: adjust min/max rows

* refactor: use fixed number of rows to avoid MUI render loop bug
2022-06-06 09:13:05 +02:00
andreas-unleash
79af4c39e0 Archive table
new sort parameter
2022-06-06 09:54:45 +03:00
andreas-unleash
9edfc22ae1 Merge remote-tracking branch 'origin/main' into main 2022-06-03 16:21:24 +03:00
andreas-unleash
28cfe4d470 Archive table
new sort parameter
2022-06-03 16:21:12 +03:00
Nuno Góis
4a5ed3c3e7 feat: add filtering capabilities to search (#1052)
* feat: add filtering capabilities to search

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>

* fix: state custom filter

* fix: undefined search crash

* feat: add suggestions component

* make search visible all the time

* fix: update snaps

* refactor, add tests, filterParsing, pass down searchContext to search components

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>

* refactor: TableSearchFieldSuggestions and improvements

* some cleanup and fix edge cases

* adapt new search in project feature toggles

* small ui/ux improvements

* refactor: suggestions into smaller components

* fix: update snaps

* add responsiveness to the search

* fix: update snaps

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2022-06-03 11:32:30 +01:00
olav
32ada96220 fix: disable project access tab when no access (#1057)
* refactor: remove unused import

* fix: disable project access tab when no access

* refactor: improve access denied text
2022-06-03 08:14:47 +02:00
olav
006b853f6c refactor: get segment limits from uiConfig (#1047)
* refactor: improve useUiConfig return type

* refactor: get segment limits from uiConfig
2022-06-02 10:58:55 +02:00
Nuno Góis
682921d5bf fix: misc ui fixes post tables upgrade (#1049)
* fix: misc ui fixes post tables upgrade

* fix: update snaps, small cleanup

* refactor: ReportCard to styled, misc improvements

* cleanup remaining styles file

* rename `Feature Toggle Name` to just `name`

* refactor: address PR comments
2022-06-02 08:21:51 +01:00
Renovate Bot
bad17e3606 chore(deps): update dependency @types/jest to v27.5.2 2022-06-01 23:01:20 +00:00
Renovate Bot
a5ed65b3ac chore(deps): update dependency vitest to v0.13.1 2022-06-01 16:55:36 +00:00
Tymoteusz Czech
24cb1b21ef Virtualize project toggles list (#1043)
* fix: virtualize project toggles list

* refactor: improve type for feature dialogs

* fix: formatting - prettier
2022-06-01 12:24:24 +00:00
olav
c6f0a20fd6 fix: always show tokens page header (#1050) 2022-06-01 09:14:27 +02:00
Renovate Bot
c8fccfb9ed chore(deps): update material-ui monorepo 2022-05-31 14:23:33 +00:00
Fredrik Strand Oseberg
7c52f0fcc8 feat: new variants table (#1025)
* fix: cleanup

* fix: text

* fix: stable references

* refactor: fix VARIANT_WEIGH test id

* refactor: fix variant element selection in e2e test

* fix: update variants table

* fix: refactor action cell

Co-authored-by: olav <mail@olav.io>
2022-05-31 13:45:04 +02:00
olav
f4d02e37b7 refactor: rewrite feature strategy icons list (#1039)
* refactor: fix strategy action icon layout

* refactor: use a custom SVG for the rollout strategy icon

* refactor: rewrite feature strategy icons list
2022-05-31 10:50:24 +02:00
Tymoteusz Czech
670bb33fad fix: prevent search reset on project overview (#1045)
* fix: prevent search reset on project overview

* fix: use global filter for search in project
2022-05-31 08:31:52 +00:00
olav
36196ad6d5 refactor: port metrics list to react-table (#1035)
* refactor: port metrics list to react-table

* refactor: hide columns on small screens

* refactor: use disableSortBy instead of canSort

* refactor: fix text contrast

* refactor: fix metrics section ids
2022-05-31 10:26:30 +02:00
Nuno Góis
570e9f88be feat: upgrade users table (#1040)
* feat: upgrade users table

* fix misc ui/ux bugs

* refactor: address PR comments

* fix: searching by `undefined`

* fix: searching for undefined on invoices, table placeholder centering

* refactor: abstract users list actions into new component

* refactor: move styled components to top of files
2022-05-31 07:59:09 +01:00
Renovate Bot
63a30695ce chore(deps): update dependency msw to v0.42.0 2022-05-31 03:54:51 +00:00
Renovate Bot
590a0f20ff chore(deps): update dependency vitest to v0.13.0 2022-05-30 13:18:08 +00:00
Renovate Bot
5c587685a0 chore(deps): update dependency msw to v0.41.1 2022-05-28 03:15:13 +00:00
Tymoteusz Czech
581dcca2b2 Fix: global filter table rules (#1016) 2022-05-27 14:15:32 +00:00
olav
eb5e83cdb4 refactor: remove unused code (#1036)
* refactor: remove unused code

* refactor: remove more unused code
2022-05-27 13:28:58 +02:00
olav
ae012d62e6 refactor: fix missing IconButton labels (#1038)
* refactor: fix missing IconButton labels

* refactor: fix percentage text color contrast
2022-05-27 13:12:03 +02:00
olav
2cd9e992fe fix: improve styles for tab bars and dividers (#1037) 2022-05-27 12:27:33 +02:00
olav
19f97a388e fix: avoid direct mutation of setState return value (#1034) 2022-05-27 10:04:26 +02:00
olav
25c25c9206 refactor: port tokens list to react-table (#1026)
* refactor: extract ApiTokenDocs component

* refactor: extract CreateApiTokenButton component

* refactor: extract RemoveApiTokenButton component

* refactor: extract CopyApiTokenButton component

* refactor: port tokens list to react-table

* refactor: remove unused imports

* fix: api token table default sort order

* fix: updates to table of api tokens

* fix: add highlighting when searching

Co-authored-by: Tymoteusz Czech <tymek+gpg@getunleash.ai>
Co-authored-by: Nuno Góis <github@nunogois.com>
2022-05-27 08:48:01 +01:00
olav
504a4af274 refactor: port segments list to react-table (#1024)
* refactor: extract SegmentEmpty component

* refactor: extract CreateSegmentButton component

* refactor: extract EditSegmentButton component

* refactor: extract RemoveSegmentButton component

* refactor: normalize Created table header text

* refactor: port segments list to react-table

* fix: improve row text height in table row

* fix: update test snapshots

* refactor table cell with search highlight

* fix: update after review

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
Co-authored-by: Tymoteusz Czech <tymek+gpg@getunleash.ai>
2022-05-27 08:57:30 +02:00
Renovate Bot
5bd840107e chore(deps): update dependency vite-tsconfig-paths to v3.5.0 2022-05-27 02:00:36 +00:00
Nuno Góis
4d778b9de5 fix: admin routes bug 2022-05-26 15:51:13 +01:00
Nuno Góis
b61980e71b feat: Admin project roles table (#1030)
* feat: new admin project roles table

* small fixes

* replace Box in defaultColumn Cell with the new TextCell

* refactor: slight adjustments

* misc improvements

* add HighlightCell

* fix: description width

* Update src/component/admin/projectRoles/ProjectRoles/ProjectRoleList/ProjectRoleList.tsx

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>

* address PR comments, small tooltip fixes

* fix: prettier fmt

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
2022-05-26 15:27:20 +01:00
Tymoteusz Czech
9ac962da45 Feat: Contexts and Project access tables (#1028)
* feat: new contexts table

* improve context list actions

* refactor: disabled icon colors

* fix: update snapshots

* fix: icons

* fix: context fields typo

* feat: new project access table

* fix: header cell styles
2022-05-26 10:37:33 +02:00
Nuno Góis
7093b49962 feat: add billing page to admin (#993)
* feat: add billing page to admin

* some adjustments to billing page

* add BillingHistory, remove invoices, misc improvements

* refactor based on instanceStatus logic, add dialog

* fix: cleanup

* some refactoring and alignment with figma

* add extend, isBilling, refactoring and misc improvements

* fix: update tests

* refactor: reorganize billing into smaller components, misc improvements

* add STRIPE flag, some refactoring and adapting to comments and discussion

* adapt BillingHistory slightly, refactor TextCell

* Update src/hooks/api/getters/useInstanceStatus/useInstanceStatus.ts

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>

* refactor: address PR comments

* fix: adjust divider color

* fix: update snaps

* refactor: address PR comments

* fix: update snaps

* fix: amountFormatted typo

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2022-05-25 23:26:05 +02:00
Renovate Bot
616cc8de24 chore(deps): update dependency chart.js to v3.8.0 2022-05-25 18:38:19 +00:00
Tymoteusz Czech
7480085698 Fix: Features table performance (#1015)
* feat: persistent table query

* project overview sort query

* refactor: api methods as hook callbacks

* persitent columns in project overview

* enable new project overview

* fix: refactor feature state change in overview

* add type to sort

* update e2e tests

now takes 10% less time with use of cypress session

* prevent sort reset on features list

* fix feature toggle list loading

* fix: features table items virtualization

* project overview screen limits

* table row height in theme

* rename row index variable
2022-05-25 14:39:14 +00:00
Fredrik Strand Oseberg
ded3c22bb1 Feat/new addons table (#1021)
* feat: initial list of available addons

* feat: add columns

* fix: update referential equality

* fix: remove search

* fix: remove unused imports

* fix: padding

* fix: imports

* refactor: based on comments
2022-05-25 15:37:32 +02:00
olav
a791ea59c1 refactor: remove eslint from merge check (#1023) 2022-05-25 14:15:00 +02:00
olav
76ea65b65c refactor: port health reports to react-table (#1017)
* refactor: fix table header sort button focus styles

* refactor: extract FeatureNameCell component

* refactor: port health reports to react-table

* refactor: hide columns on small screens

* refactor: sort features by name
2022-05-25 12:45:30 +02:00
olav
20d738f725 refactor: add eslint to merge check (#1022)
* refactor: fix eslint issues

* refactor: add eslint to merge check
2022-05-25 12:36:58 +02:00
olav
34f848ce8a refactor: replace react-dnd with custom implementation (#988)
* refactor: replace react-dnd with custom implementation

* refactor: add TextCell, IconCell, and ActionCell

* refactor: port environments list to react-table

* refactor: change OfflineBolt to PowerSettingsNew

* refactor: simplify environment toast text

* refactor: improve IToast type type

* refactor: improve useSearchHighlightContext naming

* refactor: clarify enableDragAndDrop logic
2022-05-25 11:40:20 +02:00
Fredrik Strand Oseberg
c073908027 feat: new tag types table (#1014)
* feat: new tag types table

* fix: update loader text

* fix: update header

* fix: regenerator runtime

* fix: update snapshot
2022-05-25 11:12:53 +02:00
olav
91a825792e refactor: normalize status badge designs (#1018) 2022-05-25 08:30:47 +00:00
Tymoteusz Czech
a11cb72d99 Persistent table query (#999)
* feat: persistent table query

* project overview sort query

* refactor: api methods as hook callbacks

* persitent columns in project overview

* enable new project overview

* fix: refactor feature state change in overview

* add type to sort

* update e2e tests

now takes 10% less time with use of cypress session

* prevent sort reset on features list

* fix feature toggle list loading

* fix: update column state saving

* update local storage hook test
2022-05-25 08:14:22 +00:00
Renovate Bot
c2b5c563db chore(deps): update dependency tss-react to v3.7.0 2022-05-25 00:14:15 +00:00
Renovate Bot
37268baa3a chore(deps): update dependency typescript to v4.7.2 2022-05-24 21:38:08 +00:00
Fredrik Strand Oseberg
7ba9d2a577 Feat/new strategies table (#1012)
* fix: add flex to toolbarcontainer

* feat: add initial new table

* feat: add styled badge

* feat: remove dead code

* fix: remove useContext import

* fix: update context buttons to icon buttons

* feat: add loading

* fix: remove unused imports

* Update src/component/strategies/StrategiesList/PredefinedBadge/PredefinedBadge.tsx

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>

* fix: update spacing to use theme

* fix: update loading

* fix: update type

Co-authored-by: Tymoteusz Czech <2625371+Tymek@users.noreply.github.com>
2022-05-24 10:58:06 +02:00
Thomas Heartman
9463c8df90 meta: add external PRs to project board (#1006)
The `pull_request` hook runs in the context of the proposed changes. That means that for forks, this action won't have access to the required secrets for it to complete. As such, PRs from outside contributors won't work correctly.

The `pull_request_target` hook, however, runs in the context of the target branch, and thus has all the permissions it needs. The [github docs for this hook](https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target) also indicate that this is the way to go:

> This event allows your workflow to do things like label or comment on pull requests from forks. Avoid using this event if you need to build or run code from the pull request.

## Interesting note for PRs

It seems that when this change is proposed as a PR, the expected action (_add new item to project board_) does not run. However, this does not affect other new PRs. After merging, the pipeline works and triggers as expected, for both external and internal contributors.

## Isn't this potentially dangerous?

Good question! As far as I understand: no, it's not. The long answer is in [Keeping your GitHub Actions and workflows secure Part 1: Preventing pwn requests](https://securitylab.github.com/research/github-actions-preventing-pwn-requests/), but I'll try and summarize it here.

Some choice cuts from the article:

> TL;DR: Combining pull_request_target workflow trigger with an **explicit checkout of an untrusted PR** is a dangerous practice that may lead to repository compromise.

However, we do not check the PR out!

> Due to the dangers inherent to automatic processing of PRs, GitHub’s standard pull_request workflow trigger by default prevents write permissions and secrets access to the target repository. However, in some scenarios such access is needed to properly process the PR. To this end the pull_request_target workflow trigger was introduced.

> pull_request_target runs in the context of the target repository of the PR, rather than in the merge commit. This means the standard checkout action uses the target repository to prevent accidental usage of the user supplied code.

> These safeguards enable granting the pull_request_target additional permissions. The reason to introduce the pull_request_target trigger was to enable workflows to label PRs (e.g. needs review) or to comment on the PR. The intent is to use the trigger for PRs that do not require dangerous processing, say building or running the content of the PR.

That is: when using `pull_request_target`, the action will not check out the PR branch and thus, the PR cannot inject any code changes into the action. On the other hand `pull_request` uses the code that's in the PR to run actions, which is why it requires explicit authorization before being run.

`pull_request_target` runs in the context of the target branch (most commonly `main`) and only runs code that already exists in the target branch. No code from the PR gets used.

Co-authored-by: Fredrik Strand Oseberg <fredrik.no@gmail.com>
2022-05-24 10:26:41 +02:00
olav
b742a69c4c refactor: improve OpenAPI refs (#1005)
* refactor: regenerate OpenAPI client

* refactor: update usage of OpenAPI client
2022-05-24 08:37:46 +02:00
Renovate Bot
a0261daac6 chore(deps): update material-ui monorepo 2022-05-23 20:23:55 +00:00