6 Commits

Author	SHA1	Message	Date
Gastón Fournier	db04a1eaa8	chore: introduce type to prevent potential issues (#5066) ... ## About the changes This small improvement aims to help developers when instantiating services. They need to be constructed without injecting services or stores created elsewhere so they can be bound to the same transactional scope. This suggests that you need to create the services and stores on your own	2023-10-17 12:30:44 +02:00
Mateusz Kwasniewski	3eeafba5f9	feat: validate archive dependent features (#5019)	2023-10-13 12:09:46 +02:00
Gastón Fournier	c3e8d743bc	chore: Improve UI Config type (#4959) ... Fix link types	2023-10-06 16:31:39 +02:00
Gastón Fournier	52fa872fe6	chore: handle transactions already started at the controller layer (#4953) ... ## About the changes This PR adds a method to safeguard us from opening a new transaction while inside another transaction, resulting in two isolated transactions that will not be atomic (if one fails, the other might still complete successfully). bbbe4d4637/lib/knex-builder/make-knex.js (L143C5-L144C88) We're currently opening transactions at the controller layer 2746bd1517/src/lib/features/export-import-toggles/export-import-controller.ts (L206-L208) but in some other places, we do it at the store level: 2746bd1517/src/lib/db/access-store.ts (L577) ## Alternative We can remove store-level transactions and move them to the controller following this approach: cb034976b9/src/lib/services/index.ts (L282-L284) cb034976b9/src/lib/features/export-import-toggles/export-import-controller.ts (L206-L208) This option is more expensive because we have to: 1. Write the factory methods that propagate the transaction to the stores (therefore creating the store factory methods as well) 2. Identify the methods for creating the transactions at the store level and backtrack the calls until the controller layer	2023-10-06 13:38:32 +02:00
Gastón Fournier	0da48cc0d1	chore: revamp transactional impl (#4916) ... ## About the changes This transactional implementation decorates a service with a transactional method that removes the need to start transactions in the method using the service. This is a gradual rollout with a feature toggle, just because transactions are not easy.	2023-10-04 15:16:37 +02:00
Mateusz Kwasniewski	f0c9f8b08b	feat: oss import (#3123)	2023-02-16 08:08:51 +01:00