Ivar Conradi Østhus
b36ab58f87
fix: add timestamp to feature toggle metrics ( #4094 )
...
fixes : #2873
2023-06-27 09:14:45 +02:00
Nuno Góis
233e06ec6a
fix: disable autoResetHiddenColumns when useConditionallyHiddenColumns ( #2851 )
...
https://linear.app/unleash/issue/2-563/fix-issue-with-useconditionallyhiddencolumns-and-react-table
It seems like we should add `autoResetHiddenColumns: false` to
`useTable` whenever we use `useConditionallyHiddenColumns`.
Basically the thought is that, if we're controlling column visibility in
our own way, we should not want other things to change that state
unpredictably, otherwise this may make React go _brrrrrr_. And it can be
very hard to pinpoint what exactly may be causing React to go _brrrrrr_.
First detected this issue apparently randomly while developing the new
SA table. Around 10-20 page refreshes would eventually trigger it. Was
not easy to find, but hopefully this fixes it permanently. At least I
haven't been able to reproduce it since. Maybe someone has a better idea
of where the issue could be or if this is a pretty good guess. Doesn't
seem like this change hurts us anyways.
I love React, `useEffect` and these very to-the-point error messages.
Very fun and productive.
Reference: https://react-table-v7.tanstack.com/docs/api/useTable
2023-01-10 08:15:12 +00:00
Nuno Góis
1d1219a055
Use new useConditionallyHiddenColumns hook ( #2695 )
...
https://linear.app/unleash/issue/2-515/adapt-tables-to-use-the-new-useconditionallyhiddencolumns-hook
Uses the new `useConditionallyHiddenColumns` hook, like mentioned here:
https://github.com/Unleash/unleash/pull/2691
Also includes small fixes for things I caught along the way. See
comments below.
2022-12-16 10:46:04 +01:00
Tymoteusz Czech
349106a2be
fix: sort order across the app
...
discussed with Nicolae and Nuno
2022-06-14 11:14:56 +02:00
Nuno Góis
682921d5bf
fix: misc ui fixes post tables upgrade ( #1049 )
...
* fix: misc ui fixes post tables upgrade
* fix: update snaps, small cleanup
* refactor: ReportCard to styled, misc improvements
* cleanup remaining styles file
* rename `Feature Toggle Name` to just `name`
* refactor: address PR comments
2022-06-02 08:21:51 +01:00
olav
36196ad6d5
refactor: port metrics list to react-table ( #1035 )
...
* refactor: port metrics list to react-table
* refactor: hide columns on small screens
* refactor: use disableSortBy instead of canSort
* refactor: fix text contrast
* refactor: fix metrics section ids
2022-05-31 10:26:30 +02:00
olav
24c11332b5
chore: update MUI to v5 ( #923 )
...
* refactor: update mui packages
* refactor: run mui codemods
* refactor: format files after codemods
* refactor: fix broken types
* refactor: clean up theme
* refactor: fix broken tests
* refactor: replace @mui/styles with tss-react
* refactor: move breakpoints into classes for tss
* refactor: fix crash on missing feature description
* refactor: remove void classNames
* refactor: adjust styles to new defaults
* refactor: remove broken rollout slider e2e test
* refactor: fix duplicate e2e testid
* refactor: update makeStyles after rebase
* refactor: add missing snapshot after rebase
* refactor: fix TableCellSortable focus styles
* refactor: use 1.4 as the default line-height
* refactor: hide webkit search field icons
* refactor: fix select box label
* refactor: make AutocompleteBox smaller
* refactor: make heading smaller
* refactor: fix toast close icon color
* refactor: update snapshots
* refactor: add missing test event awaits
* refactor: fix default button line-height
2022-05-02 15:52:41 +02:00
olav
3bb5a69d86
fix: improve feature metrics accessibility ( #901 )
...
* refactor: fix header order
* refactor: improve metrics chart aria attributes
* refactor: add focus style for active metrics chips
2022-04-22 12:35:47 +02:00
Youssef Khedher
85950f104a
chore: update paths 🧼 ( #820 )
2022-03-28 09:49:59 +01:00
olav
cfc2338e78
refactor: use camel case for files and dirs ( #817 )
2022-03-25 12:34:20 +01:00
olav
a4dab966a3
refactor: port date utils to TS ( #720 )
2022-02-25 10:40:55 +01:00
olav
33b5e4abac
feat: add new feature metrics page ( #716 )
...
* refactor: ensure that [hidden] overrides other display styles
* refactor: use numeric font weights
* refactor: remove unnecessary Jest mock
* refactor: add a fullWidth prop to GeneralSelect
* refactor: remove unnecessary label id prop
* refactor: the showActive prop is optional
* refactor: add hooks for managing query string state
* refactor: add a hour/minute timestamp formatter
* refactor: add labels to button icons
* feat: add new feature metrics page
* refactor: remove prev feature metrics page
* refactor: use new metric boxes on overview page
* refactor: lazy-load the new metrics page
* refactor: fix type error when formatting unknown error
* refactor: extract interfaces for props
* refactor: destructure all props
* refactor: expand arg names
* refactor: reorg component dirs and files
* refactor: improve chart element label
* refactor: hide chart dots until hover
* refactor: add section titles to environments/applications
* refactor: simplify FeatureMetricsHours types
* refactor: sort chart tooltip items
* refactor: add more chart labels
* refactor: always show a dot in single point charts
* refactor: improve chart tooltip styles
* refactor: adjut metric page spacing
* refactor: decrease legend box size
* refactor: move date fmt fn inline
* refactor: improve chart legend styles
* refactor: increase Cypress timeouts
* refactor: sort environment and application chips
* refactor: format files
* refactor: use stable lists of apps and envs
* refactor: fix FeatureMetrics dir name
* refactor: avoid ScrollToTop on query string change
* refactor: use ConditionallyRender instead of inline condition
* refactor: use makeStyles instead of styled API
2022-02-21 13:47:54 +01:00
