Nuno Góis
de34497478
chore: drop action definition required ( #6567 )
...
https://linear.app/unleash/issue/2-2046/implement-dynamic-action-parameters
Follow up to https://github.com/Unleash/unleash/pull/6554
Cleans up the `required` property in action definitions after adapting
to using the `parameters` property instead.
2024-03-14 16:32:14 +00:00
Nuno Góis
7a3d2d6d87
chore: dynamic action parameters ( #6554 )
...
https://linear.app/unleash/issue/2-2046/implement-dynamic-action-parameters
Implements dynamic action parameters.
Also improves the action dropdown to better prepare for future actions.
<img width="771" alt="image"
src="https://github.com/Unleash/unleash/assets/14320932/ec3fcaf2-40c8-4dc8-8834-7a0d54671fd2 ">
2024-03-14 15:25:23 +00:00
Nuno Góis
a1af0dd41c
chore: improve action parameters UI ( #6549 )
...
https://linear.app/unleash/issue/2-2041/improve-action-parameters-ui
Improves the UI of action parameters, implementing a new
`ProjectActionsActionParameterAutocomplete` component that allows
search.
2024-03-14 11:25:14 +00:00
Nuno Góis
bc6a96cf6b
chore: suggest nested properties in action filters ( #6533 )
...
https://linear.app/unleash/issue/2-2029/support-filtering-on-nested-properties
Suggests nested properties in action filters. Also sorts them
alphabetically.
Follow up to https://github.com/Unleash/unleash/pull/6531
<img width="381" alt="image"
src="https://github.com/Unleash/unleash/assets/14320932/4e2c900d-335b-4360-8be4-186f3887e42b ">
2024-03-13 16:07:01 +00:00
Fredrik Strand Oseberg
f381718fd6
fix: icon imports ( #6499 )
...
Based on this article:
https://mui.com/material-ui/guides/minimizing-bundle-size/ importing
from `'@mui/icons-material'` instead of specifying the actual path to
the icon like `import Delete from '@mui/icons-material/Delete';` can be
up to six time slower. This change changes all named imports in Unleash
referencing the `@mui/icons-material` to default imports.
This reduced the amount of modules we had to process when building the
frontend from 15206 to 4746
Before:
<img width="1016" alt="Skjermbilde 2024-03-11 kl 14 19 58"
src="https://github.com/Unleash/unleash/assets/16081982/f137d24a-6557-4183-a40f-f62a33524520 ">
After:
<img width="1237" alt="Skjermbilde 2024-03-11 kl 14 20 32"
src="https://github.com/Unleash/unleash/assets/16081982/05a27d6a-2c3f-4409-9862-7188ab4b9c72 ">
Build time locally decreased by around 50%
Before:
<img width="1504" alt="Skjermbilde 2024-03-11 kl 14 31 45"
src="https://github.com/Unleash/unleash/assets/16081982/bc931559-b022-47ed-9f8f-c87401578518 ">
After:
<img width="1219" alt="Skjermbilde 2024-03-11 kl 14 27 00"
src="https://github.com/Unleash/unleash/assets/16081982/3c3a8d6b-576d-45c3-aa40-cc5f95d9df2b ">
2024-03-12 10:56:10 +01:00
Nuno Góis
b4454053e8
fix: check for project in the action permissions check ( #6503 )
...
Fixes the action permission check by also considering the project in the
check.
2024-03-11 15:06:00 +00:00
Nuno Góis
7d827442ee
fix: add actions validation ( #6481 )
...
https://linear.app/unleash/issue/2-2022/improve-actions-validation
Improves our current actions form validation.
Empty actions are now ignored on the payload and we get errors in
actions where any of the required fields are empty.
Also refactored our current actions into a constant map that can be
shared across frontend and backend.
2024-03-11 08:18:36 +00:00
Nuno Góis
9148820a8f
fix: project tokens path typo ( #6468 )
...
Noticed a small typo in the path shown in the project API access side
panel.
2024-03-08 08:44:48 +01:00
Alvin Bryan
a0ac148829
Typo fix in ChangeRequestTable.tsx ( #6465 )
...
There was a typo in the original message, it said "Unleash Admin already
have" (either "admins already have," or "admin already has.")
Fixed it and improved the wording a little bit.
2024-03-07 17:19:30 +00:00
Nuno Góis
26d7065dc3
chore: add actions warning to delete project ( #6467 )
...
https://linear.app/unleash/issue/2-1831/what-happens-with-automated-actions-if-the-project-is-archived
Adds an actions-related warning to the project deletion.
<img width="1008" alt="image"
src="https://github.com/Unleash/unleash/assets/14320932/06fcaab0-c4a1-4ba3-8879-0c188f3bc01a ">
2024-03-07 17:04:36 +00:00
Nuno Góis
52d63bc726
fix: new signals icon ( #6461 )
...
https://linear.app/unleash/issue/2-2010/use-svg-icon-for-signals
Uses a new SVG icon for Signals for consistency.
2024-03-07 11:12:56 +00:00
Nuno Góis
64593c57cf
chore: new actions UI ( #6448 )
...
https://linear.app/unleash/issue/2-1995/ui-feature-rename-adapt-the-actions-ui
Refreshes the UI for project actions according to the new designs and
suggestions from @gastonfournier and @nicolaesocaciu
Also includes some refactoring.
2024-03-06 15:08:15 +00:00
Nuno Góis
86a795e87c
chore: new actions table UI ( #6435 )
...
https://linear.app/unleash/issue/2-1995/ui-feature-rename-adapt-the-actions-ui
https://linear.app/unleash/issue/2-1988/nice-to-have-last-action-status-on-the-action-sets-table
Brings the project actions table UI up to par with the new designs,
implementing some features that were discussed with UX.
2024-03-05 11:33:34 +00:00
Nuno Góis
de5a0f2825
chore: add new signals icon instead of webhook icon ( #6427 )
...
https://linear.app/unleash/issue/2-2002/add-new-signals-icon-instead-of-using-the-webhooks-icon
Adds a new icon for signals, instead of using the same icon as webhooks.
Includes some slight refactoring.
2024-03-05 08:16:44 +00:00
Nuno Góis
68729333e0
chore: rename incoming webhooks to signals ( #6415 )
...
https://linear.app/unleash/issue/2-1994/ui-feature-rename-adapt-the-signals-ui
https://linear.app/unleash/issue/2-1996/rename-feature-in-the-code-base
Implements the feature rename to Signals by adapting the code base and
UI.
2024-03-04 12:08:05 +00:00
Nuno Góis
bddc508582
chore: actions filter constraints ( #6389 )
...
https://linear.app/unleash/issue/2-1952/adapt-actions-form-ui-to-unleash-constraint-operators
Implements the new action filters UI, now powered by constraint
operators.
This PR goes through some effort to not touch existing components too
much, especially since they are critical for activation strategies.
Instead, the new feature tries to adapt to the existing components and
styling them appropriately, while still re-using them. We can refactor
this at a later stage if needed.
This UI will face some more drastic changes in the near future due to
the feature rename, so I wanted to keep this PR mostly scoped to the
constraint operators before proceeding with more changes.
As always, did some manual tests and it seems to be working great!
2024-02-29 12:56:48 +00:00
Mateusz Kwasniewski
84400323d6
feat: sdk reporting tracker ( #6378 )
2024-02-28 15:52:03 +01:00
Jaanus Sellin
df93827002
feat: remove applications from project list that do not exist ( #6377 )
2024-02-28 16:26:53 +02:00
andreas-unleash
74c760bf4c
chore: remove changeRequestConflictHandling flag ( #6364 )
...
What it says on the tin
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2024-02-28 10:16:35 +02:00
Nuno Góis
477a9c6cfa
chore: action events UI ( #6358 )
...
https://linear.app/unleash/issue/2-1936/action-events-ui
Implements the UI for action events.
2024-02-27 13:52:09 +00:00
andreas-unleash
9101c39eb7
chore: remove scheduledConfigurationChanges flag ( #6360 )
...
What is says on the box
---------
Signed-off-by: andreas-unleash <andreas@getunleash.ai>
2024-02-27 14:57:34 +02:00
Jaanus Sellin
7cebf7b8fe
feat: application issues ( #6347 )
...
2024-02-27 09:57:50 +02:00
Mateusz Kwasniewski
2c5d4ba0ce
feat: set default env columns in project overview to 3 ( #6338 )
2024-02-26 13:10:45 +01:00
Mateusz Kwasniewski
d1e93228a3
refactor: paginated data hook ( #6333 )
2024-02-26 11:24:41 +01:00
Nuno Góis
ad864049da
fix: only show visible environments for that project in actions ( #6318 )
...
https://linear.app/unleash/issue/2-1969/actions-form-only-show-environments-scoped-to-the-current-project
Filters the environment options in actions to only show environments
that are currently visible for that project, safeguarding users from
configuring actions for invalid environments.
2024-02-23 08:24:32 +00:00
Mateusz Kwasniewski
8b0218df6a
test: project applications table ( #6321 )
2024-02-22 19:03:54 +01:00
Christopher Kolstad
7350c91a1e
fix: display all roles if we can't get project roles
2024-02-20 16:23:25 +01:00
Christopher Kolstad
e9d9db17fe
feat: Adding Project access requires same role ( #6270 )
...
In order to prevent users from being able to assign roles/permissions
they don't have, this PR adds a check that the user performing the
action either is Admin, Project owner or has the same role they are
trying to grant/add.
This addAccess method is only used from Enterprise, so there will be a
separate PR there, updating how we return the roles list for a user, so
that our frontend can only present the roles a user is actually allowed
to grant.
This adds the validation to the backend to ensure that even if the
frontend thinks we're allowed to add any role to any user here, the
backend can be smart enough to stop it.
We should still update frontend as well, so that it doesn't look like we
can add roles we won't be allowed to.
2024-02-20 15:56:53 +01:00
Nuno Góis
7e6a3c7e69
fix: clickable names in inc wh and action tables ( #6275 )
...
https://linear.app/unleash/issue/2-1954/make-names-clickable-in-actions-and-incoming-webhooks
Makes names clickable in the incoming webhook and action tables. When
clicked, they open the edit form for that resource.
2024-02-20 09:28:00 +00:00
Nuno Góis
9b980bb212
fix: small ui/ux adjustments to the actions form ( #6269 )
...
Small UI/UX adjustments to the actions form after aligning.
2024-02-19 13:22:18 +00:00
Jaanus Sellin
03929e3031
feat: project applications UI ( #6260 )
...
2024-02-19 09:50:53 +02:00
Nuno Góis
7a699cf68c
fix: refine project actions form ( #6242 )
...
https://linear.app/unleash/issue/2-1934/refine-the-actions-form-uiux
First effort in refining the project actions form to look slightly more
like the design, including some refactors.
2024-02-15 08:28:20 +00:00
Nuno Góis
6a9f80c554
fix: misc UI/UX fixes ( #6241 )
...
https://linear.app/unleash/issue/UNL-338/adjustments-incoming-webhooks-actions
Includes misc UI/UX fixes, including a typo, the vertical alignment of
the Enterprise badge in project settings and the way incoming webhooks
are displayed in non-Enterprise plans.
2024-02-15 08:17:11 +00:00
Nuno Góis
9511e64027
refactor: project actions ( #6203 )
...
https://linear.app/unleash/issue/2-1938/refactor-project-actions
Refactors project actions to not include the project in the payload.
Includes other misc scouting.
2024-02-12 17:10:33 +00:00
Gastón Fournier
6d26c79fa7
chore: Move actions inside projects ( #6191 )
...
## About the changes
Action should be relative to a project (in general).
2024-02-12 09:26:05 +01:00
Gastón Fournier
924ea39ea2
feat: project actions UI form ( #6115 )
...
## About the changes
Add, delete, and update actions is already working. The UI still needs
some love, but it's functional
---------
Co-authored-by: Nuno Góis <github@nunogois.com>
2024-02-09 12:13:44 +00:00
Nuno Góis
13df715bfd
fix: prevent infinite rerenders in useIncomingWebhooks ( #6176 )
...
React can sometimes be non-intuitive and behave erratically due to the
way it detects changes in hook dependencies.
This prevents infinite re-renders from `useIncomingWebhooks` by using a
static `DEFAULT_DATA` constant, so that its reference is always the
same, so no changes are detected when there are none.
Unrelated scouting, but this PR also removes an unneeded dependency in
the memoized columns in `ProjectActionsTable`.
2024-02-09 08:17:15 +00:00
Mateusz Kwasniewski
7e66a79f9f
feat: add disabled state handling on slow network ( #6165 )
2024-02-08 10:27:51 +01:00
Thomas Heartman
73c4c62ea3
chore: track metrics for how many CRs are moved into next state with conflicts ( #6109 )
...
Use React's context to track how many CRs are moved into their next
state with conflicts present.
This PR wraps environment change requests and change request overviews
in a change request plausible context that contains a
`willOverwriteStrategyChanges` property. This property is updated by the
diff calculation if there are any conflicts and then read by the
`changeState` function in the `useChangeRequestApi` hook.
As long as at least one of the strategies in the CR contain conflicts,
it will be marked as overwriting changes.
2024-02-05 18:27:11 +09:00
Mateusz Kwasniewski
28fc36a1de
fix: exclude columns with commas ( #6102 )
2024-02-01 14:10:57 +01:00
Jaanus Sellin
c6a2303026
chore: remove featureSearchFrontend flag ( #6066 )
2024-01-31 09:22:26 +02:00
Nuno Góis
c1046079dd
chore: actions modal form ( #6057 )
...
https://linear.app/unleash/issue/2-1882/ui-add-actions-modal-and-form
Adds actions modal and form, allowing users to create and edit actions.
The main thing that is missing is adding the remaining fields, which
will be included in a later PR.
2024-01-29 11:15:29 +00:00
Nuno Góis
6ee4d2724e
fix: actions table UI improvements ( #6042 )
...
Includes some small fixes and improvements to the actions table UI:
- Fix webhook icon not properly loading
- Make actions execution param names bold in the tooltip
- Make filters param names bold in the tooltip
2024-01-26 09:52:19 +00:00
Nuno Góis
32484460ef
chore: project actions table ( #6039 )
...
https://linear.app/unleash/issue/2-1877/ui-add-actions-table
Implements the new project actions table.
2024-01-26 08:20:30 +00:00
Jaanus Sellin
e4ca8a3e6c
feat: track search bar events ( #6021 )
...
Adding tracking for 2 views, when users use the new search.
For features view and project view.
2024-01-24 14:23:23 +02:00
Nuno Góis
5d1d428746
chore: project actions tab ( #6009 )
...
https://linear.app/unleash/issue/2-1858/add-new-actions-tab-to-project-settings
Adds the new actions tab to project settings, hidden behind the
`automatedActions` feature flag.
2024-01-24 10:05:04 +00:00
Nuno Góis
13a9b1bc13
fix: project settings title ( #6011 )
...
Small fix to the project settings title, correcting it and making it
consistent.
2024-01-24 08:38:13 +00:00
Christopher Kolstad
8256c2eaf2
task: Use fine-grained project permissions in frontend ( #5974 )
...
Connected to [#5932 ](https://github.com/Unleash/unleash/pull/5932 ) -
This starts using the new permissions in addition to the old
UPDATE_PROJECT permission. That way, if you're happy with
UPDATE_PROJECT, you don't need to change.
However, you can now add more fine grained permissions for both READ and
WRITE operations.
2024-01-22 15:34:10 +01:00
Mateusz Kwasniewski
567099a15b
fix: table loader ( #5937 )
2024-01-18 11:26:42 +01:00
Christopher Kolstad
5a3bb1ffc3
Biome1.5.1 ( #5867 )
...
Lots of work here, mostly because I didn't want to turn off the
`noImplicitAnyLet` lint. This PR tries its best to type all the untyped
lets biome complained about (Don't ask me how many hours that took or
how many lints that was >200...), which in the future will force test
authors to actually type their global variables setup in `beforeAll`.
---------
Co-authored-by: Gastón Fournier <gaston@getunleash.io>
2024-01-12 09:25:59 +00:00
