mirror of
https://github.com/Unleash/unleash.git
synced 2024-11-01 19:07:38 +01:00
b071de6742
Previously we hard deleted the users, but due to change requests and possibly other features in future, we really want to hard-link user table and have meaningful relationships. But this means, when user is deleted, all linked data is also deleted. **Workaround is to soft delete users and just clear users data and keep the relationships alive for audit logs.** This PR implements this feature.
309 lines
9.6 KiB
TypeScript
309 lines
9.6 KiB
TypeScript
import dbInit from '../helpers/database-init';
|
|
import getLogger from '../../fixtures/no-logger';
|
|
import UserService from '../../../lib/services/user-service';
|
|
import { AccessService } from '../../../lib/services/access-service';
|
|
import UserStore from '../../../lib/db/user-store';
|
|
import ResetTokenService from '../../../lib/services/reset-token-service';
|
|
import { EmailService } from '../../../lib/services/email-service';
|
|
import { createTestConfig } from '../../config/test-config';
|
|
import SessionService from '../../../lib/services/session-service';
|
|
import NotFoundError from '../../../lib/error/notfound-error';
|
|
import { IRole } from '../../../lib/types/stores/access-store';
|
|
import { RoleName } from '../../../lib/types/model';
|
|
import SettingService from '../../../lib/services/setting-service';
|
|
import { simpleAuthSettingsKey } from '../../../lib/types/settings/simple-auth-settings';
|
|
import { addDays, minutesToMilliseconds } from 'date-fns';
|
|
import { GroupService } from '../../../lib/services/group-service';
|
|
import { randomId } from '../../../lib/util/random-id';
|
|
import { BadDataError } from '../../../lib/error';
|
|
|
|
let db;
|
|
let stores;
|
|
let userService: UserService;
|
|
let userStore: UserStore;
|
|
let adminRole: IRole;
|
|
let viewerRole: IRole;
|
|
let sessionService: SessionService;
|
|
let settingService: SettingService;
|
|
|
|
beforeAll(async () => {
|
|
db = await dbInit('user_service_serial', getLogger);
|
|
stores = db.stores;
|
|
const config = createTestConfig();
|
|
const groupService = new GroupService(stores, config);
|
|
const accessService = new AccessService(stores, config, groupService);
|
|
const resetTokenService = new ResetTokenService(stores, config);
|
|
const emailService = new EmailService(undefined, config.getLogger);
|
|
sessionService = new SessionService(stores, config);
|
|
settingService = new SettingService(stores, config);
|
|
|
|
userService = new UserService(stores, config, {
|
|
accessService,
|
|
resetTokenService,
|
|
emailService,
|
|
sessionService,
|
|
settingService,
|
|
});
|
|
userStore = stores.userStore;
|
|
const rootRoles = await accessService.getRootRoles();
|
|
adminRole = rootRoles.find((r) => r.name === RoleName.ADMIN);
|
|
viewerRole = rootRoles.find((r) => r.name === RoleName.VIEWER);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await db.destroy();
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await userStore.deleteAll();
|
|
});
|
|
|
|
test('should create initial admin user', async () => {
|
|
await userService.initAdminUser();
|
|
await expect(async () =>
|
|
userService.loginUser('admin', 'wrong-password'),
|
|
).rejects.toThrow(Error);
|
|
await expect(async () =>
|
|
userService.loginUser('admin', 'unleash4all'),
|
|
).toBeTruthy();
|
|
});
|
|
|
|
test('should not init default user if we already have users', async () => {
|
|
await userService.createUser({
|
|
username: 'test',
|
|
password: 'A very strange P4ssw0rd_',
|
|
rootRole: adminRole.id,
|
|
});
|
|
await userService.initAdminUser();
|
|
const users = await userService.getAll();
|
|
expect(users).toHaveLength(1);
|
|
expect(users[0].username).toBe('test');
|
|
await expect(async () =>
|
|
userService.loginUser('admin', 'unleash4all'),
|
|
).rejects.toThrow(Error);
|
|
});
|
|
|
|
test('should not be allowed to create existing user', async () => {
|
|
await userStore.insert({ username: 'test', name: 'Hans Mola' });
|
|
await expect(async () =>
|
|
userService.createUser({ username: 'test', rootRole: adminRole.id }),
|
|
).rejects.toThrow(Error);
|
|
});
|
|
|
|
test('should create user with password', async () => {
|
|
await userService.createUser({
|
|
username: 'test',
|
|
password: 'A very strange P4ssw0rd_',
|
|
rootRole: adminRole.id,
|
|
});
|
|
const user = await userService.loginUser(
|
|
'test',
|
|
'A very strange P4ssw0rd_',
|
|
);
|
|
expect(user.username).toBe('test');
|
|
});
|
|
|
|
test('should not be able to login with deleted user', async () => {
|
|
const user = await userService.createUser({
|
|
username: 'deleted_user',
|
|
password: 'unleash4all',
|
|
rootRole: adminRole.id,
|
|
});
|
|
|
|
await userService.deleteUser(user.id);
|
|
|
|
await expect(
|
|
userService.loginUser('deleted_user', 'unleash4all'),
|
|
).rejects.toThrow(new NotFoundError(`No user found`));
|
|
});
|
|
|
|
test('should not login user if simple auth is disabled', async () => {
|
|
await settingService.insert(
|
|
simpleAuthSettingsKey,
|
|
{ disabled: true },
|
|
randomId(),
|
|
);
|
|
|
|
await userService.createUser({
|
|
username: 'test_no_pass',
|
|
password: 'A very strange P4ssw0rd_',
|
|
rootRole: adminRole.id,
|
|
});
|
|
|
|
await expect(async () => {
|
|
await userService.loginUser('test_no_pass', 'A very strange P4ssw0rd_');
|
|
}).rejects.toThrowError(
|
|
'Logging in with username/password has been disabled.',
|
|
);
|
|
});
|
|
|
|
test('should login for user _without_ password', async () => {
|
|
const email = 'some@test.com';
|
|
await userService.createUser({
|
|
email,
|
|
password: 'A very strange P4ssw0rd_',
|
|
rootRole: adminRole.id,
|
|
});
|
|
const user = await userService.loginUserWithoutPassword(email);
|
|
expect(user.email).toBe(email);
|
|
});
|
|
|
|
test('should get user with root role', async () => {
|
|
const email = 'some@test.com';
|
|
const u = await userService.createUser({
|
|
email,
|
|
password: 'A very strange P4ssw0rd_',
|
|
rootRole: adminRole.id,
|
|
});
|
|
const user = await userService.getUser(u.id);
|
|
expect(user.email).toBe(email);
|
|
expect(user.id).toBe(u.id);
|
|
expect(user.rootRole).toBe(adminRole.id);
|
|
});
|
|
|
|
test('should get user with root role by name', async () => {
|
|
const email = 'some2@test.com';
|
|
const u = await userService.createUser({
|
|
email,
|
|
password: 'A very strange P4ssw0rd_',
|
|
rootRole: RoleName.ADMIN,
|
|
});
|
|
const user = await userService.getUser(u.id);
|
|
expect(user.email).toBe(email);
|
|
expect(user.id).toBe(u.id);
|
|
expect(user.rootRole).toBe(adminRole.id);
|
|
});
|
|
|
|
test("deleting a user should delete the user's sessions", async () => {
|
|
const email = 'some@test.com';
|
|
const user = await userService.createUser({
|
|
email,
|
|
password: 'A very strange P4ssw0rd_',
|
|
rootRole: adminRole.id,
|
|
});
|
|
const testComSession = {
|
|
sid: 'xyz321',
|
|
sess: {
|
|
cookie: {
|
|
originalMaxAge: minutesToMilliseconds(48),
|
|
expires: addDays(Date.now(), 1).toDateString(),
|
|
secure: false,
|
|
httpOnly: true,
|
|
path: '/',
|
|
},
|
|
user,
|
|
},
|
|
};
|
|
await sessionService.insertSession(testComSession);
|
|
const userSessions = await sessionService.getSessionsForUser(user.id);
|
|
expect(userSessions.length).toBe(1);
|
|
await userService.deleteUser(user.id);
|
|
await expect(async () =>
|
|
sessionService.getSessionsForUser(user.id),
|
|
).rejects.toThrow(NotFoundError);
|
|
});
|
|
|
|
test('updating a user without an email should not strip the email', async () => {
|
|
const email = 'some@test.com';
|
|
const user = await userService.createUser({
|
|
email,
|
|
password: 'A very strange P4ssw0rd_',
|
|
rootRole: adminRole.id,
|
|
});
|
|
|
|
await userService.updateUser({
|
|
id: user.id,
|
|
email: null,
|
|
name: 'some',
|
|
});
|
|
|
|
const updatedUser = await userService.getUser(user.id);
|
|
expect(updatedUser.email).toBe(email);
|
|
});
|
|
|
|
test('should login and create user via SSO', async () => {
|
|
const email = 'some@test.com';
|
|
const user = await userService.loginUserSSO({
|
|
email,
|
|
rootRole: RoleName.VIEWER,
|
|
name: 'some',
|
|
autoCreate: true,
|
|
});
|
|
|
|
const userWithRole = await userService.getUser(user.id);
|
|
expect(user.email).toBe(email);
|
|
expect(user.name).toBe('some');
|
|
expect(userWithRole.name).toBe('some');
|
|
expect(userWithRole.rootRole).toBe(viewerRole.id);
|
|
});
|
|
|
|
test('should throw if rootRole is wrong via SSO', async () => {
|
|
expect.assertions(1);
|
|
|
|
await expect(
|
|
userService.loginUserSSO({
|
|
email: 'some@test.com',
|
|
rootRole: RoleName.MEMBER,
|
|
name: 'some',
|
|
autoCreate: true,
|
|
}),
|
|
).rejects.toThrow(new BadDataError(`Could not find rootRole=Member`));
|
|
});
|
|
|
|
test('should update user name when signing in via SSO', async () => {
|
|
const email = 'some@test.com';
|
|
const originalUser = await userService.createUser({
|
|
email,
|
|
rootRole: RoleName.VIEWER,
|
|
name: 'some',
|
|
});
|
|
|
|
await userService.loginUserSSO({
|
|
email,
|
|
rootRole: RoleName.ADMIN,
|
|
name: 'New name!',
|
|
autoCreate: true,
|
|
});
|
|
|
|
const actualUser = await userService.getUser(originalUser.id);
|
|
|
|
expect(actualUser.email).toBe(email);
|
|
expect(actualUser.name).toBe('New name!');
|
|
expect(actualUser.rootRole).toBe(viewerRole.id);
|
|
});
|
|
|
|
test('should update name if it is different via SSO', async () => {
|
|
const email = 'some@test.com';
|
|
const originalUser = await userService.createUser({
|
|
email,
|
|
rootRole: RoleName.VIEWER,
|
|
name: 'some',
|
|
});
|
|
|
|
await userService.loginUserSSO({
|
|
email,
|
|
rootRole: RoleName.ADMIN,
|
|
name: 'New name!',
|
|
autoCreate: false,
|
|
});
|
|
|
|
const actualUser = await userService.getUser(originalUser.id);
|
|
|
|
expect(actualUser.email).toBe(email);
|
|
expect(actualUser.name).toBe('New name!');
|
|
expect(actualUser.rootRole).toBe(viewerRole.id);
|
|
});
|
|
|
|
test('should throw if autoCreate is false via SSO', async () => {
|
|
expect.assertions(1);
|
|
|
|
await expect(
|
|
userService.loginUserSSO({
|
|
email: 'some@test.com',
|
|
rootRole: RoleName.MEMBER,
|
|
name: 'some',
|
|
autoCreate: false,
|
|
}),
|
|
).rejects.toThrow(new NotFoundError(`No user found`));
|
|
});
|