mirror of
https://github.com/Unleash/unleash.git
synced 2025-01-01 00:08:27 +01:00
16507a971b
## About the changes Some tests are reporting this error: `MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 UPDATE_REVISION listeners added to [ConfigurationRevisionService]. Use emitter.setMaxListeners() to increase limit` I thought it's because of this change https://github.com/Unleash/unleash/pull/6400#discussion_r1511494201 but it was not. I've managed to get a trace of the issue following this https://stackoverflow.com/q/62897235/239613 and now we can identify `ConfigurationRevisionService` as one explanation. The reason is that it's a singleton that should be cleaned up after tests. E.g.: https://github.com/Unleash/unleash/actions/runs/8248332132/job/22558419656?pr=6517#step:8:15 |
||
---|---|---|
.. | ||
__snapshots__ | ||
addons | ||
db | ||
domain/project-health | ||
error | ||
features | ||
middleware | ||
openapi | ||
routes | ||
schema | ||
services | ||
types | ||
users | ||
util | ||
app.test.ts | ||
app.ts | ||
create-config.test.ts | ||
create-config.ts | ||
default-custom-auth-deny-all.ts | ||
internals.ts | ||
logger.test.ts | ||
logger.ts | ||
metric-events.ts | ||
metrics.test.ts | ||
metrics.ts | ||
server-impl.test.ts | ||
server-impl.ts |