1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-31 00:16:47 +01:00
unleash.unleash/src/lib/addons
Nuno Góis 1dcb33d4e7
fix: simplify channels logic in slack app integration (#4756)
https://linear.app/unleash/issue/2-1393/drop-the-always-post-to-default-channels-field

This drops the "Always post to default channels" field in the Slack App
integration in favor of always posting to the configured channels. This
should simplify the configuration of this integration.

Here's a breakdown of the logic with this change:
 - Always post to the configured Slack channels, regardless of tags;
- Tags are still respected. E.g. if we have a configured channel
"channel-1" and a tag for "channel-2", then we post to both channels;
- As channels are optional, if you would like to skip default channels
for certain events and handle everything through tags, you can just
create a new configuration without any default channels;

This also updates the labels and changes the tests to better reflect the
intended behavior.


![image](https://github.com/Unleash/unleash/assets/14320932/a2427bdd-4b92-44b3-9bad-8adb0f94c34d)
2023-09-18 08:32:37 +01:00
..
__snapshots__ fix: update slack-app tests to reflect what we now do 2023-08-15 13:17:06 +02:00
addon-schema.ts fix: addon schema validation (#4643) 2023-09-08 09:39:57 +00:00
addon.test.ts
addon.ts feat: improve slack app addon scalability (#4284) 2023-07-20 13:37:06 +01:00
datadog-definition.ts fix: integrations text review (#4706) 2023-09-14 12:01:29 +00:00
datadog.test.ts chore: Datadog addon, ability to include source type name (#4196) 2023-07-10 15:38:53 +02:00
datadog.ts chore: Datadog addon, ability to include source type name (#4196) 2023-07-10 15:38:53 +02:00
feature-event-formatter-md.test.ts
feature-event-formatter-md.ts Feat(#4205): add potentially stale events to addons (#4279) 2023-07-19 13:52:19 +00:00
index.ts fix: misc integration-related fixes and improvements (#4754) 2023-09-15 14:50:59 +01:00
installation-definition-schema.ts feat: Slack App addon (#4238) 2023-07-14 09:49:34 +01:00
slack-app-definition.ts fix: simplify channels logic in slack app integration (#4756) 2023-09-18 08:32:37 +01:00
slack-app.test.ts fix: simplify channels logic in slack app integration (#4756) 2023-09-18 08:32:37 +01:00
slack-app.ts fix: simplify channels logic in slack app integration (#4756) 2023-09-18 08:32:37 +01:00
slack-definition.ts fix: misc integration-related fixes and improvements (#4754) 2023-09-15 14:50:59 +01:00
slack.test.ts
slack.ts
teams-definition.ts fix: integrations text review (#4706) 2023-09-14 12:01:29 +00:00
teams.test.ts
teams.ts
webhook-definition.ts fix: integrations text review (#4706) 2023-09-14 12:01:29 +00:00
webhook.test.ts
webhook.ts