mirror of
https://github.com/Unleash/unleash.git
synced 2024-12-22 19:07:54 +01:00
95f4f641b5
https://linear.app/unleash/issue/2-1136/custom-root-roles-documentation - [Adds documentation referencing custom root roles](https://unleash-docs-git-docs-custom-root-roles-unleash-team.vercel.app/reference/rbac); - [Adds a "How to create and assign custom root roles" how-to guide](https://unleash-docs-git-docs-custom-root-roles-unleash-team.vercel.app/how-to/how-to-create-and-assign-custom-root-roles); - Standardizes "global" roles to "root" roles; - Standardizes "standard" roles to "predefined" roles to better reflect their behavior and what is shown in our UI; - Updates predefined role descriptions and makes them consistent; - Updates the side panel description of the user form; - Includes some boy scouting with some tiny fixes of things identified along the way (e.g. the role form was persisting old data when closed and re-opened); Questions: - Is it worth expanding the "Assigning custom root roles" section in the "How to create and assign custom root roles" guide to include the steps for assigning a root role for each entity (user, service account, group)? - Should this PR include an update to the existing "How to create and assign custom project roles" guide? We've since updated the UI; --------- Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
640 lines
21 KiB
TypeScript
640 lines
21 KiB
TypeScript
import { Request, Response } from 'express';
|
|
import Controller from '../controller';
|
|
import { ADMIN, NONE } from '../../types/permissions';
|
|
import UserService from '../../services/user-service';
|
|
import { AccountService } from '../../services/account-service';
|
|
import { AccessService } from '../../services/access-service';
|
|
import { Logger } from '../../logger';
|
|
import { IUnleashConfig, IUnleashServices, RoleName } from '../../types';
|
|
import { EmailService } from '../../services/email-service';
|
|
import ResetTokenService from '../../services/reset-token-service';
|
|
import { IAuthRequest } from '../unleash-types';
|
|
import SettingService from '../../services/setting-service';
|
|
import { IUser, SimpleAuthSettings } from '../../server-impl';
|
|
import { simpleAuthSettingsKey } from '../../types/settings/simple-auth-settings';
|
|
import { anonymise } from '../../util/anonymise';
|
|
import { OpenApiService } from '../../services/openapi-service';
|
|
import { createRequestSchema } from '../../openapi/util/create-request-schema';
|
|
import {
|
|
createResponseSchema,
|
|
resourceCreatedResponseSchema,
|
|
} from '../../openapi/util/create-response-schema';
|
|
import { userSchema, UserSchema } from '../../openapi/spec/user-schema';
|
|
import { serializeDates } from '../../types/serialize-dates';
|
|
import { usersSchema, UsersSchema } from '../../openapi/spec/users-schema';
|
|
import {
|
|
usersSearchSchema,
|
|
UsersSearchSchema,
|
|
} from '../../openapi/spec/users-search-schema';
|
|
import { CreateUserSchema } from '../../openapi/spec/create-user-schema';
|
|
import { UpdateUserSchema } from '../../openapi/spec/update-user-schema';
|
|
import { PasswordSchema } from '../../openapi/spec/password-schema';
|
|
import { IdSchema } from '../../openapi/spec/id-schema';
|
|
import {
|
|
resetPasswordSchema,
|
|
ResetPasswordSchema,
|
|
} from '../../openapi/spec/reset-password-schema';
|
|
import {
|
|
emptyResponse,
|
|
getStandardResponses,
|
|
} from '../../openapi/util/standard-responses';
|
|
import { GroupService } from '../../services/group-service';
|
|
import {
|
|
UsersGroupsBaseSchema,
|
|
usersGroupsBaseSchema,
|
|
} from '../../openapi/spec/users-groups-base-schema';
|
|
import { IGroup } from '../../types/group';
|
|
import { IFlagResolver } from '../../types/experimental';
|
|
import rateLimit from 'express-rate-limit';
|
|
import { minutesToMilliseconds } from 'date-fns';
|
|
import {
|
|
AdminCountSchema,
|
|
adminCountSchema,
|
|
} from '../../openapi/spec/admin-count-schema';
|
|
import { BadDataError } from '../../error';
|
|
import {
|
|
createUserResponseSchema,
|
|
CreateUserResponseSchema,
|
|
} from '../../openapi/spec/create-user-response-schema';
|
|
|
|
export default class UserAdminController extends Controller {
|
|
private flagResolver: IFlagResolver;
|
|
|
|
private userService: UserService;
|
|
|
|
private accountService: AccountService;
|
|
|
|
private accessService: AccessService;
|
|
|
|
private readonly logger: Logger;
|
|
|
|
private emailService: EmailService;
|
|
|
|
private resetTokenService: ResetTokenService;
|
|
|
|
private settingService: SettingService;
|
|
|
|
private openApiService: OpenApiService;
|
|
|
|
private groupService: GroupService;
|
|
|
|
readonly unleashUrl: string;
|
|
|
|
constructor(
|
|
config: IUnleashConfig,
|
|
{
|
|
userService,
|
|
accountService,
|
|
accessService,
|
|
emailService,
|
|
resetTokenService,
|
|
settingService,
|
|
openApiService,
|
|
groupService,
|
|
}: Pick<
|
|
IUnleashServices,
|
|
| 'userService'
|
|
| 'accountService'
|
|
| 'accessService'
|
|
| 'emailService'
|
|
| 'resetTokenService'
|
|
| 'settingService'
|
|
| 'openApiService'
|
|
| 'groupService'
|
|
>,
|
|
) {
|
|
super(config);
|
|
this.userService = userService;
|
|
this.accountService = accountService;
|
|
this.accessService = accessService;
|
|
this.emailService = emailService;
|
|
this.resetTokenService = resetTokenService;
|
|
this.settingService = settingService;
|
|
this.openApiService = openApiService;
|
|
this.groupService = groupService;
|
|
this.logger = config.getLogger('routes/user-controller.ts');
|
|
this.unleashUrl = config.server.unleashUrl;
|
|
this.flagResolver = config.flagResolver;
|
|
|
|
this.route({
|
|
method: 'post',
|
|
path: '/validate-password',
|
|
handler: this.validateUserPassword,
|
|
permission: NONE,
|
|
middleware: [
|
|
openApiService.validPath({
|
|
tags: ['Users'],
|
|
operationId: 'validateUserPassword',
|
|
summary: 'Validate password for a user',
|
|
description:
|
|
'Validate the password strength. Minimum 10 characters, uppercase letter, number, special character.',
|
|
requestBody: createRequestSchema('passwordSchema'),
|
|
responses: {
|
|
200: emptyResponse,
|
|
...getStandardResponses(400, 401, 415),
|
|
},
|
|
}),
|
|
],
|
|
});
|
|
|
|
this.route({
|
|
method: 'post',
|
|
path: '/:id/change-password',
|
|
handler: this.changeUserPassword,
|
|
permission: ADMIN,
|
|
middleware: [
|
|
openApiService.validPath({
|
|
tags: ['Users'],
|
|
operationId: 'changeUserPassword',
|
|
summary: 'Change password for a user',
|
|
description: 'Change password for a user as an admin',
|
|
requestBody: createRequestSchema('passwordSchema'),
|
|
responses: {
|
|
200: emptyResponse,
|
|
...getStandardResponses(400, 401, 403),
|
|
},
|
|
}),
|
|
],
|
|
});
|
|
|
|
this.route({
|
|
method: 'post',
|
|
path: '/reset-password',
|
|
handler: this.resetUserPassword,
|
|
permission: ADMIN,
|
|
middleware: [
|
|
openApiService.validPath({
|
|
tags: ['Users'],
|
|
operationId: 'resetUserPassword',
|
|
summary: 'Reset user password',
|
|
description: 'Reset user password as an admin',
|
|
requestBody: createRequestSchema('idSchema'),
|
|
responses: {
|
|
200: createResponseSchema('resetPasswordSchema'),
|
|
...getStandardResponses(400, 401, 403, 404),
|
|
},
|
|
}),
|
|
],
|
|
});
|
|
|
|
this.route({
|
|
method: 'get',
|
|
path: '',
|
|
handler: this.getUsers,
|
|
permission: ADMIN,
|
|
middleware: [
|
|
openApiService.validPath({
|
|
tags: ['Users'],
|
|
operationId: 'getUsers',
|
|
summary:
|
|
'Get all users and [root roles](https://docs.getunleash.io/reference/rbac#predefined-roles)',
|
|
description:
|
|
'Will return all users and all available root roles for the Unleash instance.',
|
|
responses: {
|
|
200: createResponseSchema('usersSchema'),
|
|
...getStandardResponses(401, 403),
|
|
},
|
|
}),
|
|
],
|
|
});
|
|
|
|
this.route({
|
|
method: 'get',
|
|
path: '/search',
|
|
handler: this.searchUsers,
|
|
permission: NONE,
|
|
middleware: [
|
|
openApiService.validPath({
|
|
tags: ['Users'],
|
|
operationId: 'searchUsers',
|
|
summary: 'Search users',
|
|
description:
|
|
' It will preform a simple search based on name and email matching the given query. Requires minimum 2 characters',
|
|
parameters: [
|
|
{
|
|
name: 'q',
|
|
description:
|
|
'The pattern to search in the username or email',
|
|
schema: { type: 'string' },
|
|
in: 'query',
|
|
},
|
|
],
|
|
responses: {
|
|
200: createResponseSchema('usersSchema'),
|
|
...getStandardResponses(401),
|
|
},
|
|
}),
|
|
],
|
|
});
|
|
|
|
this.route({
|
|
method: 'get',
|
|
path: '/access',
|
|
handler: this.getBaseUsersAndGroups,
|
|
permission: NONE,
|
|
middleware: [
|
|
openApiService.validPath({
|
|
tags: ['Users'],
|
|
operationId: 'getBaseUsersAndGroups',
|
|
summary: 'Get basic user and group information',
|
|
description:
|
|
'Get a subset of user and group information eligible even for non-admin users',
|
|
responses: {
|
|
200: createResponseSchema('usersGroupsBaseSchema'),
|
|
...getStandardResponses(401),
|
|
},
|
|
}),
|
|
],
|
|
});
|
|
|
|
this.route({
|
|
method: 'get',
|
|
path: '/admin-count',
|
|
handler: this.getAdminCount,
|
|
permission: ADMIN,
|
|
middleware: [
|
|
openApiService.validPath({
|
|
tags: ['Users'],
|
|
operationId: 'getAdminCount',
|
|
summary: 'Get total count of admin accounts',
|
|
description:
|
|
'Get a total count of admins with password, without password and admin service accounts',
|
|
responses: {
|
|
200: createResponseSchema('adminCountSchema'),
|
|
...getStandardResponses(401, 403),
|
|
},
|
|
}),
|
|
],
|
|
});
|
|
|
|
this.route({
|
|
method: 'post',
|
|
path: '',
|
|
handler: this.createUser,
|
|
permission: ADMIN,
|
|
middleware: [
|
|
openApiService.validPath({
|
|
tags: ['Users'],
|
|
operationId: 'createUser',
|
|
summary: 'Create a new user',
|
|
description: 'Creates a new user with the given root role.',
|
|
requestBody: createRequestSchema('createUserSchema'),
|
|
responses: {
|
|
201: resourceCreatedResponseSchema(
|
|
'createUserResponseSchema',
|
|
),
|
|
...getStandardResponses(400, 401, 403),
|
|
},
|
|
}),
|
|
rateLimit({
|
|
windowMs: minutesToMilliseconds(1),
|
|
max: 20,
|
|
validate: false,
|
|
standardHeaders: true,
|
|
legacyHeaders: false,
|
|
}),
|
|
],
|
|
});
|
|
|
|
this.route({
|
|
method: 'get',
|
|
path: '/:id',
|
|
handler: this.getUser,
|
|
permission: ADMIN,
|
|
middleware: [
|
|
openApiService.validPath({
|
|
tags: ['Users'],
|
|
operationId: 'getUser',
|
|
summary: 'Get user',
|
|
description: 'Will return a single user by id',
|
|
responses: {
|
|
200: createResponseSchema('userSchema'),
|
|
...getStandardResponses(400, 401, 404),
|
|
},
|
|
}),
|
|
],
|
|
});
|
|
|
|
this.route({
|
|
method: 'put',
|
|
path: '/:id',
|
|
handler: this.updateUser,
|
|
permission: ADMIN,
|
|
middleware: [
|
|
openApiService.validPath({
|
|
tags: ['Users'],
|
|
operationId: 'updateUser',
|
|
summary: 'Update a user',
|
|
description:
|
|
'Only the explicitly specified fields get updated.',
|
|
requestBody: createRequestSchema('updateUserSchema'),
|
|
responses: {
|
|
200: createResponseSchema('createUserResponseSchema'),
|
|
...getStandardResponses(400, 401, 403, 404),
|
|
},
|
|
}),
|
|
],
|
|
});
|
|
|
|
this.route({
|
|
method: 'delete',
|
|
path: '/:id',
|
|
acceptAnyContentType: true,
|
|
handler: this.deleteUser,
|
|
permission: ADMIN,
|
|
middleware: [
|
|
openApiService.validPath({
|
|
tags: ['Users'],
|
|
operationId: 'deleteUser',
|
|
summary: 'Delete a user',
|
|
description: 'Deletes the user with the given userId',
|
|
responses: {
|
|
200: emptyResponse,
|
|
...getStandardResponses(401, 403, 404),
|
|
},
|
|
}),
|
|
],
|
|
});
|
|
}
|
|
|
|
async resetUserPassword(
|
|
req: IAuthRequest<unknown, ResetPasswordSchema, IdSchema>,
|
|
res: Response<ResetPasswordSchema>,
|
|
): Promise<void> {
|
|
const { user } = req;
|
|
const receiver = req.body.id;
|
|
const resetPasswordUrl =
|
|
await this.userService.createResetPasswordEmail(receiver, user);
|
|
|
|
this.openApiService.respondWithValidation(
|
|
200,
|
|
res,
|
|
resetPasswordSchema.$id,
|
|
{ resetPasswordUrl: resetPasswordUrl.toString() },
|
|
);
|
|
}
|
|
|
|
async getUsers(req: Request, res: Response<UsersSchema>): Promise<void> {
|
|
const users = await this.userService.getAll();
|
|
const rootRoles = await this.accessService.getRootRoles();
|
|
const inviteLinks = await this.resetTokenService.getActiveInvitations();
|
|
|
|
const usersWithInviteLinks = users.map((user) => {
|
|
const inviteLink = inviteLinks[user.id] || '';
|
|
return { ...user, inviteLink };
|
|
});
|
|
|
|
this.openApiService.respondWithValidation(200, res, usersSchema.$id, {
|
|
users: serializeDates(usersWithInviteLinks),
|
|
rootRoles,
|
|
});
|
|
}
|
|
|
|
anonymiseUsers(users: IUser[]): IUser[] {
|
|
return users.map((u) => ({
|
|
...u,
|
|
name: anonymise(u.name),
|
|
username: anonymise(u.username),
|
|
email: anonymise(u.email || 'random'),
|
|
imageUrl:
|
|
'https://gravatar.com/avatar/21232f297a57a5a743894a0e4a801fc3?size=42&default=retro',
|
|
}));
|
|
}
|
|
|
|
async searchUsers(
|
|
req: Request,
|
|
res: Response<UsersSearchSchema>,
|
|
): Promise<void> {
|
|
const { q } = req.query;
|
|
let users =
|
|
typeof q === 'string' && q.length > 1
|
|
? await this.userService.search(q)
|
|
: [];
|
|
if (this.flagResolver.isEnabled('anonymiseEventLog')) {
|
|
users = this.anonymiseUsers(users);
|
|
}
|
|
this.openApiService.respondWithValidation(
|
|
200,
|
|
res,
|
|
usersSearchSchema.$id,
|
|
serializeDates(users),
|
|
);
|
|
}
|
|
|
|
async getBaseUsersAndGroups(
|
|
req: Request,
|
|
res: Response<UsersGroupsBaseSchema>,
|
|
): Promise<void> {
|
|
let allUsers = await this.accountService.getAll();
|
|
let users = allUsers.map((u) => {
|
|
return {
|
|
id: u.id,
|
|
name: u.name,
|
|
username: u.username,
|
|
email: u.email,
|
|
accountType: u.accountType,
|
|
} as IUser;
|
|
});
|
|
if (this.flagResolver.isEnabled('anonymiseEventLog')) {
|
|
users = this.anonymiseUsers(users);
|
|
}
|
|
|
|
let allGroups = await this.groupService.getAll();
|
|
let groups = allGroups.map((g) => {
|
|
return {
|
|
id: g.id,
|
|
name: g.name,
|
|
userCount: g.users.length,
|
|
rootRole: g.rootRole,
|
|
} as IGroup;
|
|
});
|
|
this.openApiService.respondWithValidation(
|
|
200,
|
|
res,
|
|
usersGroupsBaseSchema.$id,
|
|
{
|
|
users: serializeDates(users),
|
|
groups: serializeDates(groups),
|
|
},
|
|
);
|
|
}
|
|
|
|
async getUser(req: Request, res: Response<UserSchema>): Promise<void> {
|
|
const { id } = req.params;
|
|
if (!Number.isInteger(Number(id))) {
|
|
throw new BadDataError('User id should be an integer');
|
|
}
|
|
const user = await this.userService.getUser(Number(id));
|
|
|
|
this.openApiService.respondWithValidation(
|
|
200,
|
|
res,
|
|
userSchema.$id,
|
|
serializeDates(user),
|
|
);
|
|
}
|
|
|
|
async createUser(
|
|
req: IAuthRequest<unknown, unknown, CreateUserSchema>,
|
|
res: Response<CreateUserResponseSchema>,
|
|
): Promise<void> {
|
|
const { username, email, name, rootRole, sendEmail, password } =
|
|
req.body;
|
|
const { user } = req;
|
|
const normalizedRootRole = Number.isInteger(Number(rootRole))
|
|
? Number(rootRole)
|
|
: (rootRole as RoleName);
|
|
|
|
const createdUser = await this.userService.createUser(
|
|
{
|
|
username,
|
|
email,
|
|
name,
|
|
password,
|
|
rootRole: normalizedRootRole,
|
|
},
|
|
user,
|
|
);
|
|
|
|
const passwordAuthSettings =
|
|
await this.settingService.get<SimpleAuthSettings>(
|
|
simpleAuthSettingsKey,
|
|
);
|
|
|
|
let inviteLink: string;
|
|
if (!passwordAuthSettings?.disabled) {
|
|
const inviteUrl = await this.resetTokenService.createNewUserUrl(
|
|
createdUser.id,
|
|
user.email,
|
|
);
|
|
inviteLink = inviteUrl.toString();
|
|
}
|
|
|
|
let emailSent = false;
|
|
const emailConfigured = this.emailService.configured();
|
|
const reallySendEmail =
|
|
emailConfigured && (sendEmail !== undefined ? sendEmail : true);
|
|
|
|
if (reallySendEmail) {
|
|
try {
|
|
await this.emailService.sendGettingStartedMail(
|
|
createdUser.name,
|
|
createdUser.email,
|
|
this.unleashUrl,
|
|
inviteLink,
|
|
);
|
|
emailSent = true;
|
|
} catch (e) {
|
|
this.logger.warn(
|
|
'email was configured, but sending failed due to: ',
|
|
e,
|
|
);
|
|
}
|
|
} else {
|
|
this.logger.warn(
|
|
'email was not sent to the user because email configuration is lacking',
|
|
);
|
|
}
|
|
|
|
const responseData: CreateUserResponseSchema = {
|
|
...serializeDates(createdUser),
|
|
inviteLink: inviteLink || this.unleashUrl,
|
|
emailSent,
|
|
rootRole: normalizedRootRole,
|
|
};
|
|
|
|
this.openApiService.respondWithValidation(
|
|
201,
|
|
res,
|
|
createUserResponseSchema.$id,
|
|
responseData,
|
|
{ location: `${responseData.id}` },
|
|
);
|
|
}
|
|
|
|
async updateUser(
|
|
req: IAuthRequest<
|
|
{ id: string },
|
|
CreateUserResponseSchema,
|
|
UpdateUserSchema
|
|
>,
|
|
res: Response<CreateUserResponseSchema>,
|
|
): Promise<void> {
|
|
const { user, params, body } = req;
|
|
const { id } = params;
|
|
const { name, email, rootRole } = body;
|
|
if (!Number.isInteger(Number(id))) {
|
|
throw new BadDataError('User id should be an integer');
|
|
}
|
|
const normalizedRootRole = Number.isInteger(Number(rootRole))
|
|
? Number(rootRole)
|
|
: (rootRole as RoleName);
|
|
|
|
const updateUser = await this.userService.updateUser(
|
|
{
|
|
id: Number(id),
|
|
name,
|
|
email,
|
|
rootRole: normalizedRootRole,
|
|
},
|
|
user,
|
|
);
|
|
|
|
this.openApiService.respondWithValidation(
|
|
200,
|
|
res,
|
|
createUserResponseSchema.$id,
|
|
{
|
|
...serializeDates(updateUser),
|
|
rootRole: normalizedRootRole,
|
|
},
|
|
);
|
|
}
|
|
|
|
async deleteUser(req: IAuthRequest, res: Response): Promise<void> {
|
|
const { user, params } = req;
|
|
const { id } = params;
|
|
if (!Number.isInteger(Number(id))) {
|
|
throw new BadDataError('User id should be an integer');
|
|
}
|
|
|
|
await this.userService.deleteUser(+id, user);
|
|
res.status(200).send();
|
|
}
|
|
|
|
async validateUserPassword(
|
|
req: IAuthRequest<unknown, unknown, PasswordSchema>,
|
|
res: Response,
|
|
): Promise<void> {
|
|
const { password } = req.body;
|
|
|
|
this.userService.validatePassword(password);
|
|
res.status(200).send();
|
|
}
|
|
|
|
async changeUserPassword(
|
|
req: IAuthRequest<{ id: string }, unknown, PasswordSchema>,
|
|
res: Response,
|
|
): Promise<void> {
|
|
const { id } = req.params;
|
|
const { password } = req.body;
|
|
|
|
await this.userService.changePassword(+id, password);
|
|
res.status(200).send();
|
|
}
|
|
|
|
async getAdminCount(
|
|
req: Request,
|
|
res: Response<AdminCountSchema>,
|
|
): Promise<void> {
|
|
const adminCount = await this.accountService.getAdminCount();
|
|
|
|
this.openApiService.respondWithValidation(
|
|
200,
|
|
res,
|
|
adminCountSchema.$id,
|
|
adminCount,
|
|
);
|
|
}
|
|
}
|