mirror of
https://github.com/Unleash/unleash.git
synced 2025-10-13 11:17:26 +02:00
90915cfdd7
This PR adds a strategy sorting algorithm to be used for the segment deletion dialog. It assumes that you have a list of existing strategies and a list of change request strategies. Based on the content of these two lists, it will create one unified list sorted after a number of criteria (as listed in the test). # Discussion point: This impl does the sorting on the front end, but could we do it on the back end? Instead of adding a new property to the segment data, could we simply fold the change request strategies in with the existing segment strategies and return it using the old property? If the only place we do that is in this view, then that might be a good suggestion. Response: I'll leave this in the front end for now. The reason is that we can't add change request strategies to the existing `strategies` property of the API payload without it being a breaking change. The OpenAPI schema says that `id` is a required field on a strategy, and that field doesn't exist on strategies that have only been added in change requests, but not yet applied. |
||
|---|---|---|
| .. | ||
| accessOverview | ||
| admin | ||
| application | ||
| archive | ||
| banners | ||
| changeRequest | ||
| common | ||
| context | ||
| demo | ||
| environments | ||
| events | ||
| feature | ||
| featureTypes | ||
| feedback | ||
| integrations | ||
| layout | ||
| loginHistory | ||
| maintenance | ||
| menu | ||
| playground/Playground | ||
| project | ||
| providers | ||
| segments | ||
| splash | ||
| strategies | ||
| tags | ||
| user | ||
| App.tsx | ||
| InitialRedirect.tsx | ||