1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-24 17:51:14 +02:00
unleash.unleash/frontend/src/component
Nuno Góis 233e06ec6a
fix: disable autoResetHiddenColumns when useConditionallyHiddenColumns (#2851)
https://linear.app/unleash/issue/2-563/fix-issue-with-useconditionallyhiddencolumns-and-react-table

It seems like we should add `autoResetHiddenColumns: false` to
`useTable` whenever we use `useConditionallyHiddenColumns`.

Basically the thought is that, if we're controlling column visibility in
our own way, we should not want other things to change that state
unpredictably, otherwise this may make React go _brrrrrr_. And it can be
very hard to pinpoint what exactly may be causing React to go _brrrrrr_.


![image](https://user-images.githubusercontent.com/14320932/211332339-95918c5c-e3ea-40e9-b8b4-756a798a4702.png)

First detected this issue apparently randomly while developing the new
SA table. Around 10-20 page refreshes would eventually trigger it. Was
not easy to find, but hopefully this fixes it permanently. At least I
haven't been able to reproduce it since. Maybe someone has a better idea
of where the issue could be or if this is a pretty good guess. Doesn't
seem like this change hurts us anyways.

I love React, `useEffect` and these very to-the-point error messages.
Very fun and productive.

Reference: https://react-table-v7.tanstack.com/docs/api/useTable
2023-01-10 08:15:12 +00:00
..
addons POC: integration tests (#2422) 2022-12-06 15:28:33 +01:00
admin fix: disable autoResetHiddenColumns when useConditionallyHiddenColumns (#2851) 2023-01-10 08:15:12 +00:00
application Fix crashing search bars (#2765) 2022-12-28 12:35:27 +02:00
archive fix: disable autoResetHiddenColumns when useConditionallyHiddenColumns (#2851) 2023-01-10 08:15:12 +00:00
changeRequest fix: disable autoResetHiddenColumns when useConditionallyHiddenColumns (#2851) 2023-01-10 08:15:12 +00:00
common MakeStyles refactor 1-3 (#2835) 2023-01-09 10:41:58 +02:00
context Styled components batch4.1 (#2812) 2023-01-05 09:45:39 +01:00
environments Styled components batch4.1 (#2812) 2023-01-05 09:45:39 +01:00
events visual changes representation (#2583) 2022-12-01 14:44:33 +01:00
feature fix: disable autoResetHiddenColumns when useConditionallyHiddenColumns (#2851) 2023-01-10 08:15:12 +00:00
feedback MakeStyles refactor 1-3 (#2835) 2023-01-09 10:41:58 +02:00
layout fix: archived feature layout (#2713) 2023-01-04 09:24:39 +00:00
maintenance Maintenance mode for users (#2716) 2022-12-21 13:23:44 +02:00
menu MakeStyles refactor 1-3 (#2835) 2023-01-09 10:41:58 +02:00
playground/Playground fix: disable autoResetHiddenColumns when useConditionallyHiddenColumns (#2851) 2023-01-10 08:15:12 +00:00
project fix: disable autoResetHiddenColumns when useConditionallyHiddenColumns (#2851) 2023-01-10 08:15:12 +00:00
providers feat: allows creation of PATs for other users (#2718) 2023-01-02 10:49:57 +00:00
segments fix: disable autoResetHiddenColumns when useConditionallyHiddenColumns (#2851) 2023-01-10 08:15:12 +00:00
splash Makestyles refactor #7/1 (#2805) 2023-01-03 16:30:59 +02:00
strategies Makestyles refactor #7/1 (#2805) 2023-01-03 16:30:59 +02:00
tags MakeStyles refactor 1-3 (#2835) 2023-01-09 10:41:58 +02:00
user fix: disable autoResetHiddenColumns when useConditionallyHiddenColumns (#2851) 2023-01-10 08:15:12 +00:00
App.styles.ts Suggest changes - initial frontend (#2213) 2022-10-20 14:00:48 +02:00
App.tsx Maintenance mode for users (#2716) 2022-12-21 13:23:44 +02:00