1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-19 17:52:45 +02:00
unleash.unleash/src
Gastón Fournier 37ce81a727
chore: re-use the same client schema for proxy (#3251)
## About the changes
client-metrics-schema is less strict than proxy-metrics-schema because
the former allows empty `instanceId` and also supports dates as
timestamps as well as date-formatted strings.

Using the same schema makes sense to reduce maintainability costs and
it's less error-prone if we need to modify the schema because underlying
the schema they both use the same code.

The reasoning is that proxy metrics should align with our client
metrics. Alternatively, we have new endpoints for edge metrics that will
aggregate and bucket by client.


![image](https://user-images.githubusercontent.com/455064/222738911-4c443e02-3072-4042-bfde-327da8dd46fe.png)


## Discussion points
Will we ever want to evolve proxy-metrics differently than
client-metrics? I'm under the assumption that the answer is no
2023-03-03 16:36:23 +01:00
..
lib chore: re-use the same client schema for proxy (#3251) 2023-03-03 16:36:23 +01:00
mailtemplates refactor: move docs into new structure / fix links for SEO (#2416) 2022-11-22 09:05:30 +00:00
migrations refactor: rename sign-on log to login history (#3245) 2023-03-02 13:49:50 +00:00
test chore: re-use the same client schema for proxy (#3251) 2023-03-03 16:36:23 +01:00
migrator.ts fix: be explicit when specifying time & replace moment with date-fns (#1072) 2021-11-02 15:13:46 +01:00
server-dev.ts feat: remove maintenance feature flag (#3199) 2023-02-27 15:36:56 +02:00
server.ts Define exports for enterprise (#2435) 2022-11-17 13:02:40 +02:00