mirror of
https://github.com/Unleash/unleash.git
synced 2025-01-01 00:08:27 +01:00
2531819222
This change addresses two things that were done in https://github.com/Unleash/unleash/pull/4004 and that I believe to be bugs. 1. It shows the previous strategy name also if there was no previous title. So if there was no previous title, it'll show the strategy name with a strikethrough and then the new title (see the discussion section). 2. It changes a `span` component to a [`del` component](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/del). I believe the span was erroneously changed from a `s` component (strikethrough component) in the linked PR (based on a comment on the PR). This caused the strikethrough to not be there anymore. However, the `del` component is semantically more correct and reintroduces the strikethrough, so it is a better change. 3. It uses [`ins` elements](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ins) for names that have changed. Finally, it removes a redundant pair of curly braces. How it looks now:  ## Discussion Regarding point 1: It might be that we don't want to show a strikethrough through the name of the strategy if there was no previous title. In that case, the changes related to the first point should be removed. If we do that, it looks like this:  It makes it harder (impossible, actually) to see when a custom title was added, but that might be what we want. But maybe the solution is to also use `ins` elements for new data. That way the difference is visible (and semantically correct):  |
||
|---|---|---|
| .. | ||
| ChangeRequest | ||
| ChangeRequestConfirmDialog | ||
| ChangeRequestOverview | ||
| ChangeRequestSidebar | ||
| ChangeRequestStatusBadge | ||
| ProjectChangeRequests | ||
| ChangeRequest.test.tsx | ||
| changeRequest.types.ts | ||
| ChangeRequestPermissions.test.tsx | ||
| changesCount.ts | ||