mirror of
https://github.com/Unleash/unleash.git
synced 2025-05-12 01:17:04 +02:00
2bad98a121
This PR fixes how Unleash handles tag values. Specifically, it does these things: 1. Trims leading and trailing whitespace from tag values before inserting them into the database 2. Updates OpenAPI validation to not allow whitespace-only and to ignore leading and trailing whitespace Additionally, it moves the tag length constants into the constants file from the Joi tag schema file. This is because importing the values previously rendered them as undefined (probably due to a circular dependency somewhere in the system). This means that the previous values were also ignored by OpenAPI. UI updates reflecting this wil follow. ## Background When you tag a flag, there's nothing stopping you from using an entirely empty tag or a tag with leading/trailing whitespace. Empty tags make little sense and leading trailing whitespace differences are incredibly subtle:  Additionally, leading and trailing whitespace is not shown in the dropdown list, so you'd have to guess at which is the right one.  |
||
|---|---|---|
| .. | ||
| project | ||
| user | ||
| addon.ts | ||
| api-token.test.ts | ||
| api-token.ts | ||
| config.test.ts | ||
| config.ts | ||
| constraints.ts | ||
| context.test.ts | ||
| context.ts | ||
| email.test.ts | ||
| email.ts | ||
| environments.ts | ||
| event.ts | ||
| events.test.ts | ||
| favorites.ts | ||
| feature-type.ts | ||
| index.ts | ||
| instance-admin.ts | ||
| metrics.test.ts | ||
| metrics.ts | ||
| public-signup.test.ts | ||
| public-signup.ts | ||
| strategy.test.ts | ||
| strategy.ts | ||
| tag.test.ts | ||
| tag.ts | ||
| telemetry.ts | ||
| user-admin.ts | ||
| user-feedback.ts | ||
| user-splash.ts | ||