bd0cd018c9
This PR is a combination of two PRs: This PR adds a functioning environment selection button to the new project creation form. Selected environments are added to the payload and to the API preview. The implementation is mostly lifted from the existing FilterItem component we have for search filters. However, our need here is less complex, so I've removed some of the things we don't need. There is still more cleanup to be done, however, but I'd like to implement the rest of the submenus first, to see what we really do need in the end. --- This PR adds support for stickiness and project mode in the new project creation form. Achieve this, it does a few things: 1. Moves `resolveStickinessOptions` from `frontend/src/component/feature/StrategyTypes/FlexibleStrategy/StickinessSelect/StickinessSelect.tsx` and into a separate hook. This component was used by the old project creation form. Because the new form has a different input, but needs the same option, moved that code into a reusable hook. 2. It adds functioning buttons for project stickiness and mode. 3. It adds labels to the search inputs for the dropdowns. Inputs *must* have labels to meet a11y requirements. However, the designs don't have labels, so we can hide them visually. Though that leads to another issue (refer to the screen shot below). 4. It updates the `SelectionButton` component to handle both single- and multiselect cases. It instead exports these two subcomponents. These are currently in one file, but I'll split them out into their separate files in a later PR. As a side effect of working with the selection buttons, it also improves how we handle keyboard interaction for these buttons. Here's what it looks like for single-select lists. Notice the missing part of the input's border around the top (where the label *would* be if we showed it). We should figure out how best to handle it. I've done like this for now, but we can sort it out later.  |
||
|---|---|---|
| .. | ||
| cypress | ||
| public | ||
| scripts | ||
| src | ||
| .editorconfig | ||
| .gitignore | ||
| .nvmrc | ||
| check-imports.rc | ||
| cypress.config.ts | ||
| cypress.d.ts | ||
| index.html | ||
| index.js | ||
| orval.config.js | ||
| package.json | ||
| README.md | ||
| tsconfig.json | ||
| tsconfig.node.json | ||
| vercel.json | ||
| vite.config.mts | ||
| yarn.lock | ||
frontend
This directory contains the Unleash Admin UI frontend app.
Run with a local instance of the unleash-api
Refer to the Contributing to Unleash guide for instructions. The frontend dev server runs (in port 3000) simultaneously with the backend dev server (in port 4242):
yarn install
yarn dev
Run with a sandbox instance of the Unleash API
Alternatively, instead of running unleash-api on localhost, you can use a remote instance:
cd ./frontend
yarn install
yarn run start:sandbox
Running end-to-end tests
We have a set of Cypress tests that run on the build before a PR can be merged so it's important that you check these yourself before submitting a PR. On the server the tests will run against the deployed Heroku app so this is what you probably want to test against:
yarn run start:sandbox
In a different shell, you can run the tests themselves:
yarn run e2e:heroku
If you need to test against patches against a local server instance, you'll need to run that, and then run the end to end tests using:
yarn run e2e
You may also need to test that a feature works against the enterprise version of unleash. Assuming the Heroku instance is still running, this can be done by:
yarn run start:enterprise
yarn run e2e
Generating the OpenAPI client
The frontend uses an OpenAPI client generated from the backend's OpenAPI spec. Whenever there are changes to the backend API, the client should be regenerated:
For now we only use generated types (src/openapi/models). We will use methods (src/openapi/apis) for new features soon.
yarn gen:api
rm -rf src/openapi/apis
clean up src/openapi/index.ts imports, only keep first line export * from './models';
This script assumes that you have a running instance of the enterprise backend at http://localhost:4242.
The new OpenAPI client will be generated from the runtime schema of this instance.
The target URL can be changed by setting the UNLEASH_OPENAPI_URL env var.
Analyzing bundle size
npx vite-bundle-visualizer in the root of the frontend directory