1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-10-27 11:02:16 +01:00
unleash.unleash/frontend/src/component/events
Thomas Heartman 2d0fb765f0
fix: align event log filter buttons (#7726)
Fixes an issue where the filter buttons were both too far down and too
far to the right.

The issue was that the wrapper body imposed a pretty substantial bit
of padding. However, the filter buttons already came with their own
bit of padding. The result of this was alignment issues.

To fix it I have:
- opened the `Filters` component up to be styled with styled components

And conditionally (when isEnterprise and the flag is on):
- set the page body to have no padding.
- added a wrapper with padding around the event search results for 

This feels a little messy to me, but I also think that because it's
still in heavy development, it might change later. I'd be happy to have
suggestions forbetter implementations.

What makes this extra tricky is that the top padding differs depending
on whether you have the filters there or not, so I couldn't find a way
to just remove that component and be done with it. I may very well have
missed somehing, though.

Before:

![image](https://github.com/user-attachments/assets/1552d1ec-2c14-450f-9ce8-8e74389f11a1)

After: 

![image](https://github.com/user-attachments/assets/d58b6fe5-437f-4488-bf01-cabfef669e2e)
2024-08-02 11:09:55 +02:00
..
EventCard chore: use EventSchema instead of IEvent (#7732) 2024-08-02 11:05:42 +02:00
EventDiff chore: use EventSchema instead of IEvent (#7732) 2024-08-02 11:05:42 +02:00
EventJson chore: use EventSchema instead of IEvent (#7732) 2024-08-02 11:05:42 +02:00
EventLog fix: align event log filter buttons (#7726) 2024-08-02 11:09:55 +02:00
EventPage feat: biome lint frontend (#4903) 2023-10-02 13:25:46 +01:00