mirror of
https://github.com/Unleash/unleash.git
synced 2025-10-22 11:18:20 +02:00
cb4beb71ac
Doesn't clear the value from the constraint input value popover if you close it and then re-open. In other words, if you accidentally click out, you don't lose your progress. Instead, the popover will open again, with the value you had when you closed it highlighted (so that it's easy to type over if you want to): <img width="452" alt="image" src="https://github.com/user-attachments/assets/d86aa00e-4956-40a8-8fea-e75be5d5425b" /> The reason I'm changing this now is because I noticed that the error wasn't cleared correctly when the popover was closed. If we do it this way instead, then that makes sense, because you can still see the value. This is also how the single-value popover has worked forever. From some quick testing, the single value popover still works as expected: <img width="562" alt="image" src="https://github.com/user-attachments/assets/9041a922-b055-4310-ab60-93ad219981a4" /> As a side note: I'm adding a comment to anyone coming after as to why focus handling on escape doesn't work correctly on the single value button. I was about to go down a rabbit hole on that before I read my own comment on the previous PR. So I thought I'd put that here too. |
||
|---|---|---|
| .. | ||
| useEditableConstraint | ||
| AddSingleValueWidget.tsx | ||
| AddValuesPopover.tsx | ||
| AddValuesWidget.tsx | ||
| ConstraintDateInput.tsx | ||
| ConstraintOperatorSelect.tsx | ||
| ConstraintValidatorOutput.ts | ||
| ConstraintValueSearch.tsx | ||
| EditableConstraint.tsx | ||
| LegalValuesSelector.tsx | ||
| ValueList.tsx | ||