mirror of
https://github.com/Unleash/unleash.git
synced 2024-12-28 00:06:53 +01:00
acecffd93f
To fix this we had to create a free trial account on cypress and enable
the recording of the test. That way we found out the issue was with a
locale:
Probably, this works well locally because our local machines do have a
default locale, but probably we don't have one when running in CI, and
millify library is causing the tests to fail specifically at this line:
363911c4a1/frontend/src/component/common/AvatarGroup/AvatarGroup.tsx (L89)
(validated
[here](https://github.com/Unleash/unleash/pull/8040/files#diff-afc857890da2221bd34feed0ff45dd7745ff32fb0b27055214cbe69896d5311dL89)).
Unfortunately, upgrading millify didn't help, but downgrading to v5
(which doesn't support locales), solve the issue at the cost of not
having the up-to-date library:
https://github.com/Unleash/unleash/pull/8048
I believe the issue is related to this locale `c` reported here:
https://github.com/cypress-io/cypress/issues/7890#issuecomment-2105991364
because only after overriding the languages this worked
30 lines
640 B
YAML
30 lines
640 B
YAML
name: PR -> Frontend Build & Test
|
|
|
|
on:
|
|
pull_request:
|
|
paths:
|
|
- frontend/**
|
|
- .github/workflows/**frontend**
|
|
|
|
jobs:
|
|
build:
|
|
runs-on: ubuntu-latest
|
|
name: build
|
|
defaults:
|
|
run:
|
|
working-directory: frontend
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
- name: Use Node.js 20.x
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: 20.x
|
|
- name: Enable corepack
|
|
run: corepack enable
|
|
- run: yarn --immutable
|
|
- run: yarn run lint:material:icons
|
|
- run: yarn run lint:check
|
|
- run: yarn run test
|
|
- run: yarn run ts:check # TODO: optimize
|