mirror of
https://github.com/Unleash/unleash.git
synced 2025-09-19 17:52:45 +02:00
31ed96d8f3
While having a pattern when you have no example doesn't make a lot of sense, it's a problem that you can't delete the example after deleting the pattern: you previously had to remove the example before the pattern. This PR fixes that by always allowing you to update the example, even if there is no pattern. Our server doesn't currently accept submitting an example with no pattern, but we could allow that if we want to (and probably just discard it on the back-end). This PR also updates the validation of the example and the regex. There were more unhandled edge cases previously where the validation would disappear or be wrong. This should be fixed now. The new logic is that, whenever you update the either the pattern or the example, we check: - if you have an error in your pattern, no pattern, or no example, then delete the example error if it exists - have a well-formed pattern and an example then check if the example matches the pattern and add/delete an error accordingly This does have some consequences: editing the pattern can render your example invalid. You'll also get immediate feedback instead of when you switch focus. I think this is often a bad pattern (giving the user too much negative feedback), but in terms of working with regexes, I think it might be a good thing. We also give immediate feedback today, so I don't think this is a regression. Any thoughts are welcome. |
||
|---|---|---|
| .. | ||
| __mocks__ | ||
| assets | ||
| component | ||
| constants | ||
| contexts | ||
| hooks | ||
| interfaces | ||
| openapi | ||
| themes | ||
| types | ||
| utils | ||
| index.tsx | ||
| setupTests.ts | ||
| vite-env.d.ts | ||