mirror of
https://github.com/Unleash/unleash.git
synced 2025-01-06 00:07:44 +01:00
392beee114
This PR updates the back-end handling of feature naming patterns to add implicit leading `^`s and trailing `$`s to the regexes when comparing them. It also adds tests for the new behavior, both for new flag names and for examples. ## Discussion points Regarding stripping incoming ^ and $: We don't actually need to strip incoming `^`s and `$`s: it appears that `^^^^^x$$$$$` is just as valid as `^x$`. As such, we can leave that in. However, if we think it's better to strip, we can do that too. Second, I'm considering moving the flag naming validation into a dedicated module to encapsulate everything a little better. Not sure if this is the time or where it would live, but open to hearing suggestions. |
||
---|---|---|
.. | ||
client-metrics | ||
access-service.test.ts | ||
access-service.ts | ||
account-service.ts | ||
addon-schema.ts | ||
addon-service-test-simple-addon.ts | ||
addon-service.test.ts | ||
addon-service.ts | ||
api-token-service.test.ts | ||
api-token-service.ts | ||
client-spec-service.test.ts | ||
client-spec-service.ts | ||
context-schema.ts | ||
context-service.ts | ||
edge-service.ts | ||
email-service.test.ts | ||
email-service.ts | ||
environment-service.ts | ||
event-announcer-service.ts | ||
event-service.ts | ||
favorites-service.ts | ||
feature-service-potentially-stale.test.ts | ||
feature-tag-service.ts | ||
feature-toggle-service.ts | ||
feature-type-service.ts | ||
group-service.ts | ||
health-service.ts | ||
index.ts | ||
instance-stats-service.test.ts | ||
instance-stats-service.ts | ||
maintenance-service.test.ts | ||
maintenance-service.ts | ||
openapi-service.ts | ||
pat-service.ts | ||
project-health-service.ts | ||
project-schema.ts | ||
project-service.ts | ||
proxy-service.ts | ||
public-signup-token-service.ts | ||
reset-token-service.ts | ||
scheduler-service.test.ts | ||
scheduler-service.ts | ||
segment-schema.ts | ||
segment-service.ts | ||
session-service.ts | ||
setting-service.ts | ||
state-schema.ts | ||
state-service-export-v1.json | ||
state-service.test.ts | ||
state-service.ts | ||
state-util.ts | ||
strategy-schema.ts | ||
strategy-service.ts | ||
tag-schema.test.ts | ||
tag-schema.ts | ||
tag-service.ts | ||
tag-type-schema.test.ts | ||
tag-type-schema.ts | ||
tag-type-service.ts | ||
user-feedback-service.ts | ||
user-service.test.ts | ||
user-service.ts | ||
user-splash-service.ts | ||
version-service.test.ts | ||
version-service.ts |