1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-20 00:08:02 +01:00
unleash.unleash/frontend/src/utils/withTableState.test.tsx
Jaanus Sellin 3acb3ad2c2
feat: upgrade from react v17 to v18 (#7265)
**Upgrade to React v18 for Unleash v6. Here's why I think it's a good
time to do it:**
- Command Bar project: We've begun work on the command bar project, and
there's a fantastic library we want to use. However, it requires React
v18 support.
- Straightforward Upgrade: I took a look at the upgrade guide
https://react.dev/blog/2022/03/08/react-18-upgrade-guide and it seems
fairly straightforward. In fact, I was able to get React v18 running
with minimal changes in just 10 minutes!
- Dropping IE Support: React v18 no longer supports Internet Explorer
(IE), which is no longer supported by Microsoft as of June 15, 2022.
Upgrading to v18 in v6 would be a good way to align with this change.

TS updates:
* FC children has to be explicit:
https://stackoverflow.com/questions/71788254/react-18-typescript-children-fc
* forcing version 18 types in resolutions:
https://sentry.io/answers/type-is-not-assignable-to-type-reactnode/

Test updates:
* fixing SWR issue that we have always had but it manifests more in new
React (https://github.com/vercel/swr/issues/2373)

---------

Co-authored-by: kwasniew <kwasniewski.mateusz@gmail.com>
2024-06-11 13:59:52 +03:00

350 lines
9.8 KiB
TypeScript

import { vi } from 'vitest';
import { renderHook } from '@testing-library/react';
import { useReactTable } from '@tanstack/react-table';
import { withTableState } from './withTableState';
import { useState } from 'react';
import { render } from '@testing-library/react';
describe('withTableState', () => {
it('should create paginated and sorted table state', () => {
const mockTableState = {
limit: 10,
offset: 10,
sortBy: 'name',
sortOrder: 'asc',
};
const mockSetTableState = vi.fn();
const mockOptions = { data: [], columns: [] };
const result = withTableState(
mockTableState,
mockSetTableState,
mockOptions,
);
expect(result.state).toEqual({
pagination: {
pageIndex: 1,
pageSize: 10,
},
sorting: [
{
id: 'name',
desc: false,
},
],
});
});
it('sets default options', () => {
expect(
withTableState(
{
limit: 10,
offset: 10,
sortBy: 'name',
sortOrder: 'asc',
},
vi.fn(),
{ data: [], columns: [] },
),
).toMatchObject({
getCoreRowModel: expect.any(Function),
enableSorting: true,
enableMultiSort: false,
manualPagination: true,
manualSorting: true,
enableSortingRemoval: false,
enableHiding: true,
onPaginationChange: expect.any(Function),
onSortingChange: expect.any(Function),
onColumnVisibilityChange: expect.any(Function),
});
});
it('should update page index and size', () => {
const mockTableState = {
limit: 10,
offset: 10,
sortBy: 'name',
sortOrder: 'asc',
};
const mockSetTableState = vi.fn();
const mockOptions = { data: [], columns: [] };
const { result } = renderHook(() =>
useReactTable(
withTableState(mockTableState, mockSetTableState, mockOptions),
),
);
result.current.setPagination({
pageIndex: 3,
pageSize: 5,
});
expect(mockSetTableState).toHaveBeenCalledWith({
limit: 5,
offset: 15,
});
});
it('should update sorting', () => {
const mockTableState = {
limit: 10,
offset: 10,
sortBy: 'name',
sortOrder: 'asc',
};
const mockSetTableState = vi.fn();
const mockOptions = { data: [], columns: [] };
const { result } = renderHook(() =>
useReactTable(
withTableState(mockTableState, mockSetTableState, mockOptions),
),
);
result.current.setSorting([
{
id: 'createdAt',
desc: true,
},
]);
expect(mockSetTableState).toHaveBeenCalledWith({
sortBy: 'createdAt',
sortOrder: 'desc',
});
});
it('should handle column visibility', () => {
const mockTableState = {
limit: 10,
offset: 10,
sortBy: 'name',
sortOrder: 'asc',
columns: ['name'],
};
const mockSetTableState = vi.fn();
const mockOptions = {
data: [],
columns: [
{
id: 'name',
show: true,
},
{
id: 'createdAt',
show: false,
},
],
};
const { result } = renderHook(() =>
useReactTable(
withTableState(mockTableState, mockSetTableState, mockOptions),
),
);
expect(result.current.getState().columnVisibility).toMatchObject({
name: true,
});
result.current.setColumnVisibility({ name: false, createdAt: true });
expect(mockSetTableState).toHaveBeenCalledWith({
columns: ['createdAt'],
});
});
it('is always using external state', () => {
const initialProps = {
limit: 5,
offset: 40,
sortBy: 'name',
sortOrder: 'desc',
};
const { result, rerender } = renderHook(
(state) =>
useReactTable(
withTableState(state as any, vi.fn(), {
data: [],
columns: [],
}),
),
{ initialProps },
);
expect(result.current.getState()).toMatchObject({
pagination: {
pageIndex: 8,
pageSize: 5,
},
sorting: [
{
id: 'name',
desc: true,
},
],
});
rerender({
limit: 10,
offset: 10,
sortBy: 'createdAt',
sortOrder: 'asc',
});
expect(result.current.getState()).toMatchObject({
pagination: {
pageIndex: 1,
pageSize: 10,
},
sorting: [
{
id: 'createdAt',
desc: false,
},
],
});
});
it('works end-to-end with useReactTable', async () => {
const Component = () => {
const [state, setState] = useState({
limit: 5,
offset: 40,
sortBy: 'name',
sortOrder: 'desc',
});
const setTableState = (newState: any) => {
setState((state) => ({ ...state, ...newState }));
};
const table = useReactTable(
withTableState(state, setTableState, {
data: [],
columns: [],
}),
);
return (
<>
<button type='button' onClick={table.nextPage}>
Next page
</button>
<button type='button' onClick={table.previousPage}>
Previous page
</button>
<button
type='button'
onClick={() =>
table.setPagination({ pageIndex: 2, pageSize: 10 })
}
>
Paginate
</button>
<button
type='button'
onClick={() =>
table.setSorting([{ id: 'createdAt', desc: true }])
}
>
Sort
</button>
<textarea
value={JSON.stringify(table.getState())}
readOnly
/>
<input
data-testid='page'
type='text'
value={table.getState().pagination.pageIndex}
readOnly
/>
<input
data-testid='pageSize'
type='text'
value={table.getState().pagination.pageSize}
readOnly
/>
<input
data-testid='sort'
type='text'
value={table.getState().sorting[0].id}
readOnly
/>
</>
);
};
const { getByTestId, findByTestId, getByRole, findByRole } = render(
<Component />,
);
expect(getByTestId('page')).toHaveValue('8');
expect(getByTestId('pageSize')).toHaveValue('5');
expect(getByTestId('sort')).toHaveValue('name');
(await findByRole('button', { name: 'Next page' })).click();
expect(await findByTestId('page')).toHaveValue('9');
(await findByRole('button', { name: 'Previous page' })).click();
expect(await findByTestId('page')).toHaveValue('8');
(await findByRole('button', { name: 'Paginate' })).click();
expect(await findByTestId('page')).toHaveValue('2');
expect(getByTestId('pageSize')).toHaveValue('10');
const button = await findByRole('button', { name: 'Sort' });
button.click();
const sort = await findByTestId('sort');
expect(sort).toHaveValue('createdAt');
});
it('always shows columns that have `enableHiding: false`', () => {
const mockTableState = {
limit: 10,
offset: 10,
sortBy: 'name',
sortOrder: 'asc',
columns: ['createdAt'],
};
const mockSetTableState = vi.fn();
const mockOptions = {
data: [],
columns: [
{
id: 'name',
show: false,
enableHiding: false,
},
{
id: 'createdAt',
show: true,
},
],
};
const result = withTableState(
mockTableState,
mockSetTableState,
mockOptions,
);
expect(result.state).toMatchObject({
columnVisibility: {
name: true,
createdAt: true,
},
});
});
});