mirror of
https://github.com/Unleash/unleash.git
synced 2025-09-19 17:52:45 +02:00
39145e2617
This changes the two interfaces IChangeRequest and IChangeRequestSchedule to be union types instead of interfaces. It also extracts the constituents of those union types into proper types themselves (so that they can be used in function type signatures etc). It also updates the type names. This turned out to be more work than I had imagined, but I think the end result pays off, giving us more type safety and control. I wanted to use just `ChangeRequest` for the IChangeRequest type, but that caused issues due to naming collisions with the `ChangeRequest` component that we have, causing tests to fail. I've named it `ChangeRequestType` as a potential solution, but suggestions are welcome. The relevant changes are in `frontend/src/component/changeRequest/changeRequest.types.ts`. Everything else is updated references and some necessary refactoring to respect the new types. |
||
|---|---|---|
| .. | ||
| api | ||
| useChangeRequestAddStrategy.ts | ||
| useChangeRequestInReviewWarning.tsx | ||
| useChangeRequestsEnabled.test.tsx | ||
| useChangeRequestsEnabled.ts | ||
| useChangeRequestToggle.ts | ||
| useCollaborateData.tsx | ||
| useConditionallyHiddenColumns.ts | ||
| useDefaultProjectSettings.ts | ||
| useDragItem.ts | ||
| useEventSettings.ts | ||
| useFormErrors.ts | ||
| useGlobalLocalStorage.ts | ||
| useGlobalState.ts | ||
| useHasAccess.ts | ||
| useHiddenEnvironments.ts | ||
| useHighestPermissionChangeRequestEnvironment.test.ts | ||
| useHighestPermissionChangeRequestEnvironment.ts | ||
| useId.test.ts | ||
| useId.ts | ||
| useIsAppleDevice.ts | ||
| useKeyboardShortcut.ts | ||
| useLastViewedProject.ts | ||
| useLoading.ts | ||
| useLocationSettings.ts | ||
| useOnBlur.test.tsx | ||
| useOnBlur.ts | ||
| useOnClickOutside.test.tsx | ||
| useOnClickOutside.ts | ||
| useOnVisible.ts | ||
| useOptionalPathParam.ts | ||
| usePageTitle.ts | ||
| usePagination.ts | ||
| usePersistentGlobalState.ts | ||
| usePersistentTableState.test.tsx | ||
| usePersistentTableState.ts | ||
| usePinnedFavorites.test.ts | ||
| usePinnedFavorites.ts | ||
| usePlausibleTracker.ts | ||
| useQueryParams.ts | ||
| useRequiredPathParam.ts | ||
| useRequiredQueryParam.ts | ||
| useSearch.test.tsx | ||
| useSearch.ts | ||
| useSubmittedFeedback.ts | ||
| useTabs.ts | ||
| useThemeMode.ts | ||
| useToast.tsx | ||
| useUiFlag.ts | ||
| useUsersPlan.ts | ||
| useVariant.ts | ||
| useVirtualizedRange.ts | ||
| useWeakMap.ts | ||