1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-09-05 17:53:12 +02:00
unleash.unleash/frontend/src/component/feature/FeatureView
Thomas Heartman 64a6af2858
feat: show info on what would be deleted (#6235)
This PR updates the way we show deleted strategies in the CR UI. Instead
of showing just the strategy name and a diff on hover, we show the same
strategy config as we do for new and updated strategies.

This makes it easier to see what you have deleted.

In doing so, it also fixes two issues:
1. inconsistent border radius for segment changes listed. Due to an
override in `frontend/src/themes/theme.ts`, these would get a border
radius of `theme.shape.borderRadiusLarge` instead of
`theme.shape.borderRadiusMedium`. It does this by adding a class and
making the selector more specific.
2. The background was unset for the strategy rollout box and constraint
item boxes.

It looks like this:

<img width="728" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/7cba28ac-0454-444d-8cfa-f46543ccf2dc">

<img width="728" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/832be653-3def-4afc-b72f-36fcd76ad83d">

Or with more kinds of strategies:
<img width="454" alt="image"
src="https://github.com/Unleash/unleash/assets/17786332/f18e5482-7d2e-4cbd-8177-9de6dfb10307">


Note: I'm happy to isolate the color changes to a separate PR if that's
preferable.
2024-02-16 04:13:40 +00:00
..
FeatureEnvironmentSeen chore: add no unused imports biome rule (#5855) 2024-01-11 12:44:05 +00:00
FeatureLog feat: biome lint frontend (#4903) 2023-10-02 13:25:46 +01:00
FeatureMetrics fix: show all selected application names (#6110) 2024-02-02 11:35:00 +01:00
FeatureNotFound chore: add no unused imports biome rule (#5855) 2024-01-11 12:44:05 +00:00
FeatureOverview feat: show info on what would be deleted (#6235) 2024-02-16 04:13:40 +00:00
FeatureSettings refactor: use union types for change request types (#5870) 2024-01-12 13:15:43 +05:30
FeatureVariants Biome1.5.1 (#5867) 2024-01-12 09:25:59 +00:00
FeatureView.tsx chore: add no unused imports biome rule (#5855) 2024-01-11 12:44:05 +00:00
FeatureViewLazyExport.tsx Refactor/lazy load (#2842) 2023-01-12 11:34:45 +01:00
LazyFeatureView.tsx Refactor/lazy load (#2842) 2023-01-12 11:34:45 +01:00