1
0
mirror of https://github.com/Unleash/unleash.git synced 2025-01-01 00:08:27 +01:00
unleash.unleash/frontend/src/component/changeRequest
Thomas Heartman f7006642a6
fix: Only show names as changed when titles have changed. (#3843)
Related to [linear task
1-954](https://linear.app/unleash/issue/1-954/disabling-last-strategy-in-change-request-shows-strikethrough).

This PR changes the display logic for showing titles as changed: it
previously fell back to always being `true` if there was a custom title
set for a strategy. This PR makes it so that it only shows as changed if
the title has actually changed, either from one custom title to another,
or to and from the display name.

To accommodate the last bit, it also shows display names with a
strikethrough if the strategy had no title previously, but now it does. This is consistent with how it displays the strategy name if you delete a title from a strategy.


Here's a number of different examples: 


![image](https://github.com/Unleash/unleash/assets/17786332/034bcc01-8715-4052-afec-56caf7edea51)
2023-05-23 12:16:20 +00:00
..
ChangeRequest fix: Only show names as changed when titles have changed. (#3843) 2023-05-23 12:16:20 +00:00
ChangeRequestConfirmDialog feat: adds CR to variants per env UI (#2989) 2023-01-25 14:10:35 +00:00
ChangeRequestOverview feat: linkify comments (#3517) 2023-04-13 15:48:03 +03:00
ChangeRequestSidebar feat: edit change requests (#3573) 2023-04-24 15:32:19 +02:00
ChangeRequestStatusBadge styling change request sidebar (#2350) 2022-11-08 16:16:30 +01:00
ProjectChangeRequests feat: add UI to variant metrics (#3697) 2023-05-08 10:15:26 +00:00
ChangeRequest.test.tsx feat: skip change request in UI (#3495) 2023-04-11 14:47:54 +02:00
changeRequest.types.ts Disable and enable strategies - frontend (#3582) 2023-04-26 11:41:24 +02:00
ChangeRequestPermissions.test.tsx feat: skip change request in UI (#3495) 2023-04-11 14:47:54 +02:00
changesCount.ts changes count (#2515) 2022-11-24 12:29:14 +01:00