mirror of
https://github.com/Unleash/unleash.git
synced 2025-01-06 00:07:44 +01:00
4cedb00e04
## About the changes `getUserRootRoles` should also consider custom root roles This introduces test cases that unveiled a dependency between stores (this happens actually at the DB layer having access-service access tables from two different stores but skipping the store layer). https://linear.app/unleash/issue/2-1161/a-user-with-custom-root-role-and-permission-to-create-client-api --------- Co-authored-by: Nuno Góis <github@nunogois.com>
172 lines
4.9 KiB
TypeScript
172 lines
4.9 KiB
TypeScript
import NameExistsError from '../error/name-exists-error';
|
|
import getLogger from '../../test/fixtures/no-logger';
|
|
import { createFakeAccessService } from '../features/access/createAccessService';
|
|
import { IRoleValidation } from './access-service';
|
|
import { createTestConfig } from '../../test/config/test-config';
|
|
import { CUSTOM_ROOT_ROLE_TYPE } from '../util/constants';
|
|
|
|
function getSetup(customRootRoles: boolean = false) {
|
|
const config = createTestConfig({
|
|
getLogger,
|
|
experimental: {
|
|
flags: {
|
|
customRootRoles: customRootRoles,
|
|
},
|
|
},
|
|
});
|
|
|
|
return {
|
|
accessService: createFakeAccessService(config),
|
|
};
|
|
}
|
|
|
|
test('should fail when name exists', async () => {
|
|
const { accessService } = getSetup();
|
|
const existingRole = await accessService.createRole({
|
|
name: 'existing role',
|
|
description: 'description',
|
|
permissions: [],
|
|
});
|
|
|
|
expect(accessService.validateRole(existingRole)).rejects.toThrow(
|
|
new NameExistsError(
|
|
`There already exists a role with the name ${existingRole.name}`,
|
|
),
|
|
);
|
|
});
|
|
|
|
test('should validate a role without permissions', async () => {
|
|
const { accessService } = getSetup();
|
|
|
|
const withoutPermissions: IRoleValidation = {
|
|
name: 'name of the role',
|
|
description: 'description',
|
|
};
|
|
expect(await accessService.validateRole(withoutPermissions)).toEqual(
|
|
withoutPermissions,
|
|
);
|
|
});
|
|
|
|
test('should complete description field when not present', async () => {
|
|
const { accessService } = getSetup();
|
|
const withoutDescription: IRoleValidation = {
|
|
name: 'name of the role',
|
|
};
|
|
expect(await accessService.validateRole(withoutDescription)).toEqual({
|
|
name: 'name of the role',
|
|
description: '',
|
|
});
|
|
});
|
|
|
|
test('should accept empty permissions', async () => {
|
|
const { accessService } = getSetup();
|
|
const withEmptyPermissions: IRoleValidation = {
|
|
name: 'name of the role',
|
|
description: 'description',
|
|
permissions: [],
|
|
};
|
|
expect(await accessService.validateRole(withEmptyPermissions)).toEqual({
|
|
name: 'name of the role',
|
|
description: 'description',
|
|
permissions: [],
|
|
});
|
|
});
|
|
|
|
test('should complete environment field of permissions when not present', async () => {
|
|
const { accessService } = getSetup();
|
|
const withoutEnvironmentInPermissions: IRoleValidation = {
|
|
name: 'name of the role',
|
|
description: 'description',
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
},
|
|
],
|
|
};
|
|
expect(
|
|
await accessService.validateRole(withoutEnvironmentInPermissions),
|
|
).toEqual({
|
|
name: 'name of the role',
|
|
description: 'description',
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
environment: '',
|
|
},
|
|
],
|
|
});
|
|
});
|
|
|
|
test('should return the same object when all fields are valid and present', async () => {
|
|
const { accessService } = getSetup();
|
|
|
|
const roleWithAllFields: IRoleValidation = {
|
|
name: 'name of the role',
|
|
description: 'description',
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
environment: 'development',
|
|
},
|
|
],
|
|
};
|
|
expect(await accessService.validateRole(roleWithAllFields)).toEqual({
|
|
name: 'name of the role',
|
|
description: 'description',
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
environment: 'development',
|
|
},
|
|
],
|
|
});
|
|
});
|
|
|
|
test('should be able to validate and cleanup with additional properties', async () => {
|
|
const { accessService } = getSetup();
|
|
const base = {
|
|
name: 'name of the role',
|
|
description: 'description',
|
|
additional: 'property',
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
environment: 'development',
|
|
name: 'name',
|
|
displayName: 'displayName',
|
|
type: 'type',
|
|
additional: 'property',
|
|
},
|
|
],
|
|
};
|
|
expect(await accessService.validateRole(base)).toEqual({
|
|
name: 'name of the role',
|
|
description: 'description',
|
|
permissions: [
|
|
{
|
|
id: 1,
|
|
environment: 'development',
|
|
},
|
|
],
|
|
});
|
|
});
|
|
|
|
test('user with custom root role should get a user root role', async () => {
|
|
const { accessService } = getSetup(true);
|
|
const customRootRole = await accessService.createRole({
|
|
name: 'custom-root-role',
|
|
description: 'test custom root role',
|
|
type: CUSTOM_ROOT_ROLE_TYPE,
|
|
permissions: [],
|
|
});
|
|
const user = {
|
|
id: 1,
|
|
rootRole: customRootRole.id,
|
|
};
|
|
await accessService.setUserRootRole(user.id, customRootRole.id);
|
|
|
|
const roles = await accessService.getUserRootRoles(user.id);
|
|
expect(roles).toHaveLength(1);
|
|
expect(roles[0].name).toBe('custom-root-role');
|
|
});
|